From: Stanimir Varbanov <stanimir.varbanov@linaro.org>
To: Dinghao Liu <dinghao.liu@zju.edu.cn>, kjlu@umn.edu
Cc: Stanimir Varbanov <stanimir.varbanov@linaro.org>,
Andy Gross <agross@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] media: venus: venc: Fix runtime PM imbalance in venc_open
Date: Tue, 23 Jun 2020 12:47:11 +0300 [thread overview]
Message-ID: <c7f623b3-792b-d53f-a2ab-3736b79cb9b3@linaro.org> (raw)
In-Reply-To: <20200524043132.32758-1-dinghao.liu@zju.edu.cn>
Hi Dinghao,
Thanks for the patch!
On 5/24/20 7:31 AM, Dinghao Liu wrote:
> pm_runtime_get_sync() increments the runtime PM usage counter even
> when it returns an error code. Thus a pairing decrement is needed on
> the error handling path to keep the counter balanced.
>
> Signed-off-by: Dinghao Liu <dinghao.liu@zju.edu.cn>
> ---
> drivers/media/platform/qcom/venus/venc.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
Acked-by: Stanimir Varbanov <stanimir.varbanov@linaro.org>
>
> diff --git a/drivers/media/platform/qcom/venus/venc.c b/drivers/media/platform/qcom/venus/venc.c
> index 9981a2a27c90..eefcfbb8f211 100644
> --- a/drivers/media/platform/qcom/venus/venc.c
> +++ b/drivers/media/platform/qcom/venus/venc.c
> @@ -1169,7 +1169,7 @@ static int venc_open(struct file *file)
>
> ret = pm_runtime_get_sync(core->dev_enc);
> if (ret < 0)
> - goto err_free_inst;
> + goto err_put_sync;
>
> ret = venc_ctrl_init(inst);
> if (ret)
> @@ -1214,7 +1214,6 @@ static int venc_open(struct file *file)
> venc_ctrl_deinit(inst);
> err_put_sync:
> pm_runtime_put_sync(core->dev_enc);
> -err_free_inst:
> kfree(inst);
> return ret;
> }
>
--
regards,
Stan
prev parent reply other threads:[~2020-06-23 9:47 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-24 4:31 [PATCH] media: venus: venc: Fix runtime PM imbalance in venc_open Dinghao Liu
2020-06-23 9:47 ` Stanimir Varbanov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c7f623b3-792b-d53f-a2ab-3736b79cb9b3@linaro.org \
--to=stanimir.varbanov@linaro.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=dinghao.liu@zju.edu.cn \
--cc=kjlu@umn.edu \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox