Re: [PATCH v3 2/2] arm64: dts: qcom: sa8775p-ride: Enable Adreno 663 GPU

[Akhil P Oommen <quic_akhilpo@quicinc.com>]

On 2/12/2025 5:30 AM, Dmitry Baryshkov wrote:
> On Tue, Feb 11, 2025 at 06:41:39PM +0530, Akhil P Oommen wrote:
>> On 2/9/2025 9:59 PM, Dmitry Baryshkov wrote:
>>> On Wed, Nov 13, 2024 at 02:18:43AM +0530, Akhil P Oommen wrote:
>>>> On 10/30/2024 12:32 PM, Akhil P Oommen wrote:
>>>>> From: Puranam V G Tejaswi <quic_pvgtejas@quicinc.com>
>>>>>
>>>>> Enable GPU for sa8775p-ride platform and provide path for zap
>>>>> shader.
>>>>>
>>>>> Signed-off-by: Puranam V G Tejaswi <quic_pvgtejas@quicinc.com>
>>>>> Signed-off-by: Akhil P Oommen <quic_akhilpo@quicinc.com>
>>>>> Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
>>>>> ---
>>>>>  arch/arm64/boot/dts/qcom/sa8775p-ride.dtsi | 8 ++++++++
>>>>>  1 file changed, 8 insertions(+)
>>>>>
>>>>> diff --git a/arch/arm64/boot/dts/qcom/sa8775p-ride.dtsi b/arch/arm64/boot/dts/qcom/sa8775p-ride.dtsi
>>>>> index 0c1b21def4b6..4901163df8f3 100644
>>>>> --- a/arch/arm64/boot/dts/qcom/sa8775p-ride.dtsi
>>>>> +++ b/arch/arm64/boot/dts/qcom/sa8775p-ride.dtsi
>>>>> @@ -407,6 +407,14 @@ queue3 {
>>>>>  	};
>>>>>  };
>>>>>  
>>>>> +&gpu {
>>>>> +	status = "okay";
>>>>> +};
>>>>> +
>>>>> +&gpu_zap_shader {
>>>>> +	firmware-name = "qcom/sa8775p/a663_zap.mbn";
>>>>> +};
>>>>> +
>>>>>  &i2c11 {
>>>>>  	clock-frequency = <400000>;
>>>>>  	pinctrl-0 = <&qup_i2c11_default>;
>>>>>
>>>>
>>>> Bjorn,
>>>>
>>>> Please ignore this patch for now. This is probably not the right
>>>> platform dtsi file where gpu should be enabled. I am discussing about
>>>> this internally. Will send a revision or a new patch based on the
>>>> conclusion.
>>>
>>> Akhil, any updates on this?
>>>
>>
>> I am still waiting for the discussion about QCS9075 board dts files [1]
>> to conclude.
>>
>> [1]
>> https://lore.kernel.org/lkml/Z3eMxl1Af8TOAQW%2F@hu-wasimn-hyd.qualcomm.com/T/
> 
> Why? We currently have several boards supported. We can enable GPU on
> those as your patches are pretty fine. Then we can land Wasim's patches.
> Not to mention that the discussion seems to be dead, last message was
> sent almost a month ago.
> 

sa8775p is an automotive-grade chipset which has a pretty different
non-HLOS firmware. One of the major difference is that it has a SAFETY
monitoring system (using SAIL IP block) which monitors different
parameters like GPU frequency for eg and it takes control of the entire
system when it detects an anomaly. That means we cannot use GPU DCVS,
passive thermal mitigation etc there.

QCS9075 uses the same SoC but has different NHLOS firmwares that has
SAIL disabled to make it behave like our regular chipsets. I am aware of
only QCS9075 boards' GPU spec at the moment. I don't know the complete
details of the impact of SAIL/SAFE features on GPU and other specs yet,
so I can't disturb sa8775p-ride/qcs9100-ride boards.

I can see that Wazim is still discussing about board DTS internally.
Hopefully he will send out another revision of his series soon.

-Akhil