From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
To: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
cros-qcom-dts-watchers@chromium.org
Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/7] arm64: dts: qcom: cleanup GPU's zap-shader node
Date: Wed, 29 Oct 2025 10:33:43 +0100 [thread overview]
Message-ID: <c83079bd-ebd2-49fc-ab62-1fba08276cc4@oss.qualcomm.com> (raw)
In-Reply-To: <20251028-dt-zap-shader-v1-0-7eccb823b986@oss.qualcomm.com>
On 10/28/25 9:59 PM, Dmitry Baryshkov wrote:
> Historically all devices manually defined GPU zap-shader node in their
> board DT files. This practice is frowned upon. Add the zap-shader node
> on all platforms, define a label for it and use the label in order to
> patch the node with the firmware name.
I'm not sure this is much of an improvement, since at the end of the
series, boards still have a &gpu { zap-shader {} } section, with the
inner one not being referred to through a label, which reduces
duplication in the single LoC used to assign memory-region, but
doesn't e.g. prevent typos in the zap-shader node name
Konrad
next prev parent reply other threads:[~2025-10-29 9:33 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-28 20:59 [PATCH 0/7] arm64: dts: qcom: cleanup GPU's zap-shader node Dmitry Baryshkov
2025-10-28 21:00 ` [PATCH 1/7] arm64: dts: qcom: sdm670: create common " Dmitry Baryshkov
2025-10-30 10:57 ` Konrad Dybcio
2025-10-28 21:00 ` [PATCH 2/7] arm64: dts: qcom: sdm845: " Dmitry Baryshkov
2025-10-30 10:57 ` Konrad Dybcio
2025-10-28 21:00 ` [PATCH 3/7] arm64: dts: qcom: sc8180x: " Dmitry Baryshkov
2025-10-30 10:58 ` Konrad Dybcio
2025-10-30 10:59 ` Konrad Dybcio
2025-10-30 17:28 ` Bjorn Andersson
2025-10-30 17:50 ` Dmitry Baryshkov
2025-10-30 17:58 ` Dmitry Baryshkov
2025-10-30 18:45 ` Bjorn Andersson
2025-10-31 9:30 ` Konrad Dybcio
2025-11-01 17:04 ` Bjorn Andersson
2025-10-28 21:00 ` [PATCH 4/7] arm64: dts: qcom: sc8280xp: " Dmitry Baryshkov
2025-10-30 10:59 ` Konrad Dybcio
2025-10-28 21:00 ` [PATCH 5/7] arm64: dts: qcom: sm8250: drop duplicate memory-region defs Dmitry Baryshkov
2025-10-30 10:59 ` Konrad Dybcio
2025-10-28 21:00 ` [PATCH 6/7] arm64: dts: qcom: sc7180: add gpu_zap_shader label Dmitry Baryshkov
2025-10-30 11:03 ` Konrad Dybcio
2025-10-28 21:00 ` [PATCH 7/7] arm64: dts: qcom: " Dmitry Baryshkov
2025-10-30 11:04 ` Konrad Dybcio
2025-10-28 22:21 ` [PATCH 0/7] arm64: dts: qcom: cleanup GPU's zap-shader node David Heidelberg
2025-10-29 9:33 ` Konrad Dybcio [this message]
2025-10-29 9:35 ` Dmitry Baryshkov
2025-10-29 9:36 ` Konrad Dybcio
2025-10-29 12:35 ` Dmitry Baryshkov
2025-10-30 11:04 ` Konrad Dybcio
2025-10-30 18:46 ` Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c83079bd-ebd2-49fc-ab62-1fba08276cc4@oss.qualcomm.com \
--to=konrad.dybcio@oss.qualcomm.com \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=cros-qcom-dts-watchers@chromium.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@oss.qualcomm.com \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox