Re: [PATCH v3 3/3] arm64: dts: qcom: sc8280xp-blackrock: dt definition for WDK2023

[Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>]

On 14.10.2024 5:37 AM, Krishna Kurapati wrote:
> 
> 
> On 10/13/2024 5:24 PM, Jens Glathe via B4 Relay wrote:
>> From: Jens Glathe <jens.glathe@oldschoolsolutions.biz>
>>
>> Device tree for the Microsoft Windows Dev Kit 2023. This work
>> is based on the initial work of Merck Hung <merckhung@gmail.com>.
>>
>> The Windows Dev Kit 2023 is a nice little desktop based on sc8280xp.
>> Link: https://learn.microsoft.com/en-us/windows/arm/dev-kit/

[...]

>> +
>> +&usb_0_qmpphy {
>> +    vdda-phy-supply = <&vreg_l4d>;
>> +    phy-supply = <&vreg_l4d>;
>> +    vdda-pll-supply = <&vreg_l9d>;
>> +    pll-supply = <&vreg_l9d>;
>> +
>> +    orientation-switch;
>> +
>> +    status = "okay";
>> +};
>> +
> 
> I may be wrong but aren't only 3 supplies for femto and 2 supplies for qmp sufficient ? I see two extra supplies in each node.
> 
> Same for all the other usb phys as well.

Correct, drop the ones without "vdda-", Jens

Konrad