From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 95AA4C433EF for ; Wed, 23 Mar 2022 20:50:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344801AbiCWUwX (ORCPT ); Wed, 23 Mar 2022 16:52:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53108 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240768AbiCWUwW (ORCPT ); Wed, 23 Mar 2022 16:52:22 -0400 Received: from alexa-out-sd-01.qualcomm.com (alexa-out-sd-01.qualcomm.com [199.106.114.38]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 02933710C6 for ; Wed, 23 Mar 2022 13:50:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; i=@quicinc.com; q=dns/txt; s=qcdkim; t=1648068650; x=1679604650; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=Le8vCkALSx2+L8taW7J6S8H+GoppDn/GSqrf/tx19rg=; b=X+G4KiNGpsm7LYgTAj9SRlCx6D+fAOmmIq6qN7rDgzT7O6I5KOt0Qpts WXNb/5KTwx/iXf5StngSb5LBYW9Lhudtio2MNhI1LB40g2tAblV84fm4r Hj5/kIG0tc8RU+ey6FgqgyFlYyquKLbv8U2saB0EnT0oLvl+qTTn4Nl/F I=; Received: from unknown (HELO ironmsg05-sd.qualcomm.com) ([10.53.140.145]) by alexa-out-sd-01.qualcomm.com with ESMTP; 23 Mar 2022 13:50:49 -0700 X-QCInternal: smtphost Received: from nasanex01c.na.qualcomm.com ([10.47.97.222]) by ironmsg05-sd.qualcomm.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Mar 2022 13:50:48 -0700 Received: from nalasex01a.na.qualcomm.com (10.47.209.196) by nasanex01c.na.qualcomm.com (10.47.97.222) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.22; Wed, 23 Mar 2022 13:50:48 -0700 Received: from [10.110.52.81] (10.80.80.8) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.22; Wed, 23 Mar 2022 13:50:46 -0700 Message-ID: Date: Wed, 23 Mar 2022 13:50:46 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.6.2 Subject: Re: [PATCH 00/22] drm: Review of mode copies Content-Language: en-US To: Dmitry Baryshkov , =?UTF-8?B?VmlsbGUgU3lyasOkbMOk?= , "Alex Deucher" CC: Emma Anholt , Neil Armstrong , Xinliang Liu , Maling list - DRI developers , Thierry Reding , Jernej Skrabec , Andrzej Hajda , Sam Ravnborg , Rodrigo Siqueira , amd-gfx list , , Xinwei Kong , Aurabindo Pillai , linux-arm-msm , Alain Volmat , Chun-Kuang Hu , "Jonas Karlman" , Leo Li , Chen Feng , Intel Graphics Development , Nikola Cornij , Sean Paul , linux-arm-kernel , Tomi Valkeinen , freedreno , Sandy Huang , Robert Foss , Alex Deucher , Tian Tao , Jyri Sarha , Laurent Pinchart References: <20220218100403.7028-1-ville.syrjala@linux.intel.com> From: Abhinav Kumar In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01a.na.qualcomm.com (10.52.223.231) To nalasex01a.na.qualcomm.com (10.47.209.196) Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On 3/23/2022 3:39 AM, Dmitry Baryshkov wrote: > On 22/03/2022 01:37, Ville Syrjälä wrote: >> On Tue, Mar 15, 2022 at 02:52:38PM -0400, Alex Deucher wrote: >>> On Mon, Mar 14, 2022 at 6:12 PM Ville Syrjälä >>> wrote: >>>> >>>> On Fri, Feb 18, 2022 at 12:03:41PM +0200, Ville Syrjala wrote: >>>>>    drm: Add drm_mode_init() >>>>>    drm/bridge: Use drm_mode_copy() >>>>>    drm/imx: Use drm_mode_duplicate() >>>>>    drm/panel: Use drm_mode_duplicate() >>>>>    drm/vc4: Use drm_mode_copy() >>>> These have been pushed to drm-misc-next. >>>> >>>>>    drm/amdgpu: Remove pointless on stack mode copies >>>>>    drm/amdgpu: Use drm_mode_init() for on-stack modes >>>>>    drm/amdgpu: Use drm_mode_copy() >>>> amdgpu ones are reviewed, but I'll leave them for the >>>> AMD folks to push to whichever tree they prefer. >>> >>> I pulled patches 2, 4, 5 into my tree. >> >> Thanks. >> >>> For 3, I'm happy to have it >>> land via drm-misc with the rest of the mode_init changes if you'd >>> prefer. >> >> Either way works for me. I don't yet have reviews yet for >> the other drivers, so I'll proably hold off for a bit more >> at least. And the i915 patch I'll be merging via drm-intel. >> >>>>>    drm/radeon: Use drm_mode_copy() >>>>>    drm/gma500: Use drm_mode_copy() >>>>>    drm/tilcdc: Use drm_mode_copy() >>>>>    drm/i915: Use drm_mode_copy() >> >> Those are now all in. >> >> Which leaves us with these stragglers: >>>>>    drm/hisilicon: Use drm_mode_init() for on-stack modes > >>>>>    drm/msm: Nuke weird on stack mode copy >>>>>    drm/msm: Use drm_mode_init() for on-stack modes >>>>>    drm/msm: Use drm_mode_copy() > > These three patches went beneath my radar for some reason. > > I have just sent a replacement for the first patch ([1]). Other two > patches can be pulled in msm/msm-next (or msm/msm-fixes) during the next > development cycle if that works for you. > > [1] https://patchwork.freedesktop.org/series/101682/ Agree with this approach. We can replace the first patch with https://patchwork.freedesktop.org/series/101682/. Thanks Abhinav > >>>>>    drm/mtk: Use drm_mode_init() for on-stack modes >>>>>    drm/rockchip: Use drm_mode_copy() >>>>>    drm/sti: Use drm_mode_copy() >>>>>    drm: Use drm_mode_init() for on-stack modes >>>>>    drm: Use drm_mode_copy() >> > >