From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f41.google.com (mail-ej1-f41.google.com [209.85.218.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3859143DA40 for ; Tue, 12 May 2026 07:05:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778569536; cv=none; b=SUKhO16VIqg9eP4cOeE0dfqnXk+PvrVtrKQH95bY7kVZLM69QBaQaCuLgmJjcdgnWa2cJvFYct0se2UDzDHd4teiYyKFSHHjEp4gokFzptY+yQeu2/prRym49T4W9OjF3cth7r88CDN9U5s52p3GinwGY7DVndHCy4iSr0C/vVo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778569536; c=relaxed/simple; bh=S1y/611h5F1yDCLY2MwHHiifJrIn907EP4/nio92UgI=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=WnA4drI0Vajz93XFxUqW2NmB27rxKupprcTS1xHtxuMJuzhdv3IeYW3Cmel7qqkafjNPftuXLHl5WcvCwoYPbu/LSIXjjUSSDI/PiycF/EMyJlIE1zRNhlHCQP7dPvsb0uZ203zZE0UkM4z2dLJqVKVDGYR3K044uolZmiiL6xs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=BK0C75Yv; arc=none smtp.client-ip=209.85.218.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="BK0C75Yv" Received: by mail-ej1-f41.google.com with SMTP id a640c23a62f3a-b9d9971d059so758045966b.2 for ; Tue, 12 May 2026 00:05:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1778569530; x=1779174330; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=+au2wZMjR4hSPfSatgV6boyFWtlvztIAKTjtpXaCIFs=; b=BK0C75YvBPrANr+ri1CVo6P8WvyLhqIh/Y8/a0IL6DEoVektjOYyfz7oy7+8++me+/ wbTTyApThqtCx2Cmgo/qca4BBMIWVbILm9OTbHkQtnoV5zKbe1c2mSpbAQhNLJSb3+UZ t48MvJb/QbnP0pTt0MVfCq2bYMDsOtOwcwZpWENRVtAhCpyDKp0qviirwqWltOh/c9Ld F7wyLcNcyThyVFqc8QiUQJjWShddmJLDMbdi3e2ZIp+GREcuT5WXkHoCjXqULz1zr4Qy VziaOY5j8TvaMu/nAQtf/9+T2DYkrsgIJEYDk/jNo/4MwEgT9Tcbn6EORGPS/N6UNYpY 4pRQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778569530; x=1779174330; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=+au2wZMjR4hSPfSatgV6boyFWtlvztIAKTjtpXaCIFs=; b=XhMqa4q7Va/7VU0OCUDw9VW28K/4cE5VYSXNym5cnMpufAWktDvQZJlWz9zPA1ofum Wts8dB295pO452MBdF0t2FIgorMyr4kEZYeCXAgcVIvP1Bf0iXEqi6Gu4HOYhadLUh/A i7jyVJVamFOz+MVr8OSbUPvdWMMkyq1ONTm4/R5/mIjHYUvE4ZgY1gaOa8mJ+0UpPoOT kpN26Wr6BaqvhxO67YvFZRWBH7op4AOAfUMzzw3G0C7LFy7ONQK8D9Rjb4H1scfxpfdZ A9K9iac15UNhINLW0/LuP9157wlGooQ/TVKn9BWa0PuEY2dYW8Ej7MLmJcL4OMEen9bT J3Dw== X-Forwarded-Encrypted: i=1; AFNElJ+QyVfUeMaIkCywQ8DLPn+ViKBjHYDb7Bm1azlxYFQ9l0ovFGhaYMgRJKHAq7jYvPiKimnT3nx3oe4LJUTK@vger.kernel.org X-Gm-Message-State: AOJu0Yw46wYWDF/Mg9BcixMj3YD4YowgiuKyZ0CC7dE8WC477yM4t9F5 UDVWVj9Tht/lh1SWhNUn4/TNEbSwute2DeSm8pYinoEfkueaTq1UgRXF X-Gm-Gg: Acq92OF/6sc9rT/vYuYmDmJ88Rp/J/Y0MSAEKFxU2tOwjUr9d02SEOnterQ1dAcFvRX /I6yT9q8m4N1AR4Pb0mJTzZJvGhafbN1XIcqFvvtwDSvM2BMu5LHR5UZaGV/ZHthB9frtaTjO+6 paCg09V8sowrHU8dqpa/qp2ilaFPAl5nLT5WMq2FQR8Syc67EItWOddY1VlVd5V7nCdBN1XK50o /SgLhbr/8AGCVAMNO7qQCjrs1Ys12coC87BQh6JN/hKtigZUGko8SmtkCxragxi123GWy+jYpEf rXLcOCoWmPBVIXAE690pIT9okEYQy2qxMmihmgW5wWcblelDiuo7i554LRbC5BPyo6T7scGaksz IQKXYnfs45Vf0o7GRff2lqShG5uARXCa8SLxYT6P71mYnrlYF6ieQKFo0A7LNWdXsZIFuoWMDLe yf81rWyK0C0+4Zn5PsKKAmnMV1KUVZZjiQsb6oc11+OD8HsftFSEXC+7sLuGG0hMtaVhp1 X-Received: by 2002:a17:907:e113:b0:bd2:27c4:f453 with SMTP id a640c23a62f3a-bd227c4f500mr115768566b.9.1778569529638; Tue, 12 May 2026 00:05:29 -0700 (PDT) Received: from ?IPV6:2a00:f502:160:4e2:a099:cad9:2ecd:93de? ([2a00:f502:160:4e2:a099:cad9:2ecd:93de]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-67ef0e2c317sm4646281a12.31.2026.05.12.00.05.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 12 May 2026 00:05:29 -0700 (PDT) Message-ID: Date: Tue, 12 May 2026 10:05:26 +0300 Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 3/9] media: qcom: venus: Add msm8939 resource struct To: Bryan O'Donoghue , Vikash Garodia , Dikshita Agarwal , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Conor Dooley , =?UTF-8?Q?Andr=C3=A9_Apitzsch?= , Bjorn Andersson , Konrad Dybcio , Michael Turquette , Stephen Boyd , Brian Masney Cc: linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, ~postmarketos/upstreaming@lists.sr.ht, phone-devel@vger.kernel.org, Dmitry Baryshkov References: <20260506-msm8939-venus-rfc-v4-0-994f5eb22acb@gmail.com> <0TaxINYCitQd2DsGsbhRviwmrQkaaVMaE9vABS3gSsSPNfrgS3JPTIo_kvTzyEhGOAZuMVq-k-5T8mqDM7dnIw==@protonmail.internalid> <20260506-msm8939-venus-rfc-v4-3-994f5eb22acb@gmail.com> <108401cb-040a-441c-b463-b69df195378e@kernel.org> Content-Language: en-US From: Erikas Bitovtas In-Reply-To: <108401cb-040a-441c-b463-b69df195378e@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 5/6/26 2:33 AM, Bryan O'Donoghue wrote: > On 05/05/2026 22:44, Erikas Bitovtas wrote: >> +    .vcodec_clks = { "core0", "core1" }, >> +    .vcodec_clks_num = 2, > > This smells a bit dodgy to me. > > You already have > > struct clk *vcodec0_clks[VIDC_VCODEC_CLKS_NUM_MAX]; > struct clk *vcodec1_clks[VIDC_VCODEC_CLKS_NUM_MAX]; > > so why add vcodec_clks and put core0 and core1 into a new array. > vcodec0_clks and vcodec1_clks seem like a very natural place for core0 > and core1 clocks to live ? > Sashiko found some power management issues in my code, so I'm coming back to this. The idea is to call vcodec_clks_get only once for inline cores, thus avoiding duplicate clock assignment. Attaching to vcodec{0,1}_clks instead would mean we're adding the same clocks twice. I dropped it in later revisions, but now I want to re-introduce this, then add them in core_get_v1 instead of {vdec,venc}_get_v1.> --- > bod