From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 97266381AF8 for ; Fri, 6 Mar 2026 10:58:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772794737; cv=none; b=rI69Mhl/41YQIjD6NdGHZIyo8UI5qvkC/UYi8J5wXd9oSpiNuHa+aGw1mvRnmuNh18BKqYgk8/F2Stlt5M5T++L+y/CQkdFCEfXIFX98iSbvvnGlv/VLEHyT1IwylXVkciB6W5QZw/eRPT/1KlWlA3KGeIZJVb+tPAp43kN98p8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772794737; c=relaxed/simple; bh=Y4wrLPuVX7srnbblTwI31RPCAFoDu+8T1SGaO81gAkQ=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=VmyaXhah6blUFPtDOWUM/OttEw0YC2dlmeGSXiZLrb4KkFenBDRTiPZo1lndeV/BZ5PgViPB7sL9hmMN6BFAde6GRtGirU6dXw0Plvkaf9E8BhHYsanpxueQgz+XUbgt8/ygBO2+1zyqp2pGleW+h6nBqqIF+smpO31AV0lbylg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=mpyre+aY; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=JF43qghh; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="mpyre+aY"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="JF43qghh" Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 626AscC72802403 for ; Fri, 6 Mar 2026 10:58:54 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= ENeJQR/osskk9CeVIGiXkuHc7GD0Wvkcf5KpQhI7KjA=; b=mpyre+aYbwpIG+PA NWRzHnk1RkoJz/c0e0su7nxe2kOBF0i07dNfpSzPHDcdpVKJFGwA863S1ORebO2m +bmWRNUnMidZln4vF0O+OasxBhLSPMx5OSdL8cKIDyNszcLhq3HnmYv9cntPjhZd XJh+vRs72wOW7kVK4zQPoYddK6mV/FUEAAAWaqh5C8T/qjd4qBmUk3NNwuivcqNO OcL/wPyKM2IWGi3q+Zbtb0WiLQrJa6qP/URU/POwLQcWcqSaQEgtgJCctnAonuRQ rIB5+peKfBHJrPukN6YM5yoMpmlUZKtMcDMUkyqQ7259Y4V12KBF9aMcODBvPq1l p+SgCQ== Received: from mail-pg1-f199.google.com (mail-pg1-f199.google.com [209.85.215.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cqgp42h46-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 06 Mar 2026 10:58:54 +0000 (GMT) Received: by mail-pg1-f199.google.com with SMTP id 41be03b00d2f7-c7381a9a932so1453907a12.3 for ; Fri, 06 Mar 2026 02:58:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1772794733; x=1773399533; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=ENeJQR/osskk9CeVIGiXkuHc7GD0Wvkcf5KpQhI7KjA=; b=JF43qghhmJfjuyhHQcDTuuNgmyWsEs88Sxh2PoqbZkeRRPkHvbVJDk8vykhIUVYbQc JJFjZI9JyUnmpL+Jd86NGNOjEvYIULNluF3Om5xy0Q/Z1YERZjZgcZN1PvnxAL8e+PIY IFBL1rrVJK5L/1852vsNC8NbeYG+R0kKQ7V/i11W5KPkbK5Ra0sJ4BnhUVPTDu8hAG4z CWDr9BjJarNKhJ6+i1r2tK59sOP3hDMSlc+ah3gb+x6guJb/gbCP6YvtW1a+SDRgbTuO 9opjIbumtYaevARLhG3wZoBOQSONbp7M3+lw/PbtGpHYR+TujTfUKZ2t9MpP3+sSE9Mh PLcw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772794733; x=1773399533; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=ENeJQR/osskk9CeVIGiXkuHc7GD0Wvkcf5KpQhI7KjA=; b=f6/F+7wlFwAZuoxjcuo+gZmxGjRLRCYvAxa078tOWtNiiwbI/mt5rQqZ2RSRxb1Jzh cruJRtgGqHxobEJtnQA0sGhD1+SAUl+99pj+aSJIRDMi2qowUtmECp3DFGTG2mjRcr7V SSpi2EWHcGMnFKYK7CMLEAwaAzDH2d42R1dyFovwB6wkWXijsYd3BMsA73QdlWCLakt3 zWniI8zEAgDjf4HYaxrqnEvrEEFtF0hF4Sfc+EfyhxtY1VL3dpYj5GNHWImNeVlTxEsv Z+ipD7HOvUw3q2cjxTjTcc7rikZkE/H7UITTVJtph1vHnn5ribcEvqf/awb3wynJbWna H5Ew== X-Forwarded-Encrypted: i=1; AJvYcCXRWlHKPiDyj09L+oWsdrw5Qc2BZpcXb4PspuW7jOjd1Edfa93Ug+ITNePZk57VcWZrXCdM1shiqpEDHCgA@vger.kernel.org X-Gm-Message-State: AOJu0Yx4pMkkZ+H0zmGfQoDXXZk2DJPVWXn5iQK5MS9fRv6G6M9bW/Fe CXfHuQxD5Lq4R9VyR/eVZtBtJyNTlMoXgFy97ARqym/M4vYM9GO3k74OXnR2NNc4o3SbqW87a4R Xjlug5xYWHH0ymhFu3nebmi/rYUF0ssi4dJa1IuA6T8hmzqf0O09+wfOcde97hPekO96M X-Gm-Gg: ATEYQzwbf7vMRXZ/BtdLC9id2BQZ3DVF4K386RU119KdMeu9gNj87hSSluPQpLV4dPO v75IEONC23RlXtRn2Cmm2CQwLD93GFikrxD3D3bzDkFhunJAFGVscrlEidpu3jvamdM8S2tejON W2kQKGzBOeew2T3HxH9TWWOfnElqGSGvvOWT/sG1wUAH2EbOExUDmEV3qfspjntEKYyJA3gMd3z S0Mo+5FQKt8AJ3QF26ckl/J2D9Tfq6C7hAKLW2XXO9oWFJbxXYjqYuXlNr/W9yiCvWyZupKbBeH N/nslzgXiKgoCPQJD3Z1QymTDOliTz5EXuiOszHFzz1TfKefs/99gFskBjgiucjiOao8Z5ePmG1 +onPxRDWEfWJO2cCO1CeqRCBHeKBRh32JFE7jaagP0VQs1ZGxYCveqA== X-Received: by 2002:a05:6a20:734b:b0:38e:9c27:72e2 with SMTP id adf61e73a8af0-39858fe2873mr1933253637.28.1772794733434; Fri, 06 Mar 2026 02:58:53 -0800 (PST) X-Received: by 2002:a05:6a20:734b:b0:38e:9c27:72e2 with SMTP id adf61e73a8af0-39858fe2873mr1933235637.28.1772794732914; Fri, 06 Mar 2026 02:58:52 -0800 (PST) Received: from [10.0.0.3] ([106.222.231.181]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-c739e195c40sm1307204a12.31.2026.03.06.02.58.49 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 06 Mar 2026 02:58:52 -0800 (PST) Message-ID: Date: Fri, 6 Mar 2026 16:28:48 +0530 Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: Re: [PATCH v2 10/11] media: qcom: iris: split firmware_data from raw platform data Content-Language: en-US To: Dmitry Baryshkov , Vikash Garodia , Abhinav Kumar , Bryan O'Donoghue , Mauro Carvalho Chehab Cc: linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260228-iris-platform-data-v2-0-acf036a3c84c@oss.qualcomm.com> <20260228-iris-platform-data-v2-10-acf036a3c84c@oss.qualcomm.com> From: Dikshita Agarwal In-Reply-To: <20260228-iris-platform-data-v2-10-acf036a3c84c@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Proofpoint-ORIG-GUID: 9D7_OTYrJyvTAfxsVsBZ5Jpqsfzf6UgK X-Authority-Analysis: v=2.4 cv=LegxKzfi c=1 sm=1 tr=0 ts=69aab36e cx=c_pps a=Oh5Dbbf/trHjhBongsHeRQ==:117 a=IrIcjQS8YOhLhDNCWt0oYA==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=ZpdpYltYx_vBUK5n70dp:22 a=deA5lg_RuNhAItBNuyoA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=_Vgx9l1VpLgwpw_dHYaR:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzA2MDEwNCBTYWx0ZWRfX1oMEt7M2t6nl 15lIsGLFiyp7RfyDFt8fEYQGZqUo+Myib2BUjbshr7hAAqTpJhsZUJXVJaYB7zoQJtZT/Z/IkXO J9lxm2fmz+EU/4bDe0/7mU4f548/F0BRs2E9ru3cjt/je9sabdHgf0VkvHyvMOcIpoGHYMt90kP kctSY7KTXFBIgpd67RiWg05QarPpwquo/JdPgnmczSkHISqQsU5TIlxZOzKRf7BpbBzjejeSQC1 soqko64cd59mkj35Lun5df5wFPkGM2TcWquIsIWzY9uORAW/cXx4O31pJI5nXnDwSbGYxZzcKTV SrvGfHe37VnP/f9f8Js6b1W1plPHAYCOPVsIRLWsM8XG7U6SZXrFqOloN72HSPejBB47h1UjOgP w9rtsVcUG8ldBgRCs82DhvBnfP53LKZ4W6mpVtOhlc3j6BMDIHjmE1dxSmaYel4aBvZaGXvI+UK R/fHnTlPuEetZHvsLag== X-Proofpoint-GUID: 9D7_OTYrJyvTAfxsVsBZ5Jpqsfzf6UgK X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-06_03,2026-03-04_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 impostorscore=0 malwarescore=0 adultscore=0 lowpriorityscore=0 priorityscore=1501 phishscore=0 bulkscore=0 spamscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2602130000 definitions=main-2603060104 On 2/28/2026 8:56 PM, Dmitry Baryshkov wrote: > diff --git a/drivers/media/platform/qcom/iris/iris_platform_common.h b/drivers/media/platform/qcom/iris/iris_platform_common.h > index a936ab2aedaf..be3449861993 100644 > --- a/drivers/media/platform/qcom/iris/iris_platform_common.h > +++ b/drivers/media/platform/qcom/iris/iris_platform_common.h > @@ -201,9 +201,32 @@ enum platform_pm_domain_type { > IRIS_APV_HW_POWER_DOMAIN, > }; > > -struct iris_platform_data { > +struct iris_firmware_data { > void (*init_hfi_ops)(struct iris_core *core); > + > u32 (*get_vpu_buffer_size)(struct iris_inst *inst, enum iris_buffer_type buffer_type); Makes sense to split firmware-related data out of iris_platform_data into a dedicated iris_firmware_data, one comment though, get_vpu_buffer_size should be in iris_platform_data since it describes the VPU’s buffer requirements independent of whether the SoC runs gen1/gen2 HFI firmware. Thanks, Dikshita > + > + const struct platform_inst_fw_cap *inst_fw_caps_dec; > + u32 inst_fw_caps_dec_size; > + const struct platform_inst_fw_cap *inst_fw_caps_enc; > + u32 inst_fw_caps_enc_size; > + > + const u32 *dec_ip_int_buf_tbl; > + unsigned int dec_ip_int_buf_tbl_size; > + const u32 *dec_op_int_buf_tbl; > + unsigned int dec_op_int_buf_tbl_size; > + const u32 *enc_ip_int_buf_tbl; > + unsigned int enc_ip_int_buf_tbl_size; > + const u32 *enc_op_int_buf_tbl; > + unsigned int enc_op_int_buf_tbl_size; > +}; > + > +struct iris_platform_data { > + /* > + * XXX: remove firmware_data pointer once we have platforms supporting > + * both firmware kinds. > + */ > + const struct iris_firmware_data *firmware_data; > const struct vpu_ops *vpu_ops; > void (*set_preset_registers)(struct iris_core *core); > const struct icc_info *icc_tbl; > @@ -226,10 +249,6 @@ struct iris_platform_data { > struct iris_fmt *inst_iris_fmts; > u32 inst_iris_fmts_size; > struct platform_inst_caps *inst_caps; > - const struct platform_inst_fw_cap *inst_fw_caps_dec; > - u32 inst_fw_caps_dec_size; > - const struct platform_inst_fw_cap *inst_fw_caps_enc; > - u32 inst_fw_caps_enc_size; > const struct tz_cp_config *tz_cp_config_data; > u32 tz_cp_config_data_size; > u32 core_arch; > @@ -241,14 +260,6 @@ struct iris_platform_data { > u32 max_core_mbpf; > /* max number of macroblocks per second supported */ > u32 max_core_mbps; > - const u32 *dec_ip_int_buf_tbl; > - unsigned int dec_ip_int_buf_tbl_size; > - const u32 *dec_op_int_buf_tbl; > - unsigned int dec_op_int_buf_tbl_size; > - const u32 *enc_ip_int_buf_tbl; > - unsigned int enc_ip_int_buf_tbl_size; > - const u32 *enc_op_int_buf_tbl; > - unsigned int enc_op_int_buf_tbl_size; > }; > > #endif