From: Krzysztof Kozlowski <krzk@kernel.org>
To: Vikash Garodia <vikash.garodia@oss.qualcomm.com>,
Dikshita Agarwal <dikshita.agarwal@oss.qualcomm.com>,
Abhinav Kumar <abhinav.kumar@linux.dev>,
Bryan O'Donoghue <bod@kernel.org>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Philipp Zabel <p.zabel@pengutronix.de>,
Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>,
Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Cc: linux-arm-msm@vger.kernel.org, linux-media@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
Vishnu Reddy <quic_bvisredd@quicinc.com>
Subject: Re: [PATCH v2 1/8] media: dt-bindings: qcom-kaanapali-iris: Add kaanapali video codec binding
Date: Sat, 18 Oct 2025 17:58:56 +0200 [thread overview]
Message-ID: <c9d8f76a-513f-4a09-bba4-cb8f0df1d2fe@kernel.org> (raw)
In-Reply-To: <20251017-knp_video-v2-1-f568ce1a4be3@oss.qualcomm.com>
On 17/10/2025 16:16, Vikash Garodia wrote:
> + clock-names:
> + items:
> + - const: iface
> + - const: core
> + - const: vcodec0_core
> + - const: iface1
> + - const: core_freerun
> + - const: vcodec0_core_freerun
> + - const: vcodec_bse
> + - const: vcodec_vpp0
> + - const: vcodec_vpp1
> + - const: vcodec_apv
> +
> + dma-coherent: true
> +
> + firmware-name:
> + maxItems: 1
> +
> + interconnects:
> + maxItems: 2
> +
> + interconnect-names:
> + items:
> + - const: cpu-cfg
> + - const: video-mem
> +
> + interrupts:
> + maxItems: 1
> +
> + iommus:
> + minItems: 3
> + maxItems: 8
I don't understand why this is flexible. Make it fixed size and anyway -
list the items.
I already asked this.
> +
> + memory-region:
> + minItems: 1
> + maxItems: 2
Same comment. I already asked this about iommus.
NAK, we should not repeat the same comment.
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-10-18 15:59 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-17 14:16 [PATCH v2 0/8] media: iris: add support for video codecs on Qcom kaanapali platform Vikash Garodia
2025-10-17 14:16 ` [PATCH v2 1/8] media: dt-bindings: qcom-kaanapali-iris: Add kaanapali video codec binding Vikash Garodia
2025-10-18 15:58 ` Krzysztof Kozlowski [this message]
2025-10-21 18:55 ` Vikash Garodia
2025-10-21 19:15 ` Krzysztof Kozlowski
2025-10-21 21:07 ` Vikash Garodia
2025-10-22 6:04 ` Krzysztof Kozlowski
2025-10-22 9:37 ` Dmitry Baryshkov
2025-10-22 14:51 ` Bryan O'Donoghue
2025-10-22 15:36 ` Konrad Dybcio
2025-10-22 16:28 ` Krzysztof Kozlowski
2025-11-06 14:50 ` Vikash Garodia
2025-10-17 14:16 ` [PATCH v2 2/8] media: iris: Add support for multiple clock sources Vikash Garodia
2025-10-21 23:06 ` Bryan O'Donoghue
2025-10-17 14:16 ` [PATCH v2 3/8] media: iris: Add support for multiple TZ content protection(CP) configs Vikash Garodia
2025-10-21 23:35 ` Bryan O'Donoghue
2025-10-17 14:16 ` [PATCH v2 4/8] media: iris: Introduce buffer size calculations for vpu4 Vikash Garodia
2025-10-21 23:25 ` Bryan O'Donoghue
2025-10-22 5:44 ` Vikash Garodia
2025-10-17 14:16 ` [PATCH v2 5/8] media: iris: Move vpu register defines to common header file Vikash Garodia
2025-10-21 23:27 ` Bryan O'Donoghue
2025-10-17 14:16 ` [PATCH v2 6/8] media: iris: Move vpu35 specific api to common to use for vpu4 Vikash Garodia
2025-10-21 23:29 ` Bryan O'Donoghue
2025-10-17 14:16 ` [PATCH v2 7/8] media: iris: Introduce vpu ops for vpu4 with necessary hooks Vikash Garodia
2025-10-17 14:16 ` [PATCH v2 8/8] media: iris: Add platform data for kaanapali Vikash Garodia
2025-10-21 23:39 ` Bryan O'Donoghue
2025-10-22 5:46 ` Vikash Garodia
2025-10-22 15:20 ` Bryan O'Donoghue
2025-10-17 14:36 ` [PATCH v2 0/8] media: iris: add support for video codecs on Qcom kaanapali platform Nicolas Dufresne
2025-10-22 6:07 ` Vikash Garodia
2025-11-10 7:45 ` Vikash Garodia
2025-10-22 17:26 ` Konrad Dybcio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c9d8f76a-513f-4a09-bba4-cb8f0df1d2fe@kernel.org \
--to=krzk@kernel.org \
--cc=abhinav.kumar@linux.dev \
--cc=bod@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dikshita.agarwal@oss.qualcomm.com \
--cc=dmitry.baryshkov@oss.qualcomm.com \
--cc=konrad.dybcio@oss.qualcomm.com \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=quic_bvisredd@quicinc.com \
--cc=robh@kernel.org \
--cc=vikash.garodia@oss.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox