[PATCH] drm/msm: add missing include to msm_drv.c

[PATCH] drm/msm: add missing include to msm_drv.c

[Dmitry Baryshkov]

Add explicit include of drm_bridge.h to the msm_drm.c to fix the
following warning:

drivers/gpu/drm/msm/msm_drv.c:236:17: error: implicit declaration of function 'drm_bridge_remove'; did you mean 'drm_bridge_detach'? [-Werror=implicit-function-declaration]

Fixes: d28ea556267c ("drm/msm: properly add and remove internal bridges")
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
---
 drivers/gpu/drm/msm/msm_drv.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/gpu/drm/msm/msm_drv.c b/drivers/gpu/drm/msm/msm_drv.c
index 4f3dce334553..4a3dda23e3e0 100644
--- a/drivers/gpu/drm/msm/msm_drv.c
+++ b/drivers/gpu/drm/msm/msm_drv.c
@@ -11,6 +11,7 @@
 #include <linux/uaccess.h>
 #include <uapi/linux/sched/types.h>
 
+#include <drm/drm_bridge.h>
 #include <drm/drm_drv.h>
 #include <drm/drm_file.h>
 #include <drm/drm_ioctl.h>
-- 
2.35.1

Re: [PATCH] drm/msm: add missing include to msm_drv.c

[Abhinav Kumar]

Change seems fine, with a couple of minor things below.

Reviewed-by: Abhinav Kumar <quic_abhinavk@quicinc.com>

On 4/30/2022 3:48 AM, Dmitry Baryshkov wrote:
> Add explicit include of drm_bridge.h to the msm_drm.c to fix the

this should be msm_drv.c

> following warning:
> 
> drivers/gpu/drm/msm/msm_drv.c:236:17: error: implicit declaration of function 'drm_bridge_remove'; did you mean 'drm_bridge_detach'? [-Werror=implicit-function-declaration]
> 
> Fixes: d28ea556267c ("drm/msm: properly add and remove internal bridges")

How did the this commit compile without this?

> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> ---
>   drivers/gpu/drm/msm/msm_drv.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/gpu/drm/msm/msm_drv.c b/drivers/gpu/drm/msm/msm_drv.c
> index 4f3dce334553..4a3dda23e3e0 100644
> --- a/drivers/gpu/drm/msm/msm_drv.c
> +++ b/drivers/gpu/drm/msm/msm_drv.c
> @@ -11,6 +11,7 @@
>   #include <linux/uaccess.h>
>   #include <uapi/linux/sched/types.h>
>   
> +#include <drm/drm_bridge.h>
>   #include <drm/drm_drv.h>
>   #include <drm/drm_file.h>
>   #include <drm/drm_ioctl.h>

Re: [PATCH] drm/msm: add missing include to msm_drv.c

[Dmitry Baryshkov]

On 30/04/2022 18:00, Abhinav Kumar wrote:
> Change seems fine, with a couple of minor things below.
> 
> Reviewed-by: Abhinav Kumar <quic_abhinavk@quicinc.com>
> 
> On 4/30/2022 3:48 AM, Dmitry Baryshkov wrote:
>> Add explicit include of drm_bridge.h to the msm_drm.c to fix the
> 
> this should be msm_drv.c

Ack.

> 
>> following warning:
>>
>> drivers/gpu/drm/msm/msm_drv.c:236:17: error: implicit declaration of 
>> function 'drm_bridge_remove'; did you mean 'drm_bridge_detach'? 
>> [-Werror=implicit-function-declaration]
>>
>> Fixes: d28ea556267c ("drm/msm: properly add and remove internal bridges")
> 
> How did the this commit compile without this?

I think this manifests only in some situations depending on the drivers 
and features selected. The config generated by the robot is the PA/RISC 
randconfig. See [1].
For example the whole tree compile w/o any issues here. Otherwise I 
would have noticed it.

[1] 
https://download.01.org/0day-ci/archive/20220430/202204301804.hJxOQfse-lkp@intel.com/config


> 
>> Reported-by: kernel test robot <lkp@intel.com>
>> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
>> ---
>>   drivers/gpu/drm/msm/msm_drv.c | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/gpu/drm/msm/msm_drv.c 
>> b/drivers/gpu/drm/msm/msm_drv.c
>> index 4f3dce334553..4a3dda23e3e0 100644
>> --- a/drivers/gpu/drm/msm/msm_drv.c
>> +++ b/drivers/gpu/drm/msm/msm_drv.c
>> @@ -11,6 +11,7 @@
>>   #include <linux/uaccess.h>
>>   #include <uapi/linux/sched/types.h>
>> +#include <drm/drm_bridge.h>
>>   #include <drm/drm_drv.h>
>>   #include <drm/drm_file.h>
>>   #include <drm/drm_ioctl.h>


-- 
With best wishes
Dmitry