From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
To: Richard Acayan <mailingradian@gmail.com>,
Lee Jones <lee@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
Amit Kucheria <amitk@kernel.org>,
Thara Gopinath <thara.gopinath@gmail.com>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Daniel Lezcano <daniel.lezcano@linaro.org>,
Zhang Rui <rui.zhang@intel.com>,
Lukasz Luba <lukasz.luba@arm.com>,
Stephen Boyd <sboyd@kernel.org>,
Dmitry Baryshkov <lumag@kernel.org>,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-pm@vger.kernel.org
Subject: Re: [PATCH 2/3] thermal: qcom-spmi-adc-tm5: Correct the voltage-code scaling for HC
Date: Tue, 10 Feb 2026 10:58:31 +0100 [thread overview]
Message-ID: <cb5c4a0d-9f4e-4338-9c49-8f13c2a5eccc@oss.qualcomm.com> (raw)
In-Reply-To: <20260210021819.12673-3-mailingradian@gmail.com>
On 2/10/26 3:18 AM, Richard Acayan wrote:
> When support was added for the HC variant, the full_scale_code_volt
> value was copied from the tm5 variant. From the downstream kernel, the
> scaling value is 0x70e4 on PMI632 (tm5 variant), but it is 0x4000 on
> PM660 and PM8998 (HC variant). Correct the ADC code to voltage
> scaling factor for the HC variant.
>
> Fixes: f6c83676c6097 ("thermal/drivers/qcom/spmi-adc-tm5: Add support for HC variant")
> Signed-off-by: Richard Acayan <mailingradian@gmail.com>
> ---
nice catch!
Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Konrad
next prev parent reply other threads:[~2026-02-10 9:58 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-10 2:18 [PATCH 0/3] Thermal monitor on PM660 Richard Acayan
2026-02-10 2:18 ` [PATCH 1/3] dt-bindings: mfd: qcom,spmi-pmic: Allow PMIC4 thermal monitor on pm660 Richard Acayan
2026-02-10 9:56 ` Konrad Dybcio
2026-02-11 6:44 ` Krzysztof Kozlowski
2026-02-10 2:18 ` [PATCH 2/3] thermal: qcom-spmi-adc-tm5: Correct the voltage-code scaling for HC Richard Acayan
2026-02-10 9:58 ` Konrad Dybcio [this message]
2026-02-11 2:09 ` Dmitry Baryshkov
2026-02-10 2:18 ` [PATCH 3/3] arm64: dts: qcom: pm660: add thermal monitor Richard Acayan
2026-02-10 9:59 ` Konrad Dybcio
2026-02-11 0:29 ` Richard Acayan
2026-02-12 12:15 ` Konrad Dybcio
2026-02-12 18:27 ` Richard Acayan
2026-02-16 11:58 ` Konrad Dybcio
2026-03-03 2:25 ` Richard Acayan
2026-04-15 9:15 ` Konrad Dybcio
2026-04-15 21:05 ` Richard Acayan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cb5c4a0d-9f4e-4338-9c49-8f13c2a5eccc@oss.qualcomm.com \
--to=konrad.dybcio@oss.qualcomm.com \
--cc=amitk@kernel.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=daniel.lezcano@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=lee@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=lukasz.luba@arm.com \
--cc=lumag@kernel.org \
--cc=mailingradian@gmail.com \
--cc=rafael@kernel.org \
--cc=robh@kernel.org \
--cc=rui.zhang@intel.com \
--cc=sboyd@kernel.org \
--cc=thara.gopinath@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox