From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6ED27C433E0 for ; Fri, 5 Mar 2021 22:19:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3DD216509E for ; Fri, 5 Mar 2021 22:19:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229805AbhCEWSw (ORCPT ); Fri, 5 Mar 2021 17:18:52 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50590 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229775AbhCEWSa (ORCPT ); Fri, 5 Mar 2021 17:18:30 -0500 Received: from mail-qk1-x730.google.com (mail-qk1-x730.google.com [IPv6:2607:f8b0:4864:20::730]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E4072C06175F for ; Fri, 5 Mar 2021 14:18:29 -0800 (PST) Received: by mail-qk1-x730.google.com with SMTP id z190so3590740qka.9 for ; Fri, 05 Mar 2021 14:18:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marek-ca.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=kEPdvK71SYnnYxU/iYMYQe/u4D1Hboa4Ycom7Yjf1Uw=; b=LAiu13ud2ieteI1GC7oTRufOmHJCXPRSrLKl5fh0T8ZtOH0SD/XlcVSIeqtPxBrL0v iorOjbfWYdI1rWZzDfENDWZx8rWebaQIaZN0iTWtJd+9UisdnfWvF0ZbBMn7/8T5RkXE /BvplMJpUvWr0rMw7G6eU9PvsjcrG7DHhnA8e9G2HaD31Up6Hhrnod7o+pyJem9nXIsv K1CQefEQsOIioZWB7+IYnXZLZkLGu0yxY44HFIDj+BNXPnXLC0BZQT4bOoPA/QB135zk p3SNWX8ZsmJeiCQG6SQZfV52KZp/A/Wi8b9PP/MEeArtw/cAjHY26STc9U0jeXtca+xb H2fQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=kEPdvK71SYnnYxU/iYMYQe/u4D1Hboa4Ycom7Yjf1Uw=; b=FE6tW3qQ9tq/w4hnTkpoOyH6cRC4vkgqUJ58vgPT7+03/+4D8DZhMG911qBWvGNmeV HW+zSfBtZRphejToXZ58SHPFhwKNosyWicXnordjAbPWpopvTik8WPaK8jomTOzypEIG TFuTAB+s83PV9rBr3uZed0SV8HtMcS32u8z+Lxy2ujZXhwxJWJ62H3iPsMnW9PGAX13D GC1WZ56bHcTNEhUY7OE1oUHoOXmy4UE7w8qNJm4GPy9hud19G+UW/M6kt9q7F5pRRHbp KpqgmgHt2+5MjZhEdacmU7GXR4tPRcMCEcVnMyAzc6rvGK9RRjjN52Z1N+oq5ksgT8F6 Bz/g== X-Gm-Message-State: AOAM532pqi4ES/wBd7sEJySCB+1FQwz56KcThbzNmqjiNzhR2gsVecfW Je5QQRglTPVjEVm5wOu7czP8Tw== X-Google-Smtp-Source: ABdhPJzQrZBfsrI9YYiNPI9gMDvzV87Lgi/44erfU6o3ciulWwl/Z0QtFrZefcU5AlH8znMSAZt34w== X-Received: by 2002:ae9:ef89:: with SMTP id d131mr11080051qkg.214.1614982709146; Fri, 05 Mar 2021 14:18:29 -0800 (PST) Received: from [192.168.0.189] (modemcable068.184-131-66.mc.videotron.ca. [66.131.184.68]) by smtp.gmail.com with ESMTPSA id z2sm2898711qkg.22.2021.03.05.14.18.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 05 Mar 2021 14:18:28 -0800 (PST) Subject: Re: [PATCH] drm/msm/dsi: support CPHY mode for 7nm pll/phy To: Rob Herring Cc: freedreno@lists.freedesktop.org, Rob Clark , Sean Paul , David Airlie , Daniel Vetter , Douglas Anderson , Kalyan Thota , Jordan Crouse , "Kristian H. Kristensen" , Sam Ravnborg , Rikard Falkeborn , Emil Velikov , Viresh Kumar , Rajendra Nayak , Konrad Dybcio , Dmitry Baryshkov , Dave Airlie , "open list:DRM DRIVER FOR MSM ADRENO GPU" , "open list:DRM DRIVER FOR MSM ADRENO GPU" , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , open list References: <20210215162805.21481-1-jonathan@marek.ca> <20210305214802.GA701567@robh.at.kernel.org> From: Jonathan Marek Message-ID: Date: Fri, 5 Mar 2021 17:17:10 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.2 MIME-Version: 1.0 In-Reply-To: <20210305214802.GA701567@robh.at.kernel.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On 3/5/21 4:48 PM, Rob Herring wrote: > On Mon, Feb 15, 2021 at 11:27:44AM -0500, Jonathan Marek wrote: >> Add the required changes to support 7nm pll/phy in CPHY mode. >> >> This adds a "qcom,dsi-phy-cphy-mode" property for the PHY node to enable >> the CPHY mode. >> >> Signed-off-by: Jonathan Marek >> --- >> .../devicetree/bindings/display/msm/dsi.txt | 1 + >> drivers/gpu/drm/msm/dsi/dsi.c | 12 +-- >> drivers/gpu/drm/msm/dsi/dsi.h | 6 +- >> drivers/gpu/drm/msm/dsi/dsi.xml.h | 2 + >> drivers/gpu/drm/msm/dsi/dsi_host.c | 34 +++++-- >> drivers/gpu/drm/msm/dsi/phy/dsi_phy.c | 49 +++++++++- >> drivers/gpu/drm/msm/dsi/phy/dsi_phy.h | 3 + >> drivers/gpu/drm/msm/dsi/phy/dsi_phy_7nm.c | 89 ++++++++++++++----- >> drivers/gpu/drm/msm/dsi/pll/dsi_pll.c | 4 +- >> drivers/gpu/drm/msm/dsi/pll/dsi_pll.h | 5 +- >> drivers/gpu/drm/msm/dsi/pll/dsi_pll_7nm.c | 71 +++++++++------ >> 11 files changed, 210 insertions(+), 66 deletions(-) >> >> diff --git a/Documentation/devicetree/bindings/display/msm/dsi.txt b/Documentation/devicetree/bindings/display/msm/dsi.txt >> index b9a64d3ff184..7ffc86a9816b 100644 >> --- a/Documentation/devicetree/bindings/display/msm/dsi.txt >> +++ b/Documentation/devicetree/bindings/display/msm/dsi.txt >> @@ -124,6 +124,7 @@ Required properties: >> Optional properties: >> - qcom,dsi-phy-regulator-ldo-mode: Boolean value indicating if the LDO mode PHY >> regulator is wanted. >> +- qcom,dsi-phy-cphy-mode: Boolean value indicating if CPHY mode is wanted. > > This is board or SoC dependent? The latter should be implied by an SoC > specific compatible. > It is board specific, 7nm dsi phy can operate in either D-PHY or C-PHY mode.