From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f49.google.com (mail-wm1-f49.google.com [209.85.128.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 97EF218634 for ; Tue, 19 Dec 2023 12:06:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="iWaSXOj8" Received: by mail-wm1-f49.google.com with SMTP id 5b1f17b1804b1-40d05ebe642so15106595e9.0 for ; Tue, 19 Dec 2023 04:06:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1702987610; x=1703592410; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=QX0/am4IjBACVtJR4SW9C9khWxbgbpT1N87hAG7O6Og=; b=iWaSXOj8ZxeKTjuWY9iYRCPBfwGDILkaMEHeG8ba6e2MgV6Mh7I3Ed0dNcynCCU4h5 2inOync0si6oLnwjlBeCxv7eYMmUOe9VZRpz7vxkWilYsu3uNv6/OqVLKNemA8p6kSw0 3ocFVkq1FFuv7JUhFa4V4Jm7GFlaV3mT8VQlspLnEWIymWgcyd/Lf7zQn/A/9trtGV1W e4zsTuw1AI+ft8qod85ZWmGa6gHOlsU77LHdUvyoaaCC5KjAJBI4nZ4G5FYIKo+x7WHb SCF/lzVn3TqKJ85s3H5Kwc3d9xrnNDl9qSq2LlLeQk7WyapIM+ly3dcy8kEqZ3D0VhKE bnKA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702987610; x=1703592410; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=QX0/am4IjBACVtJR4SW9C9khWxbgbpT1N87hAG7O6Og=; b=AdDjPCzlDeVODtPmgBZ2Cie9QiChfEcuUyx5F1cYNhgiRR6/XyR/zbxVdUmwpp+Skn iSCRzA352yqw3vDcuoSg+YYnbXa9j+LDLcTQ2EM7TpDq4pDtwlOYiQQYra28QbWTH3mC LypSHDeeqoQPBvQswpWx491FZPc609u5l1xeLJZHEQXOKyjZ7lGGoN6rPv+2W/7do8pW UdkxzlvKjxu4Nxth4QP2MNCXVcsW4xemfi1SIARZShMy/3I4NSAK7uilPuW0QmzJc7dY xxjDtYwgiwUcgkCi49fH2BuSL/zWemNevlsjt1AYdlfD7ebJLOqdisR3XAJP4umAu8li 96EQ== X-Gm-Message-State: AOJu0Yxnwwu/O8TjWC1Kfliuy743UzS4CQXgVeWvDxtf8/kqMbS5YkCi Nguulfqw1jTRrWY9GlNTxCeG7vWwo7jG2A== X-Google-Smtp-Source: AGHT+IGSAIihGvqaHjcpOebdWipkh9SAM5JtqPaEB0yEvTNaj3ZFMVRnPkWiy0/0hyFf/q9cZmnaIw== X-Received: by 2002:a05:600c:5119:b0:40c:6e48:a5f8 with SMTP id o25-20020a05600c511900b0040c6e48a5f8mr480826wms.17.1702987609862; Tue, 19 Dec 2023 04:06:49 -0800 (PST) Received: from [192.168.100.86] ([37.228.218.3]) by smtp.gmail.com with ESMTPSA id c6-20020a5d4cc6000000b0033662c2820bsm7241359wrt.117.2023.12.19.04.06.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 19 Dec 2023 04:06:49 -0800 (PST) Message-ID: Date: Tue, 19 Dec 2023 12:06:48 +0000 Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 20/34] media: iris: add video hardware internal buffer count and size calculation Content-Language: en-US To: Dikshita Agarwal , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, stanimir.k.varbanov@gmail.com, quic_vgarodia@quicinc.com, agross@kernel.org, andersson@kernel.org, konrad.dybcio@linaro.org, mchehab@kernel.org, bryan.odonoghue@linaro.org Cc: linux-arm-msm@vger.kernel.org, quic_abhinavk@quicinc.com References: <1702899149-21321-1-git-send-email-quic_dikshita@quicinc.com> <1702899149-21321-21-git-send-email-quic_dikshita@quicinc.com> From: Bryan O'Donoghue In-Reply-To: <1702899149-21321-21-git-send-email-quic_dikshita@quicinc.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 18/12/2023 11:32, Dikshita Agarwal wrote: > drivers/media/platform/qcom/vcodec/iris/Makefile | 1 + > .../media/platform/qcom/vcodec/iris/iris_buffer.c | 48 ++ > .../media/platform/qcom/vcodec/iris/iris_common.h | 1 + > .../media/platform/qcom/vcodec/iris/iris_core.h | 2 + > .../media/platform/qcom/vcodec/iris/iris_helpers.c | 13 + > .../media/platform/qcom/vcodec/iris/iris_helpers.h | 4 + > .../platform/qcom/vcodec/iris/iris_instance.h | 2 + > .../media/platform/qcom/vcodec/iris/iris_vdec.c | 1 + > .../media/platform/qcom/vcodec/iris/vpu_common.h | 8 + > .../media/platform/qcom/vcodec/iris/vpu_iris3.c | 6 + > .../platform/qcom/vcodec/iris/vpu_iris3_buffer.c | 201 +++++ > .../platform/qcom/vcodec/iris/vpu_iris3_buffer.h | 845 +++++++++++++++++++++ So, unless the code you are adding effects existing upstream venus, I think it would be a bit easier to review if you squashed down changes that pertain to Iris only. For example this patch seems to relate to Iris only, so why is it a progressive change within your series. Similar comment for "add vb2 streaming and buffer ops" and other "add feature x" patches in this series. If the change is contained to your own codebase, then progressive changes are more noise than content. Please try to squash down changes - to reduce the number of patches and the total LOC being proposed here. --- bod