From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 72265C77B6E for ; Sun, 9 Apr 2023 17:10:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229519AbjDIRKG (ORCPT ); Sun, 9 Apr 2023 13:10:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40630 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229450AbjDIRKF (ORCPT ); Sun, 9 Apr 2023 13:10:05 -0400 Received: from mail-lj1-x229.google.com (mail-lj1-x229.google.com [IPv6:2a00:1450:4864:20::229]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2F8DE30DB for ; Sun, 9 Apr 2023 10:10:04 -0700 (PDT) Received: by mail-lj1-x229.google.com with SMTP id by8so3043465ljb.13 for ; Sun, 09 Apr 2023 10:10:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1681060202; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=5uCMXg3qktyRsiu4kaOaI9ivh//X7GtEehAzDrbc2ME=; b=TzTEX6yDh1XKr7Lf6+zCMXYxsCPludeRQxOSZIvW7IcRjb75zyNKUmXp/uNv+HRS13 YaxahZU6eQKmbNgo6kJ9bFWfrvTIkDRJA0EPArnsb2D5YE0mNTyfJoQ2aBYCt6vJZW6K FJSL/Sz0DRYzXQ8T1I2uFZjdOivJulBQTyVcynYBTVtjR3YmpYWUEqm+S6UP1v3lnGac 2bUuBkOiBq8+uEHvdMsHGdqw7WDztqGufjwog3QrvtC2Y9YD+ar7dxfHDvKALRgT2OsI DjRiaBLinsAKY66cFU04BjAWuCQ5AIAfdvQd/nFh/JcQP70nISV0r/gW7rklPKAfg6zL mxTQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1681060202; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=5uCMXg3qktyRsiu4kaOaI9ivh//X7GtEehAzDrbc2ME=; b=LwZlKlahZA2llP9nPynHhRd7PyDkxx2aCp3/2MWWKt/9NEYzo8Q8OtY6BPh9bcoUeY yjEnRzuvSCAiB3f4vCNCrJtPbD5E9GtTJN+NuLoM4sXiLI7Zq1olzTttbhWhGjKcMdm7 mO46k0el196JpJs1dSNXikvA23MOFNEtSANlG3lMoKyIr5MQA2yaWtWI17v2EXnB7j04 RXBTbrY5xUBdaPWMQmrcPpqRR7ytXfSN5/J2WKVHGdgSlLsM2OXKvzKLUHuJVQQBGXuz vTsRiM8N5tPEbblKm7E+glRklpU74dBfQW9IGf8OosbBvYP/xtlm9LZismvRCSXXZJuK HFpw== X-Gm-Message-State: AAQBX9daLkOeeuoSYaj0W3DpL/DjogROfpjT4I6WWrTsCwSJjBpYOJ2C kvw6z/sKctplLqINS3syqBfmeg== X-Google-Smtp-Source: AKy350bhaQbNkHbZKI6ZhxOOPajs7ZcQwLq5npTcqkh7MGlNK5WWLXvyyDDc1hKZq8WdvocVH2qQ0g== X-Received: by 2002:a2e:3812:0:b0:2a4:fe3d:d4b2 with SMTP id f18-20020a2e3812000000b002a4fe3dd4b2mr2179483lja.17.1681060202404; Sun, 09 Apr 2023 10:10:02 -0700 (PDT) Received: from ?IPV6:2001:14ba:a085:4d00::8a5? (dzccz6yyyyyyyyyyybcwt-3.rev.dnainternet.fi. [2001:14ba:a085:4d00::8a5]) by smtp.gmail.com with ESMTPSA id z14-20020a2e9b8e000000b00298a81f5d70sm1849710lji.136.2023.04.09.10.10.01 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 09 Apr 2023 10:10:01 -0700 (PDT) Message-ID: Date: Sun, 9 Apr 2023 20:10:01 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [PATCH v2 3/3] venus: fix EOS handling in decoder stop command Content-Language: en-GB To: Dikshita Agarwal , linux-media@vger.kernel.org, stanimir.k.varbanov@gmail.com, quic_vgarodia@quicinc.com, agross@kernel.org, andersson@kernel.org, konrad.dybcio@linaro.org, mchehab@kernel.org Cc: linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, Viswanath Boma References: <1680848758-3947-1-git-send-email-quic_dikshita@quicinc.com> <1680848758-3947-4-git-send-email-quic_dikshita@quicinc.com> From: Dmitry Baryshkov In-Reply-To: <1680848758-3947-4-git-send-email-quic_dikshita@quicinc.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On 07/04/2023 09:25, Dikshita Agarwal wrote: > Use firmware version based check to assign correct > device address for EOS buffer to fix the EOS handling > with different firmware version. > > Signed-off-by: Dikshita Agarwal > Signed-off-by: Vikash Garodia > Signed-off-by: Viswanath Boma Order of sign-offs is incorrect. The SoB of the sender should be the last one. > Tested-by: Nathan Hebert > Reviewed-by: Konrad Dybcio > --- > drivers/media/platform/qcom/venus/vdec.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/media/platform/qcom/venus/vdec.c b/drivers/media/platform/qcom/venus/vdec.c > index f0394b9..c59b34f 100644 > --- a/drivers/media/platform/qcom/venus/vdec.c > +++ b/drivers/media/platform/qcom/venus/vdec.c > @@ -545,7 +545,7 @@ vdec_decoder_cmd(struct file *file, void *fh, struct v4l2_decoder_cmd *cmd) > > fdata.buffer_type = HFI_BUFFER_INPUT; > fdata.flags |= HFI_BUFFERFLAG_EOS; > - if (IS_V6(inst->core)) > + if (IS_V6(inst->core) && is_fw_rev_or_older(inst->core, 1, 0, 87)) > fdata.device_addr = 0; > else > fdata.device_addr = 0xdeadb000; -- With best wishes Dmitry