Re: [DPU PATCH 12/19] drm/msm: dpu_mdss: Replace DPU_EVT with DRM_ERROR

ryadav-sgV2jX0FEOL9JmXXK+q4OQ
2018-06-26T06:47:27Z

On 2018-06-21 02:18, Sean Paul wrote:
> The events are only issued in error cases, so use DRM_ERROR instead.
>
> Signed-off-by: Sean Paul <seanpaul@chromium.org>
Reviewed-by: Rajesh Yadav <ryadav@codeaurora.org>
> ---
> drivers/gpu/drm/msm/disp/dpu1/dpu_mdss.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_mdss.c
> b/drivers/gpu/drm/msm/disp/dpu1/dpu_mdss.c
> index 04accdf483c0..5c69c2cc5d10 100644
> --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_mdss.c
> +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_mdss.c
> @@ -33,13 +33,14 @@ static irqreturn_t dpu_mdss_irq(int irq, void *arg)
> mapping = irq_find_mapping(dpu_mdss->irq_controller.domain,
> hwirq);
> if (mapping == 0) {
> - DPU_EVT32(hwirq, DPU_EVTLOG_ERROR);
> + DRM_ERROR("couldn't find irq mapping for %lu\n", hwirq);
> return IRQ_NONE;
> }
>
> rc = generic_handle_irq(mapping);
> if (rc < 0) {
> - DPU_EVT32(hwirq, mapping, rc, DPU_EVTLOG_ERROR);
> + DRM_ERROR("handle irq fail: irq=%lu mapping=%u rc=%d\n",
> + hwirq, mapping, rc);
> return IRQ_NONE;
> }