From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D6AA2C7EE24 for ; Mon, 5 Jun 2023 10:37:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229873AbjFEKh2 (ORCPT ); Mon, 5 Jun 2023 06:37:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54306 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229511AbjFEKh1 (ORCPT ); Mon, 5 Jun 2023 06:37:27 -0400 Received: from mail-ej1-x62d.google.com (mail-ej1-x62d.google.com [IPv6:2a00:1450:4864:20::62d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D3A79EA for ; Mon, 5 Jun 2023 03:37:25 -0700 (PDT) Received: by mail-ej1-x62d.google.com with SMTP id a640c23a62f3a-977c72b116fso285273566b.3 for ; Mon, 05 Jun 2023 03:37:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1685961444; x=1688553444; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=aOcvx95y08Gz26+xoTBjezMM0R9qofVzp0SopEjZHOQ=; b=rt0Rcc/eCQBeaPHqu7XDXzAGCyuRJOzkJQOyy1aX6nkGg+82+j5cbs4bVtgXqmWwII 3Mh3y6GijeEiUvlu2xdPSaxfgGshRlGJRxrAzKA1KgHUGk9lc12YXCD5D4xZL7tKAs4u QmTxa9VKBOb8VbSZRT9i9Ci+sCZgCom+x7SYHO9kSgzq5ZJoHBzelKG2gmlIUtggDaz8 m5hTOkfhdxICvVpYqFa24mYzCHL3Sb+OkTWvfaTuRQ5fqJZvwZUC5dR3ku0d2X5S1PZu hgKVPq/sgaJSnlTj4nFsGutvSIKoqBKb+WVR/f+nn4znyoCqsKw9Ra91e3kG4N/ALFdH YCQA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685961444; x=1688553444; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=aOcvx95y08Gz26+xoTBjezMM0R9qofVzp0SopEjZHOQ=; b=ljoXhUiF2SRdS7uovoR/2eZRPH/htV+FUNOHanazpqfnPjz/Ys5+lrAkOdJ9rWk/MY O77mhthY/FfoJqk70T09D0i0VSVYlU22Pgm0yeXzcAxlrtgpnZrcSk2DKVxwfuUTZt2u BLLnMzDoX24ULV6isTyVH5kjw3jYsTEd5eGnAFj3vkaReMc1Wsk1WsmRzuAzQWuUBc9Z 8/hO4eGYSfS6hrhnWhIHEIAO2wO4gP/DmCKiTkge+LXFfadzONuFhq3FEW9qqOthXE9a aFltkLq9P+v8kJRYes3Afm6FMKlDCYX89xN2RHqIvNaoRZqgx3qrM8KMQ4RvZE1Z2XYE ZgTQ== X-Gm-Message-State: AC+VfDwADdYHqeKeod1ItVip4JRiBnWJtigtl08ktvt9dyCEhb2inVPN 4xBv79aaUiD99adJkeWtXAO7Dg== X-Google-Smtp-Source: ACHHUZ48K2Razvdp0nA1z9juD0kw8ynNAAg6/azRFolmB6OaGaQUC8gJo44/8kdX7ZDfR6mnkTGLzQ== X-Received: by 2002:a17:907:36c3:b0:960:ddba:e5c6 with SMTP id bj3-20020a17090736c300b00960ddbae5c6mr5332528ejc.22.1685961444353; Mon, 05 Jun 2023 03:37:24 -0700 (PDT) Received: from [192.168.1.20] ([178.197.219.26]) by smtp.gmail.com with ESMTPSA id kq6-20020a170906abc600b0096599bf7029sm4160816ejb.145.2023.06.05.03.37.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 05 Jun 2023 03:37:23 -0700 (PDT) Message-ID: Date: Mon, 5 Jun 2023 12:37:21 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.2 Subject: Re: [PATCH] arm64: dts: qcom: Split sdm845-db845c to add headless support Content-Language: en-US To: Amit Pundir , Bjorn Andersson , Konrad Dybcio , Dmitry Baryshkov , Bryan O'Donoghue , Caleb Connolly Cc: Andy Gross , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-arm-msm , lkml References: <20230605094710.2037879-1-amit.pundir@linaro.org> From: Krzysztof Kozlowski In-Reply-To: <20230605094710.2037879-1-amit.pundir@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On 05/06/2023 11:47, Amit Pundir wrote: > This is a follow-up of the upstream discussion, > https://lore.kernel.org/linux-kernel/20230124182857.1524912-1-amit.pundir@linaro.org/T/#u, > around adding a reserved memory region in sdm845-db845c > for the framebuffer memory (the splash region set up by > the bootloader) but the general opinion was to avoid > adding that reserved memory for the headless DB845c > usecase. > > So this patch splits the sdm845-db845c into a common dtsi, > a new sdm845-db845-headless DT, which disables the mdss > display subsystem, and a new sdm845-db845c DT with an > additional reserved-memory region for the framebuffer. > > The default sdm845-db845c.dtb remains pretty much the same > (with an exception of additional reserved-memory region), > while others can use sdm845-db845c-headless.dtb for their > headless systems. You should describe the hardware in commit msg. What is "headless"? If no HDMI plugged in, then it is a NAK because plug or unplugged HDMI cable is not a property of a DTS. > > Signed-off-by: Amit Pundir > --- > Please pick this after the lvs regulator nodes reordering patch > https://lore.kernel.org/lkml/20230602161246.1855448-1-amit.pundir@linaro.org/T/#u. > I'll rebase and resend this patch otherwise. > > arch/arm64/boot/dts/qcom/Makefile | 1 + > .../boot/dts/qcom/sdm845-db845c-common.dtsi | 1178 +++++++++++++++++ > .../boot/dts/qcom/sdm845-db845c-headless.dts | 9 + > arch/arm64/boot/dts/qcom/sdm845-db845c.dts | 1172 +--------------- A lot of duplication. Are you sure you generated the patches with correct -M/-C/-B arguments to rename or copy? > 4 files changed, 1194 insertions(+), 1166 deletions(-) > create mode 100644 arch/arm64/boot/dts/qcom/sdm845-db845c-common.dtsi > create mode 100644 arch/arm64/boot/dts/qcom/sdm845-db845c-headless.dts > > diff --git a/arch/arm64/boot/dts/qcom/Makefile b/arch/arm64/boot/dts/qcom/Makefile > index 4f9e81253e18..22876ea2e409 100644 > --- a/arch/arm64/boot/dts/qcom/Makefile > +++ b/arch/arm64/boot/dts/qcom/Makefile > @@ -166,6 +166,7 @@ dtb-$(CONFIG_ARCH_QCOM) += sdm845-cheza-r1.dtb > dtb-$(CONFIG_ARCH_QCOM) += sdm845-cheza-r2.dtb > dtb-$(CONFIG_ARCH_QCOM) += sdm845-cheza-r3.dtb > dtb-$(CONFIG_ARCH_QCOM) += sdm845-db845c.dtb > +dtb-$(CONFIG_ARCH_QCOM) += sdm845-db845c-headless.dtb > dtb-$(CONFIG_ARCH_QCOM) += sdm845-db845c-navigation-mezzanine.dtb > dtb-$(CONFIG_ARCH_QCOM) += sdm845-lg-judyln.dtb > dtb-$(CONFIG_ARCH_QCOM) += sdm845-lg-judyp.dtb > diff --git a/arch/arm64/boot/dts/qcom/sdm845-db845c-common.dtsi b/arch/arm64/boot/dts/qcom/sdm845-db845c-common.dtsi > new file mode 100644 > index 000000000000..ecc4a851e29c > --- /dev/null > +++ b/arch/arm64/boot/dts/qcom/sdm845-db845c-common.dtsi > @@ -0,0 +1,1178 @@ > +// SPDX-License-Identifier: GPL-2.0 > +/* > + * Copyright (c) 2019, Linaro Ltd. > + */ > + > +/dts-v1/; > + > +#include > +#include > +#include > +#include > +#include > +#include "sdm845.dtsi" > +#include "sdm845-wcd9340.dtsi" > +#include "pm8998.dtsi" > +#include "pmi8998.dtsi" > + > +/ { > + model = "Thundercomm Dragonboard 845c"; > + compatible = "thundercomm,db845c", "qcom,sdm845"; So it is the same hardware? Why compatible is in common part? I don't understand this change. Best regards, Krzysztof