From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A2955C004D4 for ; Thu, 19 Jan 2023 10:45:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229644AbjASKpH (ORCPT ); Thu, 19 Jan 2023 05:45:07 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39164 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230036AbjASKo6 (ORCPT ); Thu, 19 Jan 2023 05:44:58 -0500 Received: from mail-wr1-x430.google.com (mail-wr1-x430.google.com [IPv6:2a00:1450:4864:20::430]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8DEC644BD5 for ; Thu, 19 Jan 2023 02:44:57 -0800 (PST) Received: by mail-wr1-x430.google.com with SMTP id b5so1468228wrn.0 for ; Thu, 19 Jan 2023 02:44:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=8xlnawePa78ICFwjfjsW90f7mFfyeG73gzlxTncqwyE=; b=h5WDQK2D6C9l5TGsa7heKev8ShkmZ1JPY5cxwLtzRlVKbAZFrP1SjLeg6p7u0CzyX+ ZtI98ciCrs1G6ED70BKYjH1OQt1qjnvI0ruFbP3KmYzNKqmODOiSrIu/SS/4e1B1Ja5+ wLBlagSVGeherUSZGt2wnqhYfLeLmrYs/TVm6v9aNWTVzjgFf30B0wKbNCK3mI7LUGRZ GCEtgyUbTxLKvPThn23sDnde6Q5JUoEnbJ6/W23yxrQFfZzsgw6ntkcyzuKOpOjDNE6/ dFiLBrO7Zg/s0EnMnMllp8N+jnRR8K4X1Al03LXNaNO8cYTZ6SM9xCElMxBS4u8YQxPt IMRQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=8xlnawePa78ICFwjfjsW90f7mFfyeG73gzlxTncqwyE=; b=qJLBbI33kCC3oa5uq4eXfUbkStmE1kyFPvgwedvpxoCvUWr1SzcNPcGYzbXOHzn/+g xu18b92Gx7uM38bEeeqRAz+623cUingmHhKlSAV0WAQVUxaQNFrfVWhqywwxPoVSQfmH jAlWzMoB/sp8KS0QXQfGQGhgpsBvV0RhAcH1OpJqv66Ejs+xFjx9vGakx8NTVzpzCCPp 6GLIupJVJVMdnmJEbhzgBkdMTuzgNcz8ervCzbmG5Dfryb7MoT1B2F9R06MiWUiZBDRT wJlrP3m+l/51VitdVnBSWIOCM44yLFaopaaTZXfUrbibdbg4x1gKg9QGrQgVCf2+kRoN cpKQ== X-Gm-Message-State: AFqh2kq+bWFgkN+izui/+s0vvfNDQsiuwpCwx4t0seX/UINZsUtmR8JF IZvpkWOhtzIqhU3WOb7YzB7Vnw== X-Google-Smtp-Source: AMrXdXvel3nvZiaEnBT/xHs7rT2NUHqn9HRzAttFMuh2VrOKEUaH5uPNdNIHlLOFA6xljS1sQgnihw== X-Received: by 2002:a5d:68c5:0:b0:2bc:846a:8eb2 with SMTP id p5-20020a5d68c5000000b002bc846a8eb2mr8837850wrw.11.1674125096077; Thu, 19 Jan 2023 02:44:56 -0800 (PST) Received: from [192.168.1.109] ([178.197.216.144]) by smtp.gmail.com with ESMTPSA id l4-20020a05600012c400b002bbb2d43f65sm30361062wrx.14.2023.01.19.02.44.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 19 Jan 2023 02:44:55 -0800 (PST) Message-ID: Date: Thu, 19 Jan 2023 11:44:52 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.0 Subject: Re: [PATCH v2 1/9] dt-bindings: arm: Add support for DSB element Content-Language: en-US To: Tao Zhang , Mathieu Poirier , Suzuki K Poulose , Alexander Shishkin , Konrad Dybcio , Mike Leach , Rob Herring , Krzysztof Kozlowski Cc: Jinlong Mao , Leo Yan , Greg Kroah-Hartman , coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Tingwei Zhang , Yuanfang Zhang , Trilok Soni , Hao Zhang , linux-arm-msm@vger.kernel.org, bjorn.andersson@linaro.org, Tao Zhang References: <1674114105-16651-1-git-send-email-quic_taozha@quicinc.com> <1674114105-16651-2-git-send-email-quic_taozha@quicinc.com> From: Krzysztof Kozlowski In-Reply-To: <1674114105-16651-2-git-send-email-quic_taozha@quicinc.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On 19/01/2023 08:41, Tao Zhang wrote: > Add property "qcom,dsb-elem-size" to support DSB(Discrete Single > Bit) element for TPDA. Specifies the DSB element size supported > by each monitor connected to the aggregator on each port. Should > be specified in pairs (port, dsb element size). > > Signed-off-by: Tao Zhang > Signed-off-by: Tao Zhang You are the same person and it is still the same organization (Qualcomm), right? Only one SoB. > --- > .../bindings/arm/qcom,coresight-tpda.yaml | 22 ++++++++++++++++++++++ > 1 file changed, 22 insertions(+) > > diff --git a/Documentation/devicetree/bindings/arm/qcom,coresight-tpda.yaml b/Documentation/devicetree/bindings/arm/qcom,coresight-tpda.yaml > index 2ec9b5b..298db7f 100644 > --- a/Documentation/devicetree/bindings/arm/qcom,coresight-tpda.yaml > +++ b/Documentation/devicetree/bindings/arm/qcom,coresight-tpda.yaml > @@ -58,6 +58,26 @@ properties: > minItems: 1 > maxItems: 2 > > + qcom,dsb-element-size: > + description: | > + Specifies the DSB(Discrete Single Bit) element size supported by > + each monitor connected to the aggregator on each port. Should be > + specified in pairs . s/port/port number/ > + > + Note: The maximum value of the port number depends on how many > + input ports the current TPDA has. DSB element size currently only > + supports 32-bit and 64-bit. > + $ref: /schemas/types.yaml#/definitions/uint32-matrix > + items: Are some reasonable maxItems known? > + items: > + - description: | > + "port" indicates TPDA input port number What is "port"? You quoted it like it was some name of variable or property. Where is then? > + minimum: 0 > + - description: | > + "dsb element size" indicates dsb element size "A" indicates A. This sentence does not make sense. Also missing units. s/dsb/DSB/ > + minimum: 0 > + maximum: 64 > + > clocks: > maxItems: 1 > > @@ -100,6 +120,8 @@ examples: > compatible = "qcom,coresight-tpda", "arm,primecell"; > reg = <0x6004000 0x1000>; > > + qcom,dsb-element-size = <0 32>; > + > clocks = <&aoss_qmp>; > clock-names = "apb_pclk"; > Best regards, Krzysztof