From mboxrd@z Thu Jan 1 00:00:00 1970 From: Archit Taneja Subject: Re: [PATCH 2/3] drm/msm/mdp5: mark runtime_pm functions as __maybe_unused Date: Fri, 4 Aug 2017 16:07:25 +0530 Message-ID: References: <20170803115130.3448850-1-arnd@arndb.de> <20170803115130.3448850-2-arnd@arndb.de> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from smtp.codeaurora.org ([198.145.29.96]:44146 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751291AbdHDKhc (ORCPT ); Fri, 4 Aug 2017 06:37:32 -0400 In-Reply-To: <20170803115130.3448850-2-arnd@arndb.de> Content-Language: en-US Sender: linux-arm-msm-owner@vger.kernel.org List-Id: linux-arm-msm@vger.kernel.org To: Arnd Bergmann , Rob Clark Cc: David Airlie , Daniel Vetter , Neil Armstrong , =?UTF-8?B?VmlsbGUgU3lyasOkbMOk?= , linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org On 08/03/2017 05:20 PM, Arnd Bergmann wrote: > When CONFIG_PM is disabled, we get harmless warnings about unused > functions: > > drivers/gpu/drm/msm/mdp/mdp5/mdp5_kms.c:1025:12: error: 'mdp5_runtime_resume' defined but not used [-Werror=unused-function] > static int mdp5_runtime_resume(struct device *dev) > ^~~~~~~~~~~~~~~~~~~ > drivers/gpu/drm/msm/mdp/mdp5/mdp5_kms.c:1015:12: error: 'mdp5_runtime_suspend' defined but not used [-Werror=unused-function] > static int mdp5_runtime_suspend(struct device *dev) > ^~~~~~~~~~~~~~~~~~~~ > > This marks both functions as __maybe_unused so the compiler > can drop them silently. Thanks for the fix. Since the commit is still in Rob's -next branch, I'll post a new version which fixes this. Archit > > Fixes: d68fe15b1878 ("drm/msm/mdp5: Use runtime PM get/put API instead of toggling clocks") > Signed-off-by: Arnd Bergmann > --- > drivers/gpu/drm/msm/mdp/mdp5/mdp5_kms.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/msm/mdp/mdp5/mdp5_kms.c b/drivers/gpu/drm/msm/mdp/mdp5/mdp5_kms.c > index 9f9d95f7c80f..f7c0698fec40 100644 > --- a/drivers/gpu/drm/msm/mdp/mdp5/mdp5_kms.c > +++ b/drivers/gpu/drm/msm/mdp/mdp5/mdp5_kms.c > @@ -1012,7 +1012,7 @@ static int mdp5_dev_remove(struct platform_device *pdev) > return 0; > } > > -static int mdp5_runtime_suspend(struct device *dev) > +static __maybe_unused int mdp5_runtime_suspend(struct device *dev) > { > struct platform_device *pdev = to_platform_device(dev); > struct mdp5_kms *mdp5_kms = platform_get_drvdata(pdev); > @@ -1022,7 +1022,7 @@ static int mdp5_runtime_suspend(struct device *dev) > return mdp5_disable(mdp5_kms); > } > > -static int mdp5_runtime_resume(struct device *dev) > +static __maybe_unused int mdp5_runtime_resume(struct device *dev) > { > struct platform_device *pdev = to_platform_device(dev); > struct mdp5_kms *mdp5_kms = platform_get_drvdata(pdev); > -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project