From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f52.google.com (mail-wm1-f52.google.com [209.85.128.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 73747248F4D for ; Wed, 23 Jul 2025 08:34:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753259652; cv=none; b=VtfPZF8eqyEjlQ5j4isEtWifBwxBKnE4VoC1tPxU4Wc62QIr75bpgMaeGRg3DTjE4RB9W9trLYpnIO3IGoDEZ70dY36m30uKVqoc7t7/NnXWXVZSYRjZXUTkeO88NnIssU+jOTRuEY1ovb5WYeMdmKU9+BZzRMceUmWJCkaBkqk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753259652; c=relaxed/simple; bh=fqqTU5Q2Wts1JqfPaHt73vG1jMrBA1lvDzSJGM0bLjE=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=kTU+WB7uTvaG7ycALo4jH5bJhplcoTmnJEOmrgwhQZG8su9iYbYcRiUYywrM+yZYzOGaPAaX/454D45HEtOqzDgC0LyrZ4cInUwfEG1kQGSlCZyFLmWFhTw7WvD9JskxAMaG+MMWF+YCNHJi5mTO0TSW/dfz61/E4mI8vj2ozpc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=cjreUs4z; arc=none smtp.client-ip=209.85.128.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="cjreUs4z" Received: by mail-wm1-f52.google.com with SMTP id 5b1f17b1804b1-4560d176f97so68329955e9.0 for ; Wed, 23 Jul 2025 01:34:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1753259649; x=1753864449; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=zKVnFomYy8E8KQwcfNsj6ulD0Xw2fyUDVFD8613P6Yg=; b=cjreUs4z8imaUe4vpRGLubhJENAEX32Kgx6Jv+ZYY19ztwb8fs3dLnNj1aEKU4xS8h GYsvABMAcqp5PXWk12WcXkarwisabnVUPJPh+TAd7Xqfv1iDu0eJyYdObqcNn8a5VmR5 jT/so9LD5REEpZvPVfJVzFpdq1pM0p49HB1y7UQ6Pklo6s219CXyahVGtUi+VeTA2JRO lG0/r+2RCY02SPR1MbkjhVhpuqrVpv3VwXlPZPLMguO80FZzYr4GKtPBhJ6ayDZzfSwO mGtOFZ7Btzz2XS3J6NPspBW+w12JVAseGT7uMgHIh1SRUvoA/+NfBBvo36/YqEAGSkqm lI9w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1753259649; x=1753864449; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=zKVnFomYy8E8KQwcfNsj6ulD0Xw2fyUDVFD8613P6Yg=; b=f1ike6DWasoFsgvWxKCJnWRSxOwz82ZCHbpXkxqLCpXpU5sfyAOckbahlqC9i/2Emc 2ChJgqzbsYrKP9pN1augLC6mZtgED4F3fFV/+QBCqqNJPRMcKM8SHLI2haE2qRYkmjax idAIZef5KAJuJs99vUA1oEsINJV9Z3miu6mSc6y7PNZA61+dZ+zWJ+y72ZzGMVVtZ2GG oOjVfFAtLPGfGYF0744gNoTDrqeYuNMHc6RW7sVNKAD0cWiMdT+/mgU9lE9tV/ASPJ7l 8lKJq94GVr+KwAX+/iMs48AVu9tqlPAVTX5aJ4GPwlfcBOGayV4ijV6+kW8zj0R2BCVv eQRQ== X-Forwarded-Encrypted: i=1; AJvYcCVMeFZiKV0tBZ0Eh365UNwLUv8cgZD7G3gfuKpliJSVyHaRRV+7tcJejeafiPkKldM1riOrRQf4Us7TUHmI@vger.kernel.org X-Gm-Message-State: AOJu0YzdWNSQZhn9vU70cby10+N73AR3oWA6/nQbSD8MrZ4wxgPS1jmf czz5DfVA8W2UshdZugF6y8P65CUwz/qqHiUKL+Hgu0ocax+1QTihp+cW+ejTmXsqvzE= X-Gm-Gg: ASbGncu9YbFU2XK3e3rp9lWrje3kgqJHDGWNqO2YdeqUJR7YDzlYFsh6UUlK/mfaKC4 XUlg09Vok4Is/irif/nLy/rPFNL+VpWSG9DpCz2jND+Yi3Nkay3uKbHJgR1b6OIPKZ5HwPcCjDL WeWIjMjuej9dIH61HKacu+cDF1GHJu7vgrGEgegEHdlg5VeujIMYh+oeX91UVXih/unHArciHt2 rYWJFTl9+TRh9lwBQvfcCKAybpVNhs2MAhhcpwuWl9T9ENsTino6mqhzTw7r1FctDTI2S5lLeTu L3Qo8q51yOBM95n9fnK/fHaE0y5CtJD+Iq7a9unbmWtLrlVvSHGG6u81iZLEa52kpHHOtrajunc wn5eb31LqGvdMlOAzE9QcyhPzV9IW8sORkyQqLiA6rlSvaBUpjKdEetNmGHay9Do= X-Google-Smtp-Source: AGHT+IHh6It645AxDuSmVuSvYrBa/qT8yZ8JYoP6ZpWAS5lzUHw2g8ZbWyzuQU3s670wb4c/O9V4bg== X-Received: by 2002:a05:600c:8717:b0:456:26d1:445d with SMTP id 5b1f17b1804b1-45868d4ce4cmr14590345e9.31.1753259648734; Wed, 23 Jul 2025 01:34:08 -0700 (PDT) Received: from [192.168.0.35] (188-141-3-146.dynamic.upc.ie. [188.141.3.146]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3b61ca4893fsm15791493f8f.52.2025.07.23.01.34.07 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 23 Jul 2025 01:34:08 -0700 (PDT) Message-ID: Date: Wed, 23 Jul 2025 09:34:06 +0100 Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 00/25] Enable H.264/H.265 encoder support and fixes in common code To: Dikshita Agarwal , Vikash Garodia , Abhinav Kumar , Mauro Carvalho Chehab , Hans Verkuil , Stefan Schmidt , Vedang Nagar Cc: linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org References: <20250704-iris-video-encoder-v1-0-b6ce24e273cf@quicinc.com> From: Bryan O'Donoghue Content-Language: en-US In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 23/07/2025 07:40, Dikshita Agarwal wrote: > > > On 7/4/2025 1:23 PM, Dikshita Agarwal wrote: >> Hi All, >> >> This patch series adds support for H.264 and H.265 encoder in iris >> driver and includes a few fixes and cleanup in the common code that were >> identified during encoder bring-up process. >> >> The changes include: >> - Enabling support for H.264 and H.265 encoding. >> - Fixes and improvements in shared componenets used by both encoder and >> decoder paths. >> - Ensuring compatibility and stability with the existing decoder flow. >> >> All patches have been tested with v4l2-compliance, v4l2-ctl and >> Gstreamer on SM8250 and SM8550 for encoder, at the same time ensured >> that the existing decoder functionality remains uneffected. >> > > @bryan/@vikash > do you have any further comments on this series, I have few smatch/cocci > fixes which I plan to push with v2. > If you have any comments, I can address them as well in v2. > > Thanks, > Dikshita Will review this week. I have it stacked on a Hamoa tree and it passes v4l2-compliance but, I haven't put it through an actual test of the encoder yet. Will do ASAP. --- bod