Re: [PATCH 35/40] drm/msm/disp/mdp5/mdp5_kms: Make local functions 'mdp5_{en, dis}able()' static

[abhinavk@codeaurora.org]

On 2020-11-13 05:49, Lee Jones wrote:
> Fixes the following W=1 kernel build warning(s):
> 
>  drivers/gpu/drm/msm/disp/mdp5/mdp5_kms.c:299:5: warning: no previous
> prototype for ‘mdp5_disable’ [-Wmissing-prototypes]
>  drivers/gpu/drm/msm/disp/mdp5/mdp5_kms.c:319:5: warning: no previous
> prototype for ‘mdp5_enable’ [-Wmissing-prototypes]
> 
> Cc: Rob Clark <robdclark@gmail.com>
> Cc: Sean Paul <sean@poorly.run>
> Cc: David Airlie <airlied@linux.ie>
> Cc: Daniel Vetter <daniel@ffwll.ch>
> Cc: Thomas Zimmermann <tzimmermann@suse.de>
> Cc: linux-arm-msm@vger.kernel.org
> Cc: dri-devel@lists.freedesktop.org
> Cc: freedreno@lists.freedesktop.org
> Signed-off-by: Lee Jones <lee.jones@linaro.org>
Reviewed-by: Abhinav Kumar <abhinavk@codeaurora.org>
> ---
>  drivers/gpu/drm/msm/disp/mdp5/mdp5_kms.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/msm/disp/mdp5/mdp5_kms.c
> b/drivers/gpu/drm/msm/disp/mdp5/mdp5_kms.c
> index b3eecf8694771..15aed45022bc8 100644
> --- a/drivers/gpu/drm/msm/disp/mdp5/mdp5_kms.c
> +++ b/drivers/gpu/drm/msm/disp/mdp5/mdp5_kms.c
> @@ -296,7 +296,7 @@ static const struct mdp_kms_funcs kms_funcs = {
>  	.set_irqmask         = mdp5_set_irqmask,
>  };
> 
> -int mdp5_disable(struct mdp5_kms *mdp5_kms)
> +static int mdp5_disable(struct mdp5_kms *mdp5_kms)
>  {
>  	DBG("");
> 
> @@ -316,7 +316,7 @@ int mdp5_disable(struct mdp5_kms *mdp5_kms)
>  	return 0;
>  }
> 
> -int mdp5_enable(struct mdp5_kms *mdp5_kms)
> +static int mdp5_enable(struct mdp5_kms *mdp5_kms)
>  {
>  	DBG("");