From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 28C1CC77B7E for ; Tue, 2 May 2023 10:56:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233749AbjEBK4w (ORCPT ); Tue, 2 May 2023 06:56:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51258 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233744AbjEBK4v (ORCPT ); Tue, 2 May 2023 06:56:51 -0400 Received: from mail-ej1-x632.google.com (mail-ej1-x632.google.com [IPv6:2a00:1450:4864:20::632]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5ED0E5249 for ; Tue, 2 May 2023 03:56:43 -0700 (PDT) Received: by mail-ej1-x632.google.com with SMTP id a640c23a62f3a-95678d891d6so749987166b.1 for ; Tue, 02 May 2023 03:56:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1683025002; x=1685617002; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=9NjcIUjZd/aHaGZ2xuuhHfRWq9d1voqSmHCETTSD5is=; b=Azp5BksA5jtXU083Qc0HaNLyaZp24roDKJ3QreC7NI2J/FlO5PpxkyToIjFXfohf4C VkKLsh6nXUBR2azgLeEa4R3V4VhGaWnqdL1WoEeDPwza9DbsaEU7eXRb+uCE+p40FXzq HphnQrfYBdlsMbExQR9nflRhuMRJ6DYFy2qcuZqKa0Ge2BHisP76aOOzHhyecsgZpPf2 DjLjGZwWuHc3Sb4TeQQhQMQG+FljDruGc1hpo3AIhZ9lqvgWcSqmq+RvSa9+Uj5sdgmA DoKo6wBezunp+ktY9VNveg3g1+tOzNi4HFKJWB0VyzBBfwZNdgGNLrGyD9tcN3XqlEtX KXkg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683025002; x=1685617002; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=9NjcIUjZd/aHaGZ2xuuhHfRWq9d1voqSmHCETTSD5is=; b=CmbqBa30RwwKxJvUux9k2Dm+ABQcaV6BBnIQ04zEgf5vLZlpnlB47M49Nodook62/q yAn5kPVNc3u+jrkKNiibtGfOeMzmjA6wxnsyzhHSwx2EIILGGOs+/lK77hWMR0iRN8yv KxrA+Kb9c5xjNILf6M0Km2H5ueP3nodEeSk9MnjCJgcZLrJ6rP9cHXpixH60q2dwqHwK 2w9FP1OWAbsRQCOXVwbrUPRkCWv1NHAjEjhB1afLelVQAkMACMrdB9xTk/TRJ5zmZFup b8AgRx0whRsAOJ9NRKEdscBCaAVU65xq2wP8QHVPPdi9mJnmVaHzq3v2LfeegAJzPtO1 bCmw== X-Gm-Message-State: AC+VfDxl7o86Bh3WZjlcr+g+uq8GKmDPehV5b1gZL0kcNjCpPcll16Ql oIurAu6e4f+hqGZlbOB+EIbv+Q== X-Google-Smtp-Source: ACHHUZ4gm3w2Of6tRjKjcEwPjEbUqHC2XDsHiFi0uBHHr4lA+NA2LY/j4Jf+cyYU0XFC9TcPkm6sTQ== X-Received: by 2002:a17:907:628a:b0:958:801b:9945 with SMTP id nd10-20020a170907628a00b00958801b9945mr16301349ejc.31.1683025002105; Tue, 02 May 2023 03:56:42 -0700 (PDT) Received: from ?IPV6:2a02:810d:15c0:828:bafd:1283:b136:5f6a? ([2a02:810d:15c0:828:bafd:1283:b136:5f6a]) by smtp.gmail.com with ESMTPSA id e1-20020a17090681c100b0094f67ea6598sm15886267ejx.193.2023.05.02.03.56.40 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 02 May 2023 03:56:41 -0700 (PDT) Message-ID: Date: Tue, 2 May 2023 12:56:40 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.1 Subject: Re: [PATCH v6 05/13] dt-bindings: usb: Add Qualcomm PMIC Type-C Content-Language: en-US To: Bryan O'Donoghue , linux@roeck-us.net, heikki.krogerus@linux.intel.com, gregkh@linuxfoundation.org, andersson@kernel.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, luca.weiss@fairphone.com, linux-usb@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org Cc: caleb.connolly@linaro.org, konrad.dybcio@linaro.org, subbaram@quicinc.com, jackp@quicinc.com, robertom@qti.qualcomm.com, Wesley Cheng References: <20230501121111.1058190-1-bryan.odonoghue@linaro.org> <20230501121111.1058190-6-bryan.odonoghue@linaro.org> From: Krzysztof Kozlowski In-Reply-To: <20230501121111.1058190-6-bryan.odonoghue@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On 01/05/2023 14:11, Bryan O'Donoghue wrote: > Add a description for the Type-C silicon interface inside Qualcomm's > PM8150b hardware block. > > Based on original work by Wesley. > > Signed-off-by: Wesley Cheng > Signed-off-by: Bryan O'Donoghue > --- Thank you for your patch. There is something to discuss/improve. Two nits below > + port@1 { > + reg = <1>; > + pmic_typec_role_switch_out: endpoint { > + remote-endpoint = <&usb_controller_role_switch_in>; > + }; > + }; > + }; > + }; > + }; > + }; > + > + usb_controller { No underscores in node names, just "usb" > + dr_mode = "otg"; > + usb-role-switch; > + port { > + usb_controller_role_switch_in: endpoint { > + remote-endpoint = <&pmic_typec_role_switch_out>; > + }; > + }; > + }; > + > + usb_phy { usb-phy With fixes above: Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof