From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2C7CA3AA1A2 for ; Thu, 19 Mar 2026 20:54:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773953660; cv=none; b=dhBiFUIWj6wCCqBpGQpVQKj724HzHi6X4ufrP4Yw3QVpV7RWFfsJeGtLXyLUfKeRYGl8z3/EgFo563FxtMpeOxhn1/p0J5ShQ3nt7Brytxklc0JElCBXbN9M/1sfjiJfzQWT3qeShawgEMpXYiSRr7LO70LCBp9uNm4hjfO7iZ4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773953660; c=relaxed/simple; bh=OspvSUceR9D7FWErEaMeS4pbjFGXhTs0d3vC6fXFa4g=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=nuCNLyxoXKC+ZFaPVv8ZZYGg+ZjlL1QNWHA78ZhwLoSyRGIScvPxoamdHkz5OzcW1GR2BKpDML8KwXcXVWPukNsfvq9w8ThHwwYBaaFDe33GjqQ9e35PPlCxuHdGJGs0Gz9/BJ437rTW1UfD+DCFkBMA3bWyjdfJZsizcq8qfiw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=i5Da/vfQ; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=JL2MEzcg; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="i5Da/vfQ"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="JL2MEzcg" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1773953658; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=OspvSUceR9D7FWErEaMeS4pbjFGXhTs0d3vC6fXFa4g=; b=i5Da/vfQQUDm2uf3tcOptZL5DQrMwOU6IgvDH0Pauitz+9D5T+97ikCR2+7agzhUNtoyau EkkaDSiPmBCq74PTATbRJ5RACQag8VIgjeCDthLR9G6HJm3A097LBpFAl7XGMa26eyggq5 H0KlMWvFZDeJgXUcqrfHAFpp7i/aLcs= Received: from mail-qt1-f200.google.com (mail-qt1-f200.google.com [209.85.160.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-113-EYOCenSVOFOi7bEa5vR7DA-1; Thu, 19 Mar 2026 16:54:17 -0400 X-MC-Unique: EYOCenSVOFOi7bEa5vR7DA-1 X-Mimecast-MFC-AGG-ID: EYOCenSVOFOi7bEa5vR7DA_1773953656 Received: by mail-qt1-f200.google.com with SMTP id d75a77b69052e-5091327215dso133105151cf.1 for ; Thu, 19 Mar 2026 13:54:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1773953656; x=1774558456; darn=vger.kernel.org; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=OspvSUceR9D7FWErEaMeS4pbjFGXhTs0d3vC6fXFa4g=; b=JL2MEzcgSbicNblhfTU1iXOAgbqxYIHkpSmAswQ7p1tadNZEPo7Aao7dQbRQbf2Ndo qamwj58PsJlLevsNlswwEbbxNSHA0CFrLEmkL3z3sGZQ1qeTDA5pdtGjmnW06Loadzec /pHRRyLXi70FNGLrizMJs34rv1Za+up24KeJciqCYoNbfHJ41C5hh/5Ur5uxwxpW2KmY pJSyzChg2j5Be2PehooHZhj6lAUBIxnniAdVh1aJEV3MSyvWfhOH/xRmudYCdOhnR7Ij B2QRYM8fpTJjriKRV95OzN7jUxCYWkmF7FmH11Kpk5NUhMwtnwA5Z/SV4tLvzTdzfT9M ZV0w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773953656; x=1774558456; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=OspvSUceR9D7FWErEaMeS4pbjFGXhTs0d3vC6fXFa4g=; b=aTrFekaEewv2frIp8EfGbb4x3iMmjKFtdfW9UbSyiHVmTg+z5iyjWbTkHa7PrjWEc5 2Vbe24/NFtmH6pnH56eydMa3G9SfugZKlSq3OX8vmd7aFUF/sfoTlYF8GX7HkPEURvY/ O/V2f9lmHVrVENpAyZOehJwJZd7rZiSI0cz7jX5RCDGjKBEPuFIpXU3nWiqmKY27cQ8J aemESw09uvJuBJktGYGtNflWX57z2YuPsTuqqjhoJ4V8k/aNExr80XyMpR9oBmd4rEBP G8Q8QqfVGzp7IFx5p+btJNXmJQ445Ko44QjwiJIf3YHc6tnwHSUQu7AEofGN4VsUVnwR /n5g== X-Forwarded-Encrypted: i=1; AJvYcCV81B6QXRvymzpOyybgdIVKAgmrxdEJ4r1Z1Sh49vzz4fnK2Zg6nXcfC7XsmdQtgPJ220on7EF01T/Koq+E@vger.kernel.org X-Gm-Message-State: AOJu0YxAlrI+dIVm21pXHu6gTPnSMt6QAHim9IALTBC/6wDSj/YTykWp GDYtk1FYnSn67vHWnBbaMaaPCsJq6k1n9ye/ycF2Cq5+d0zx1xFhrwMVLqNyON5B6rU9CDLr4Z+ CxeWzxYCBp/PbfoMuFDF+zV0NE1KIhoDiaLpUmUSe6ryzaS5NR0lyRtreKIuoQ+4cZow= X-Gm-Gg: ATEYQzzLao1r17XviKZ9de0KiTs7LuEpw0pDEJ+VHOM8OlPk1LaUgtyx0oEL6W5wVkC +ItHrSyXsUFw6u/wJvXqKkw6N3kcYKupXUI/kVldh128tfYLiPq6rQ7phbHxFwJcLz2O9RCj+L9 j1jkklB9IPijEBLKVKE4N0BvExVdLEzE19mYP0hdx0li8fSWnUW7rWrslYio6ZMxEk1VhRzPpdy GLhTies6rHPK9jAsX8JUrITgP9U/0diRBdImOxAPZPWa8QzXaJRQMQbBu567s6aqFSm4dNxHpEi gEZotrl0wThaGAuYNxgS1pPhJ4UtdGTWwFo2rKvyyNUlTO0tGPDEPFpOYtkxxti9sEpg9++KVX5 tpOVvW2rO7tlimLnO9UpczVLmSO/osbQ7F4gOOoUIVSkTrQdkUBagEwpLLYw3x/62mFjU3AB/Dk +/cQGzwOOjstT1Nw== X-Received: by 2002:ac8:7f54:0:b0:509:4e1e:1b9a with SMTP id d75a77b69052e-50b37586c7cmr10125511cf.54.1773953656287; Thu, 19 Mar 2026 13:54:16 -0700 (PDT) X-Received: by 2002:ac8:7f54:0:b0:509:4e1e:1b9a with SMTP id d75a77b69052e-50b37586c7cmr10124851cf.54.1773953655634; Thu, 19 Mar 2026 13:54:15 -0700 (PDT) Received: from thinkpad-p1.localdomain (pool-174-112-193-187.cpe.net.cable.rogers.com. [174.112.193.187]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-50b36e350c3sm6518601cf.19.2026.03.19.13.54.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Mar 2026 13:54:15 -0700 (PDT) Message-ID: Subject: Re: [PATCH net-next v9 0/6] net: stmmac: qcom-ethqos: add support for SCMI power domains From: Radu Rendec To: Bartosz Golaszewski Cc: Bartosz Golaszewski , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Maxime Coquelin , Alexandre Torgue , Vinod Koul , Giuseppe Cavallaro , Chen-Yu Tsai , Jernej Skrabec , Neil Armstrong , Kevin Hilman , Jerome Brunet , Shawn Guo , Fabio Estevam , Jan Petrous , s32@nxp.com, Mohd Ayaan Anwar , Romain Gantois , Geert Uytterhoeven , Magnus Damm , Maxime Ripard , Christophe Roullier , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, Drew Fustini , linux-sunxi@lists.linux.dev, linux-amlogic@lists.infradead.org, linux-mips@vger.kernel.org, imx@lists.linux.dev, linux-renesas-soc@vger.kernel.org, linux-rockchip@lists.infradead.org, sophgo@lists.linux.dev, linux-riscv@lists.infradead.org, Bartosz Golaszewski , Martin Blumenstingl , Krzysztof Kozlowski , Lad Prabhakar , Konrad Dybcio Date: Thu, 19 Mar 2026 16:54:12 -0400 In-Reply-To: References: <20260316-qcom-sa8255p-emac-v9-0-c58934e76ff2@oss.qualcomm.com> <64d282fd94be1546df75d7df5b47eacc0479797a.camel@redhat.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.56.2 (3.56.2-2.fc42) Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 On Tue, 2026-03-17 at 15:12 +0100, Bartosz Golaszewski wrote: > On Mon, Mar 16, 2026 at 7:31=E2=80=AFPM Radu Rendec = wrote: > >=20 > > On Mon, 2026-03-16 at 13:05 +0100, Bartosz Golaszewski wrote: > > > Add support for the firmware-managed variant of the DesignWare MAC on > > > the sa8255p platform. This series contains new DT bindings and driver > > > changes required to support the MAC in the STMMAC driver. > > >=20 > > > It also reorganizes the ethqos code quite a bit to make the introduct= ion > > > of power domains into the driver a bit easier on the eye. > > >=20 > > > The DTS changes will go in separately. > >=20 > > I'm seeing some weird behavior with this version. The probe part looks > > good (but see below), but when I try to bring an interface up, it fails > > with ETIMEDOUT. The relevant part of the stack trace leading to the > > error is this: > >=20 > > dwmac4_dma_reset+0x208/0x220 [stmmac] > > stmmac_reset+0x2c/0x68 [stmmac] > > stmmac_init_dma_engine+0x108/0x400 [stmmac] > > stmmac_hw_setup+0x5c/0x538 [stmmac] > > __stmmac_open+0xc8/0x2a0 [stmmac] > > stmmac_open+0xcc/0x238 [stmmac] > > __dev_open+0x138/0x2a8 > >=20 > > Now dwmac4_dma_reset() is very simple. It sets the soft reset bit in > > the DMA_BUS_MODE register, then waits for the hardware to clear it, and > > that never happens. > >=20 > > Now, getting back to the probe part, there is one extra message > > (compared to my previous successful test on v7), which I see at the > > very end of the probing: > >=20 > > =C2=A0 qcom-ethqos 23040000.ethernet: clk_csr value out of range (0xfff= fff00 > > =C2=A0 exceeds mask 0x00000f00), truncating > >=20 > > This is a sa8775p ride board, so there are two stmmac devices. I only > > see that message for the 2nd one, which is also the one I'm trying to > > enable, and which fails. > >=20 > > I realize this may or may not be related to your changes. But there is > > no way to test on a SCMI-pd board without them. I'm not sure how > > relevant it would be to test on the non-SCMI variant. I'm assuming the > > DMA part should work the same way (regardless of SCMI-pd), so if I can > > reproduce it there, and since I know it works on mainline Linux (that's > > where I tested v7), I could bisect and see which commit in net-next > > breaks it. If you don't have any better idea, let me know and I can > > try. Meanwhile, I'll keep poking at v9. > >=20 >=20 > Does current net-next on its own still work? Or is the second > interface broken even without this series? I don't think there is a way to test net-next on its own (without your series) on a board with SCMI-pd firmware. It would require the qcom-ethqos driver to have direct access to the clocks, but the clocks would not be there. What I could test though is a board with the "other" firmware (without SCMI-pd). And on that board, I do *not* see the problem even with your series applied. In fact, I tested the exact same kernel build I had previously tested on the SCMI-pd board. I'm not sure what to make of that or what else I could try. FWIW, the "clk_csr value out of range" message I mentioned before is still there on the board where everything works, so it's probably a red herring. --=20 Radu