From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 439D8C77B7C for ; Fri, 26 May 2023 10:29:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230177AbjEZK31 (ORCPT ); Fri, 26 May 2023 06:29:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37782 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242942AbjEZK30 (ORCPT ); Fri, 26 May 2023 06:29:26 -0400 Received: from mail-lj1-x231.google.com (mail-lj1-x231.google.com [IPv6:2a00:1450:4864:20::231]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9A1A4119 for ; Fri, 26 May 2023 03:29:24 -0700 (PDT) Received: by mail-lj1-x231.google.com with SMTP id 38308e7fff4ca-2af1822b710so5802801fa.1 for ; Fri, 26 May 2023 03:29:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1685096963; x=1687688963; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=/K6PbDpa1bEXTu9+nLfG+TEYuGga9QGQcY866PUs1S4=; b=gls0zD+CZdmTwtc6DNf+QA/lpg0y7Qg2rRgYwry2zZXeUv5j1wUMD2sDzm5rhRPWXh r/zFGO0yfdRqz4SmPN5LkZp6IZ9+Egm4C62Yo7iPdgEmYMetTfTs5Ss94LRHToV1jWSI hSD3Slnyw1XdcWnCXFmOgPc40IFKdVXQNjoFqtnwRPK2thxVkwTsmbuEbDfyACbeOzqC 1Fhgl4BLV9RPIncWS2o7iLKiih7fSBcJJPjWDsajIWdYjzD4PBaZBSB7rbw/m7Eb4Koj 7bynkut6ileHW5xEwktrucRbX++MhLQvPs6Q7nA2cTVMQ5T69EcquDRClle2Y4cRGx4M OVdQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685096963; x=1687688963; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=/K6PbDpa1bEXTu9+nLfG+TEYuGga9QGQcY866PUs1S4=; b=OyuKfys8TrR8z5tGADMx5zS49xLNkfAbI9UsHFkXBvu0rjegdM8x/OB9SQxAdjNcPB moX1yn4IZW8NveGU8hXZ9ZM3r/N0Gr9+b5RLVbyKEzMT25wKlW2JG7h0Ju2/PtDkUIWP qXFlwx/CV8gjC/iaapdUpYnON4h8Mys6SOoLQvBtf/2+j8NIFptBAG80p4zNYh8JilL1 4NYZvTPb0K6yuVrh5UbXzLhNv/mqCgpNANsUjP7OaiUG1TImg+Tku73dgWv0LmWaUkg5 cFLob4iKTP7yQciJJYh4DvShIc7QKwsYn4oyKzp3QXHL5hnne42iuuWHb+LTp1OR6ZqU WNqw== X-Gm-Message-State: AC+VfDwNVrkd0TNRk63Em9WixirgpA/2tv4vogiDAVw8d3RzfDMVMyHE z3yzegPXMwG5pTkMgbXpN+/JDA== X-Google-Smtp-Source: ACHHUZ5Iev8xVgOOk2KPuQQZDGrJvE8omFBcgdT2Z9BmUX0sPH8sQxquSzcLsJQ9AqRoacTuX8xVcg== X-Received: by 2002:a2e:b16b:0:b0:2a8:ac69:bfe with SMTP id a11-20020a2eb16b000000b002a8ac690bfemr489694ljm.42.1685096962859; Fri, 26 May 2023 03:29:22 -0700 (PDT) Received: from [192.168.1.101] (abyj77.neoplus.adsl.tpnet.pl. [83.9.29.77]) by smtp.gmail.com with ESMTPSA id a17-20020a2e88d1000000b002af25598f07sm650315ljk.78.2023.05.26.03.29.21 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 26 May 2023 03:29:22 -0700 (PDT) Message-ID: Date: Fri, 26 May 2023 12:29:21 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH 2/4] arm64: dts: qcom: ipq5332: add QFPROM node Content-Language: en-US To: Kathiravan T , Andy Gross , Bjorn Andersson , Srinivas Kandagatla , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20230526070421.25406-1-quic_kathirav@quicinc.com> <20230526070421.25406-3-quic_kathirav@quicinc.com> <55200328-735d-6571-fcad-735cc9d1568b@linaro.org> From: Konrad Dybcio In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On 26.05.2023 12:24, Kathiravan T wrote: > > On 5/26/2023 2:49 PM, Konrad Dybcio wrote: >> >> On 26.05.2023 09:04, Kathiravan T wrote: >>> IPQ5332 has efuse region to determine the various HW quirks. Lets >>> add the initial support and the individual fuses will be added as they >>> are required. >>> >>> Signed-off-by: Kathiravan T >>> --- >>>   arch/arm64/boot/dts/qcom/ipq5332.dtsi | 7 +++++++ >>>   1 file changed, 7 insertions(+) >>> >>> diff --git a/arch/arm64/boot/dts/qcom/ipq5332.dtsi b/arch/arm64/boot/dts/qcom/ipq5332.dtsi >>> index af4d97143bcf..c2d6cc65a323 100644 >>> --- a/arch/arm64/boot/dts/qcom/ipq5332.dtsi >>> +++ b/arch/arm64/boot/dts/qcom/ipq5332.dtsi >>> @@ -135,6 +135,13 @@ >>>           #size-cells = <1>; >>>           ranges = <0 0 0 0xffffffff>; >>>   +        qfprom: efuse@a4000 { >>> +            compatible = "qcom,ipq5332-qfprom", "qcom,qfprom"; >>> +            reg = <0x000a4000 0x721>; >> That's an odd size. Are you sure this is how long the corrected region is? > > > Yes, As per the HW document, this is the size. OK thanks for confirming Reviewed-by: Konrad Dybcio Konrad > > >> >> Konrad >>> +            #address-cells = <1>; >>> +            #size-cells = <1>; >>> +        }; >>> + >>>           rng: rng@e3000 { >>>               compatible = "qcom,prng-ee"; >>>               reg = <0x000e3000 0x1000>;