- * [PATCH 1/4] dt-bindings: nvmem: qfprom: add compatible for few IPQ SoCs
  2023-05-26  7:04 [PATCH 0/3] Add QFPROM support for few IPQ SoCs Kathiravan T
@ 2023-05-26  7:04 ` Kathiravan T
  2023-05-26 18:35   ` Conor Dooley
  2023-05-26  7:04 ` [PATCH 2/4] arm64: dts: qcom: ipq5332: add QFPROM node Kathiravan T
                   ` (2 subsequent siblings)
  3 siblings, 1 reply; 14+ messages in thread
From: Kathiravan T @ 2023-05-26  7:04 UTC (permalink / raw)
  To: Andy Gross, Bjorn Andersson, Konrad Dybcio, Srinivas Kandagatla,
	Rob Herring, Krzysztof Kozlowski, Conor Dooley, linux-arm-msm,
	devicetree, linux-kernel
  Cc: Kathiravan T
Add the QFPROM compatible for IPQ5332, IPQ6018 and IPQ9574
Signed-off-by: Kathiravan T <quic_kathirav@quicinc.com>
---
 Documentation/devicetree/bindings/nvmem/qcom,qfprom.yaml | 3 +++
 1 file changed, 3 insertions(+)
diff --git a/Documentation/devicetree/bindings/nvmem/qcom,qfprom.yaml b/Documentation/devicetree/bindings/nvmem/qcom,qfprom.yaml
index 8d8503dd934b..076566ef9cc8 100644
--- a/Documentation/devicetree/bindings/nvmem/qcom,qfprom.yaml
+++ b/Documentation/devicetree/bindings/nvmem/qcom,qfprom.yaml
@@ -18,8 +18,11 @@ properties:
       - enum:
           - qcom,apq8064-qfprom
           - qcom,apq8084-qfprom
+          - qcom,ipq5332-qfprom
+          - qcom,ipq6018-qfprom
           - qcom,ipq8064-qfprom
           - qcom,ipq8074-qfprom
+          - qcom,ipq9574-qfprom
           - qcom,msm8916-qfprom
           - qcom,msm8974-qfprom
           - qcom,msm8976-qfprom
-- 
2.17.1
^ permalink raw reply related	[flat|nested] 14+ messages in thread
- * Re: [PATCH 1/4] dt-bindings: nvmem: qfprom: add compatible for few IPQ SoCs
  2023-05-26  7:04 ` [PATCH 1/4] dt-bindings: nvmem: qfprom: add compatible " Kathiravan T
@ 2023-05-26 18:35   ` Conor Dooley
  0 siblings, 0 replies; 14+ messages in thread
From: Conor Dooley @ 2023-05-26 18:35 UTC (permalink / raw)
  To: Kathiravan T
  Cc: Andy Gross, Bjorn Andersson, Konrad Dybcio, Srinivas Kandagatla,
	Rob Herring, Krzysztof Kozlowski, Conor Dooley, linux-arm-msm,
	devicetree, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 262 bytes --]
On Fri, May 26, 2023 at 12:34:18PM +0530, Kathiravan T wrote:
> Add the QFPROM compatible for IPQ5332, IPQ6018 and IPQ9574
> 
> Signed-off-by: Kathiravan T <quic_kathirav@quicinc.com>
Acked-by: Conor Dooley <conor.dooley@microchip.com>
Thanks,
Conor.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply	[flat|nested] 14+ messages in thread 
 
- * [PATCH 2/4] arm64: dts: qcom: ipq5332: add QFPROM node
  2023-05-26  7:04 [PATCH 0/3] Add QFPROM support for few IPQ SoCs Kathiravan T
  2023-05-26  7:04 ` [PATCH 1/4] dt-bindings: nvmem: qfprom: add compatible " Kathiravan T
@ 2023-05-26  7:04 ` Kathiravan T
  2023-05-26  9:19   ` Konrad Dybcio
  2023-05-26  7:04 ` [PATCH 3/4] arm64: dts: qcom: ipq6018: " Kathiravan T
  2023-05-26  7:04 ` [PATCH 4/4] arm64: dts: qcom: ipq9574: " Kathiravan T
  3 siblings, 1 reply; 14+ messages in thread
From: Kathiravan T @ 2023-05-26  7:04 UTC (permalink / raw)
  To: Andy Gross, Bjorn Andersson, Konrad Dybcio, Srinivas Kandagatla,
	Rob Herring, Krzysztof Kozlowski, Conor Dooley, linux-arm-msm,
	devicetree, linux-kernel
  Cc: Kathiravan T
IPQ5332 has efuse region to determine the various HW quirks. Lets
add the initial support and the individual fuses will be added as they
are required.
Signed-off-by: Kathiravan T <quic_kathirav@quicinc.com>
---
 arch/arm64/boot/dts/qcom/ipq5332.dtsi | 7 +++++++
 1 file changed, 7 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/ipq5332.dtsi b/arch/arm64/boot/dts/qcom/ipq5332.dtsi
index af4d97143bcf..c2d6cc65a323 100644
--- a/arch/arm64/boot/dts/qcom/ipq5332.dtsi
+++ b/arch/arm64/boot/dts/qcom/ipq5332.dtsi
@@ -135,6 +135,13 @@
 		#size-cells = <1>;
 		ranges = <0 0 0 0xffffffff>;
 
+		qfprom: efuse@a4000 {
+			compatible = "qcom,ipq5332-qfprom", "qcom,qfprom";
+			reg = <0x000a4000 0x721>;
+			#address-cells = <1>;
+			#size-cells = <1>;
+		};
+
 		rng: rng@e3000 {
 			compatible = "qcom,prng-ee";
 			reg = <0x000e3000 0x1000>;
-- 
2.17.1
^ permalink raw reply related	[flat|nested] 14+ messages in thread
- * Re: [PATCH 2/4] arm64: dts: qcom: ipq5332: add QFPROM node
  2023-05-26  7:04 ` [PATCH 2/4] arm64: dts: qcom: ipq5332: add QFPROM node Kathiravan T
@ 2023-05-26  9:19   ` Konrad Dybcio
  2023-05-26 10:24     ` Kathiravan T
  0 siblings, 1 reply; 14+ messages in thread
From: Konrad Dybcio @ 2023-05-26  9:19 UTC (permalink / raw)
  To: Kathiravan T, Andy Gross, Bjorn Andersson, Srinivas Kandagatla,
	Rob Herring, Krzysztof Kozlowski, Conor Dooley, linux-arm-msm,
	devicetree, linux-kernel
On 26.05.2023 09:04, Kathiravan T wrote:
> IPQ5332 has efuse region to determine the various HW quirks. Lets
> add the initial support and the individual fuses will be added as they
> are required.
> 
> Signed-off-by: Kathiravan T <quic_kathirav@quicinc.com>
> ---
>  arch/arm64/boot/dts/qcom/ipq5332.dtsi | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/qcom/ipq5332.dtsi b/arch/arm64/boot/dts/qcom/ipq5332.dtsi
> index af4d97143bcf..c2d6cc65a323 100644
> --- a/arch/arm64/boot/dts/qcom/ipq5332.dtsi
> +++ b/arch/arm64/boot/dts/qcom/ipq5332.dtsi
> @@ -135,6 +135,13 @@
>  		#size-cells = <1>;
>  		ranges = <0 0 0 0xffffffff>;
>  
> +		qfprom: efuse@a4000 {
> +			compatible = "qcom,ipq5332-qfprom", "qcom,qfprom";
> +			reg = <0x000a4000 0x721>;
That's an odd size. Are you sure this is how long the corrected region is?
Konrad
> +			#address-cells = <1>;
> +			#size-cells = <1>;
> +		};
> +
>  		rng: rng@e3000 {
>  			compatible = "qcom,prng-ee";
>  			reg = <0x000e3000 0x1000>;
^ permalink raw reply	[flat|nested] 14+ messages in thread
- * Re: [PATCH 2/4] arm64: dts: qcom: ipq5332: add QFPROM node
  2023-05-26  9:19   ` Konrad Dybcio
@ 2023-05-26 10:24     ` Kathiravan T
  2023-05-26 10:29       ` Konrad Dybcio
  0 siblings, 1 reply; 14+ messages in thread
From: Kathiravan T @ 2023-05-26 10:24 UTC (permalink / raw)
  To: Konrad Dybcio, Andy Gross, Bjorn Andersson, Srinivas Kandagatla,
	Rob Herring, Krzysztof Kozlowski, Conor Dooley, linux-arm-msm,
	devicetree, linux-kernel
On 5/26/2023 2:49 PM, Konrad Dybcio wrote:
>
> On 26.05.2023 09:04, Kathiravan T wrote:
>> IPQ5332 has efuse region to determine the various HW quirks. Lets
>> add the initial support and the individual fuses will be added as they
>> are required.
>>
>> Signed-off-by: Kathiravan T <quic_kathirav@quicinc.com>
>> ---
>>   arch/arm64/boot/dts/qcom/ipq5332.dtsi | 7 +++++++
>>   1 file changed, 7 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/ipq5332.dtsi b/arch/arm64/boot/dts/qcom/ipq5332.dtsi
>> index af4d97143bcf..c2d6cc65a323 100644
>> --- a/arch/arm64/boot/dts/qcom/ipq5332.dtsi
>> +++ b/arch/arm64/boot/dts/qcom/ipq5332.dtsi
>> @@ -135,6 +135,13 @@
>>   		#size-cells = <1>;
>>   		ranges = <0 0 0 0xffffffff>;
>>   
>> +		qfprom: efuse@a4000 {
>> +			compatible = "qcom,ipq5332-qfprom", "qcom,qfprom";
>> +			reg = <0x000a4000 0x721>;
> That's an odd size. Are you sure this is how long the corrected region is?
Yes, As per the HW document, this is the size.
>
> Konrad
>> +			#address-cells = <1>;
>> +			#size-cells = <1>;
>> +		};
>> +
>>   		rng: rng@e3000 {
>>   			compatible = "qcom,prng-ee";
>>   			reg = <0x000e3000 0x1000>;
^ permalink raw reply	[flat|nested] 14+ messages in thread
- * Re: [PATCH 2/4] arm64: dts: qcom: ipq5332: add QFPROM node
  2023-05-26 10:24     ` Kathiravan T
@ 2023-05-26 10:29       ` Konrad Dybcio
  0 siblings, 0 replies; 14+ messages in thread
From: Konrad Dybcio @ 2023-05-26 10:29 UTC (permalink / raw)
  To: Kathiravan T, Andy Gross, Bjorn Andersson, Srinivas Kandagatla,
	Rob Herring, Krzysztof Kozlowski, Conor Dooley, linux-arm-msm,
	devicetree, linux-kernel
On 26.05.2023 12:24, Kathiravan T wrote:
> 
> On 5/26/2023 2:49 PM, Konrad Dybcio wrote:
>>
>> On 26.05.2023 09:04, Kathiravan T wrote:
>>> IPQ5332 has efuse region to determine the various HW quirks. Lets
>>> add the initial support and the individual fuses will be added as they
>>> are required.
>>>
>>> Signed-off-by: Kathiravan T <quic_kathirav@quicinc.com>
>>> ---
>>>   arch/arm64/boot/dts/qcom/ipq5332.dtsi | 7 +++++++
>>>   1 file changed, 7 insertions(+)
>>>
>>> diff --git a/arch/arm64/boot/dts/qcom/ipq5332.dtsi b/arch/arm64/boot/dts/qcom/ipq5332.dtsi
>>> index af4d97143bcf..c2d6cc65a323 100644
>>> --- a/arch/arm64/boot/dts/qcom/ipq5332.dtsi
>>> +++ b/arch/arm64/boot/dts/qcom/ipq5332.dtsi
>>> @@ -135,6 +135,13 @@
>>>           #size-cells = <1>;
>>>           ranges = <0 0 0 0xffffffff>;
>>>   +        qfprom: efuse@a4000 {
>>> +            compatible = "qcom,ipq5332-qfprom", "qcom,qfprom";
>>> +            reg = <0x000a4000 0x721>;
>> That's an odd size. Are you sure this is how long the corrected region is?
> 
> 
> Yes, As per the HW document, this is the size.
OK thanks for confirming
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
Konrad
> 
> 
>>
>> Konrad
>>> +            #address-cells = <1>;
>>> +            #size-cells = <1>;
>>> +        };
>>> +
>>>           rng: rng@e3000 {
>>>               compatible = "qcom,prng-ee";
>>>               reg = <0x000e3000 0x1000>;
^ permalink raw reply	[flat|nested] 14+ messages in thread
 
 
 
- * [PATCH 3/4] arm64: dts: qcom: ipq6018: add QFPROM node
  2023-05-26  7:04 [PATCH 0/3] Add QFPROM support for few IPQ SoCs Kathiravan T
  2023-05-26  7:04 ` [PATCH 1/4] dt-bindings: nvmem: qfprom: add compatible " Kathiravan T
  2023-05-26  7:04 ` [PATCH 2/4] arm64: dts: qcom: ipq5332: add QFPROM node Kathiravan T
@ 2023-05-26  7:04 ` Kathiravan T
  2023-05-26  9:24   ` Konrad Dybcio
  2023-05-26  7:04 ` [PATCH 4/4] arm64: dts: qcom: ipq9574: " Kathiravan T
  3 siblings, 1 reply; 14+ messages in thread
From: Kathiravan T @ 2023-05-26  7:04 UTC (permalink / raw)
  To: Andy Gross, Bjorn Andersson, Konrad Dybcio, Srinivas Kandagatla,
	Rob Herring, Krzysztof Kozlowski, Conor Dooley, linux-arm-msm,
	devicetree, linux-kernel
  Cc: Kathiravan T
IPQ6018 has efuse region to determine the various HW quirks. Lets
add the initial support and the individual fuses will be added as they
are required.
Signed-off-by: Kathiravan T <quic_kathirav@quicinc.com>
---
 arch/arm64/boot/dts/qcom/ipq6018.dtsi | 7 +++++++
 1 file changed, 7 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/ipq6018.dtsi b/arch/arm64/boot/dts/qcom/ipq6018.dtsi
index f531797f2619..856879fd0207 100644
--- a/arch/arm64/boot/dts/qcom/ipq6018.dtsi
+++ b/arch/arm64/boot/dts/qcom/ipq6018.dtsi
@@ -206,6 +206,13 @@
 		dma-ranges;
 		compatible = "simple-bus";
 
+		qfprom: efuse@a4000 {
+			compatible = "qcom,ipq6018-qfprom", "qcom,qfprom";
+			reg = <0x0 0x000a4000 0x0 0x2000>;
+			#address-cells = <1>;
+			#size-cells = <1>;
+		};
+
 		qusb_phy_1: qusb@59000 {
 			compatible = "qcom,ipq6018-qusb2-phy";
 			reg = <0x0 0x00059000 0x0 0x180>;
-- 
2.17.1
^ permalink raw reply related	[flat|nested] 14+ messages in thread
- * Re: [PATCH 3/4] arm64: dts: qcom: ipq6018: add QFPROM node
  2023-05-26  7:04 ` [PATCH 3/4] arm64: dts: qcom: ipq6018: " Kathiravan T
@ 2023-05-26  9:24   ` Konrad Dybcio
  2023-05-26 10:22     ` Kathiravan T
  0 siblings, 1 reply; 14+ messages in thread
From: Konrad Dybcio @ 2023-05-26  9:24 UTC (permalink / raw)
  To: Kathiravan T, Andy Gross, Bjorn Andersson, Srinivas Kandagatla,
	Rob Herring, Krzysztof Kozlowski, Conor Dooley, linux-arm-msm,
	devicetree, linux-kernel
On 26.05.2023 09:04, Kathiravan T wrote:
> IPQ6018 has efuse region to determine the various HW quirks. Lets
> add the initial support and the individual fuses will be added as they
> are required.
> 
> Signed-off-by: Kathiravan T <quic_kathirav@quicinc.com>
> ---
>  arch/arm64/boot/dts/qcom/ipq6018.dtsi | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/qcom/ipq6018.dtsi b/arch/arm64/boot/dts/qcom/ipq6018.dtsi
> index f531797f2619..856879fd0207 100644
> --- a/arch/arm64/boot/dts/qcom/ipq6018.dtsi
> +++ b/arch/arm64/boot/dts/qcom/ipq6018.dtsi
> @@ -206,6 +206,13 @@
>  		dma-ranges;
>  		compatible = "simple-bus";
>  
> +		qfprom: efuse@a4000 {
This should be a bit lower down (0xa4000 > 0x59000)
Konrad
> +			compatible = "qcom,ipq6018-qfprom", "qcom,qfprom";
> +			reg = <0x0 0x000a4000 0x0 0x2000>;
> +			#address-cells = <1>;
> +			#size-cells = <1>;
> +		};
> +
>  		qusb_phy_1: qusb@59000 {
>  			compatible = "qcom,ipq6018-qusb2-phy";
>  			reg = <0x0 0x00059000 0x0 0x180>;
^ permalink raw reply	[flat|nested] 14+ messages in thread
- * Re: [PATCH 3/4] arm64: dts: qcom: ipq6018: add QFPROM node
  2023-05-26  9:24   ` Konrad Dybcio
@ 2023-05-26 10:22     ` Kathiravan T
  0 siblings, 0 replies; 14+ messages in thread
From: Kathiravan T @ 2023-05-26 10:22 UTC (permalink / raw)
  To: Konrad Dybcio, Andy Gross, Bjorn Andersson, Srinivas Kandagatla,
	Rob Herring, Krzysztof Kozlowski, Conor Dooley, linux-arm-msm,
	devicetree, linux-kernel
On 5/26/2023 2:54 PM, Konrad Dybcio wrote:
>
> On 26.05.2023 09:04, Kathiravan T wrote:
>> IPQ6018 has efuse region to determine the various HW quirks. Lets
>> add the initial support and the individual fuses will be added as they
>> are required.
>>
>> Signed-off-by: Kathiravan T <quic_kathirav@quicinc.com>
>> ---
>>   arch/arm64/boot/dts/qcom/ipq6018.dtsi | 7 +++++++
>>   1 file changed, 7 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/ipq6018.dtsi b/arch/arm64/boot/dts/qcom/ipq6018.dtsi
>> index f531797f2619..856879fd0207 100644
>> --- a/arch/arm64/boot/dts/qcom/ipq6018.dtsi
>> +++ b/arch/arm64/boot/dts/qcom/ipq6018.dtsi
>> @@ -206,6 +206,13 @@
>>   		dma-ranges;
>>   		compatible = "simple-bus";
>>   
>> +		qfprom: efuse@a4000 {
> This should be a bit lower down (0xa4000 > 0x59000)
Sorry, missed this. Will address in V2.
>
> Konrad
>> +			compatible = "qcom,ipq6018-qfprom", "qcom,qfprom";
>> +			reg = <0x0 0x000a4000 0x0 0x2000>;
>> +			#address-cells = <1>;
>> +			#size-cells = <1>;
>> +		};
>> +
>>   		qusb_phy_1: qusb@59000 {
>>   			compatible = "qcom,ipq6018-qusb2-phy";
>>   			reg = <0x0 0x00059000 0x0 0x180>;
^ permalink raw reply	[flat|nested] 14+ messages in thread
 
 
- * [PATCH 4/4] arm64: dts: qcom: ipq9574: add QFPROM node
  2023-05-26  7:04 [PATCH 0/3] Add QFPROM support for few IPQ SoCs Kathiravan T
                   ` (2 preceding siblings ...)
  2023-05-26  7:04 ` [PATCH 3/4] arm64: dts: qcom: ipq6018: " Kathiravan T
@ 2023-05-26  7:04 ` Kathiravan T
  2023-05-26  9:19   ` Konrad Dybcio
  3 siblings, 1 reply; 14+ messages in thread
From: Kathiravan T @ 2023-05-26  7:04 UTC (permalink / raw)
  To: Andy Gross, Bjorn Andersson, Konrad Dybcio, Srinivas Kandagatla,
	Rob Herring, Krzysztof Kozlowski, Conor Dooley, linux-arm-msm,
	devicetree, linux-kernel
  Cc: Kathiravan T
IPQ9574 has efuse region to determine the various HW quirks. Lets
add the initial support and the individual fuses will be added as they
are required.
Signed-off-by: Kathiravan T <quic_kathirav@quicinc.com>
---
 arch/arm64/boot/dts/qcom/ipq9574.dtsi | 7 +++++++
 1 file changed, 7 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/ipq9574.dtsi b/arch/arm64/boot/dts/qcom/ipq9574.dtsi
index 1a2c813ffd43..715fe51ff567 100644
--- a/arch/arm64/boot/dts/qcom/ipq9574.dtsi
+++ b/arch/arm64/boot/dts/qcom/ipq9574.dtsi
@@ -117,6 +117,13 @@
 		#size-cells = <1>;
 		ranges = <0 0 0 0xffffffff>;
 
+		qfprom: efuse@a4000 {
+			compatible = "qcom,ipq9574-qfprom", "qcom,qfprom";
+			reg = <0x000a4000 0x5a1>;
+			#address-cells = <1>;
+			#size-cells = <1>;
+		};
+
 		tlmm: pinctrl@1000000 {
 			compatible = "qcom,ipq9574-tlmm";
 			reg = <0x01000000 0x300000>;
-- 
2.17.1
^ permalink raw reply related	[flat|nested] 14+ messages in thread
- * Re: [PATCH 4/4] arm64: dts: qcom: ipq9574: add QFPROM node
  2023-05-26  7:04 ` [PATCH 4/4] arm64: dts: qcom: ipq9574: " Kathiravan T
@ 2023-05-26  9:19   ` Konrad Dybcio
  2023-05-26 10:24     ` Kathiravan T
  0 siblings, 1 reply; 14+ messages in thread
From: Konrad Dybcio @ 2023-05-26  9:19 UTC (permalink / raw)
  To: Kathiravan T, Andy Gross, Bjorn Andersson, Srinivas Kandagatla,
	Rob Herring, Krzysztof Kozlowski, Conor Dooley, linux-arm-msm,
	devicetree, linux-kernel
On 26.05.2023 09:04, Kathiravan T wrote:
> IPQ9574 has efuse region to determine the various HW quirks. Lets
> add the initial support and the individual fuses will be added as they
> are required.
> 
> Signed-off-by: Kathiravan T <quic_kathirav@quicinc.com>
> ---
>  arch/arm64/boot/dts/qcom/ipq9574.dtsi | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/qcom/ipq9574.dtsi b/arch/arm64/boot/dts/qcom/ipq9574.dtsi
> index 1a2c813ffd43..715fe51ff567 100644
> --- a/arch/arm64/boot/dts/qcom/ipq9574.dtsi
> +++ b/arch/arm64/boot/dts/qcom/ipq9574.dtsi
> @@ -117,6 +117,13 @@
>  		#size-cells = <1>;
>  		ranges = <0 0 0 0xffffffff>;
>  
> +		qfprom: efuse@a4000 {
> +			compatible = "qcom,ipq9574-qfprom", "qcom,qfprom";
> +			reg = <0x000a4000 0x5a1>;
That's an odd size. Are you sure this is how long the corrected region is?
Konrad
> +			#address-cells = <1>;
> +			#size-cells = <1>;
> +		};
> +
>  		tlmm: pinctrl@1000000 {
>  			compatible = "qcom,ipq9574-tlmm";
>  			reg = <0x01000000 0x300000>;
^ permalink raw reply	[flat|nested] 14+ messages in thread
- * Re: [PATCH 4/4] arm64: dts: qcom: ipq9574: add QFPROM node
  2023-05-26  9:19   ` Konrad Dybcio
@ 2023-05-26 10:24     ` Kathiravan T
  2023-05-26 10:29       ` Konrad Dybcio
  0 siblings, 1 reply; 14+ messages in thread
From: Kathiravan T @ 2023-05-26 10:24 UTC (permalink / raw)
  To: Konrad Dybcio, Andy Gross, Bjorn Andersson, Srinivas Kandagatla,
	Rob Herring, Krzysztof Kozlowski, Conor Dooley, linux-arm-msm,
	devicetree, linux-kernel
On 5/26/2023 2:49 PM, Konrad Dybcio wrote:
>
> On 26.05.2023 09:04, Kathiravan T wrote:
>> IPQ9574 has efuse region to determine the various HW quirks. Lets
>> add the initial support and the individual fuses will be added as they
>> are required.
>>
>> Signed-off-by: Kathiravan T <quic_kathirav@quicinc.com>
>> ---
>>   arch/arm64/boot/dts/qcom/ipq9574.dtsi | 7 +++++++
>>   1 file changed, 7 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/ipq9574.dtsi b/arch/arm64/boot/dts/qcom/ipq9574.dtsi
>> index 1a2c813ffd43..715fe51ff567 100644
>> --- a/arch/arm64/boot/dts/qcom/ipq9574.dtsi
>> +++ b/arch/arm64/boot/dts/qcom/ipq9574.dtsi
>> @@ -117,6 +117,13 @@
>>   		#size-cells = <1>;
>>   		ranges = <0 0 0 0xffffffff>;
>>   
>> +		qfprom: efuse@a4000 {
>> +			compatible = "qcom,ipq9574-qfprom", "qcom,qfprom";
>> +			reg = <0x000a4000 0x5a1>;
> That's an odd size. Are you sure this is how long the corrected region is?
Yes, As per the HW document, this is the size.
>
> Konrad
>> +			#address-cells = <1>;
>> +			#size-cells = <1>;
>> +		};
>> +
>>   		tlmm: pinctrl@1000000 {
>>   			compatible = "qcom,ipq9574-tlmm";
>>   			reg = <0x01000000 0x300000>;
^ permalink raw reply	[flat|nested] 14+ messages in thread
- * Re: [PATCH 4/4] arm64: dts: qcom: ipq9574: add QFPROM node
  2023-05-26 10:24     ` Kathiravan T
@ 2023-05-26 10:29       ` Konrad Dybcio
  0 siblings, 0 replies; 14+ messages in thread
From: Konrad Dybcio @ 2023-05-26 10:29 UTC (permalink / raw)
  To: Kathiravan T, Andy Gross, Bjorn Andersson, Srinivas Kandagatla,
	Rob Herring, Krzysztof Kozlowski, Conor Dooley, linux-arm-msm,
	devicetree, linux-kernel
On 26.05.2023 12:24, Kathiravan T wrote:
> 
> On 5/26/2023 2:49 PM, Konrad Dybcio wrote:
>>
>> On 26.05.2023 09:04, Kathiravan T wrote:
>>> IPQ9574 has efuse region to determine the various HW quirks. Lets
>>> add the initial support and the individual fuses will be added as they
>>> are required.
>>>
>>> Signed-off-by: Kathiravan T <quic_kathirav@quicinc.com>
>>> ---
>>>   arch/arm64/boot/dts/qcom/ipq9574.dtsi | 7 +++++++
>>>   1 file changed, 7 insertions(+)
>>>
>>> diff --git a/arch/arm64/boot/dts/qcom/ipq9574.dtsi b/arch/arm64/boot/dts/qcom/ipq9574.dtsi
>>> index 1a2c813ffd43..715fe51ff567 100644
>>> --- a/arch/arm64/boot/dts/qcom/ipq9574.dtsi
>>> +++ b/arch/arm64/boot/dts/qcom/ipq9574.dtsi
>>> @@ -117,6 +117,13 @@
>>>           #size-cells = <1>;
>>>           ranges = <0 0 0 0xffffffff>;
>>>   +        qfprom: efuse@a4000 {
>>> +            compatible = "qcom,ipq9574-qfprom", "qcom,qfprom";
>>> +            reg = <0x000a4000 0x5a1>;
>> That's an odd size. Are you sure this is how long the corrected region is?
> 
> 
> Yes, As per the HW document, this is the size.
Thanks for confirming
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
Konrad
> 
> 
>>
>> Konrad
>>> +            #address-cells = <1>;
>>> +            #size-cells = <1>;
>>> +        };
>>> +
>>>           tlmm: pinctrl@1000000 {
>>>               compatible = "qcom,ipq9574-tlmm";
>>>               reg = <0x01000000 0x300000>;
^ permalink raw reply	[flat|nested] 14+ messages in thread