* [PATCH 00/15] arm: dts: Fix OPP and cooling device properties
@ 2018-05-25 10:31 Viresh Kumar
2018-05-25 10:32 ` [PATCH 14/15] arm: dts: qcom: Add missing OPP properties for CPUs Viresh Kumar
0 siblings, 1 reply; 5+ messages in thread
From: Viresh Kumar @ 2018-05-25 10:31 UTC (permalink / raw)
To: arm, Andrew Lunn, Andy Gross, Benoît Cousson, Chen-Yu Tsai,
David Brown, Fabio Estevam, Gregory Clement, Heiko Stuebner,
Jason Cooper, Jisheng Zhang, Krzysztof Kozlowski, Kukjin Kim,
Magnus Damm, Mark Rutland, Masahiro Yamada, Matthias Brugger,
Maxime Ripard, Pengutronix Kernel Team
Cc: Viresh Kumar, Vincent Guittot, ionela.voinescu, Daniel Lezcano,
chris.redpath, devicetree, linux-arm-kernel, linux-arm-msm,
linux-kernel, linux-mediatek, linux-omap, linux-renesas-soc,
linux-rockchip, linux-samsung-soc, linux-soc
This fixes missing OPP and cooling device properties for CPUs for the
ARM 32 bit platforms. This is build tested by the zero day testing
infrastructure as well.
Individual maintainers can pick the patches to their SoC trees or I will
ask ARM SoC maintainers to pick them up later.
--
viresh
Viresh Kumar (15):
arm: dts: armada: Fix "#cooling-cells" property's name
arm: dts: ls1021a: Add missing cooling device properties for CPUs
arm: dts: mediatek: Add missing cooling device properties for CPUs
arm: dts: rk322x: Add missing cooling device properties for CPUs
arm: dts: uniphier: Add missing cooling device properties for CPUs
arm: dts: sun: Add missing cooling device properties for CPUs
arm: dts: exynos: Add missing cooling device properties for CPUs
arm: dts: dra74x: Add missing cooling device properties for CPUs
arm: dts: omap: Add missing cooling device properties for CPUs
arm: dts: rk3288: Add missing cooling device properties for CPUs
arm: dts: berlin: Add missing OPP properties for CPUs
arm: dts: highbank: Add missing OPP properties for CPUs
arm: dts: r8a7743: Add missing OPP properties for CPUs
arm: dts: qcom: Add missing OPP properties for CPUs
arm: dts: imx: Add missing OPP properties for CPUs
arch/arm/boot/dts/armada-385-synology-ds116.dts | 2 +-
arch/arm/boot/dts/berlin2.dtsi | 10 +++
arch/arm/boot/dts/berlin2q.dtsi | 33 ++++++++++
arch/arm/boot/dts/dra74x.dtsi | 10 +++
arch/arm/boot/dts/exynos3250.dtsi | 16 +++++
arch/arm/boot/dts/exynos4210.dtsi | 13 ++++
arch/arm/boot/dts/exynos4412.dtsi | 9 +++
arch/arm/boot/dts/exynos5250.dtsi | 23 +++++++
arch/arm/boot/dts/highbank.dts | 30 +++++++++
arch/arm/boot/dts/imx6dl.dtsi | 23 +++++++
arch/arm/boot/dts/imx6q-cm-fx6.dts | 66 +++++++++++++++++++
arch/arm/boot/dts/imx6q.dtsi | 87 ++++++++++++++++++++++++-
arch/arm/boot/dts/imx7d.dtsi | 5 ++
arch/arm/boot/dts/ls1021a.dtsi | 1 +
arch/arm/boot/dts/mt7623.dtsi | 3 +
arch/arm/boot/dts/omap5.dtsi | 14 ++++
arch/arm/boot/dts/qcom-ipq4019.dtsi | 24 +++++++
arch/arm/boot/dts/r8a7743.dtsi | 9 +++
arch/arm/boot/dts/rk322x.dtsi | 3 +
arch/arm/boot/dts/rk3288.dtsi | 54 +++++++++++++++
arch/arm/boot/dts/sun6i-a31.dtsi | 30 +++++++++
arch/arm/boot/dts/sun7i-a20.dtsi | 13 ++++
arch/arm/boot/dts/sun8i-a33.dtsi | 9 +++
arch/arm/boot/dts/sun8i-h3.dtsi | 9 +++
arch/arm/boot/dts/uniphier-pxs2.dtsi | 3 +
25 files changed, 495 insertions(+), 4 deletions(-)
--
2.15.0.194.g9af6a3dea062
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH 14/15] arm: dts: qcom: Add missing OPP properties for CPUs
2018-05-25 10:31 [PATCH 00/15] arm: dts: Fix OPP and cooling device properties Viresh Kumar
@ 2018-05-25 10:32 ` Viresh Kumar
2018-07-18 6:08 ` Viresh Kumar
2018-07-18 10:22 ` Amit Kucheria
0 siblings, 2 replies; 5+ messages in thread
From: Viresh Kumar @ 2018-05-25 10:32 UTC (permalink / raw)
To: arm, Andy Gross, David Brown, Rob Herring, Mark Rutland
Cc: Viresh Kumar, Vincent Guittot, ionela.voinescu, Daniel Lezcano,
chris.redpath, linux-arm-msm, linux-soc, devicetree, linux-kernel
The OPP properties, like "operating-points", should either be present
for all the CPUs of a cluster or none. If these are present only for a
subset of CPUs of a cluster then things will start falling apart as soon
as the CPUs are brought online in a different order. For example, this
will happen because the operating system looks for such properties in
the CPU node it is trying to bring up, so that it can create an OPP
table.
Add such missing properties.
Fix other missing property (clock latency) as well to make it all
work.
Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
---
arch/arm/boot/dts/qcom-ipq4019.dtsi | 24 ++++++++++++++++++++++++
1 file changed, 24 insertions(+)
diff --git a/arch/arm/boot/dts/qcom-ipq4019.dtsi b/arch/arm/boot/dts/qcom-ipq4019.dtsi
index b25daf368012..8c202b359270 100644
--- a/arch/arm/boot/dts/qcom-ipq4019.dtsi
+++ b/arch/arm/boot/dts/qcom-ipq4019.dtsi
@@ -75,6 +75,14 @@
reg = <0x1>;
clocks = <&gcc GCC_APPS_CLK_SRC>;
clock-frequency = <0>;
+ operating-points = <
+ /* kHz uV (fixed) */
+ 48000 1100000
+ 200000 1100000
+ 500000 1100000
+ 666000 1100000
+ >;
+ clock-latency = <256000>;
};
cpu@2 {
@@ -86,6 +94,14 @@
reg = <0x2>;
clocks = <&gcc GCC_APPS_CLK_SRC>;
clock-frequency = <0>;
+ operating-points = <
+ /* kHz uV (fixed) */
+ 48000 1100000
+ 200000 1100000
+ 500000 1100000
+ 666000 1100000
+ >;
+ clock-latency = <256000>;
};
cpu@3 {
@@ -97,6 +113,14 @@
reg = <0x3>;
clocks = <&gcc GCC_APPS_CLK_SRC>;
clock-frequency = <0>;
+ operating-points = <
+ /* kHz uV (fixed) */
+ 48000 1100000
+ 200000 1100000
+ 500000 1100000
+ 666000 1100000
+ >;
+ clock-latency = <256000>;
};
};
--
2.15.0.194.g9af6a3dea062
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH 14/15] arm: dts: qcom: Add missing OPP properties for CPUs
2018-05-25 10:32 ` [PATCH 14/15] arm: dts: qcom: Add missing OPP properties for CPUs Viresh Kumar
@ 2018-07-18 6:08 ` Viresh Kumar
2018-07-18 10:22 ` Amit Kucheria
1 sibling, 0 replies; 5+ messages in thread
From: Viresh Kumar @ 2018-07-18 6:08 UTC (permalink / raw)
To: arm, Andy Gross, David Brown, Rob Herring, Mark Rutland
Cc: Vincent Guittot, ionela.voinescu, Daniel Lezcano, chris.redpath,
linux-arm-msm, linux-soc, devicetree, linux-kernel
On 25-05-18, 16:02, Viresh Kumar wrote:
> The OPP properties, like "operating-points", should either be present
> for all the CPUs of a cluster or none. If these are present only for a
> subset of CPUs of a cluster then things will start falling apart as soon
> as the CPUs are brought online in a different order. For example, this
> will happen because the operating system looks for such properties in
> the CPU node it is trying to bring up, so that it can create an OPP
> table.
>
> Add such missing properties.
>
> Fix other missing property (clock latency) as well to make it all
> work.
>
> Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
> ---
> arch/arm/boot/dts/qcom-ipq4019.dtsi | 24 ++++++++++++++++++++++++
> 1 file changed, 24 insertions(+)
Qcom maintainers, can you please apply this one ?
--
viresh
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 14/15] arm: dts: qcom: Add missing OPP properties for CPUs
2018-05-25 10:32 ` [PATCH 14/15] arm: dts: qcom: Add missing OPP properties for CPUs Viresh Kumar
2018-07-18 6:08 ` Viresh Kumar
@ 2018-07-18 10:22 ` Amit Kucheria
2018-07-21 18:56 ` Andy Gross
1 sibling, 1 reply; 5+ messages in thread
From: Amit Kucheria @ 2018-07-18 10:22 UTC (permalink / raw)
To: Viresh Kumar
Cc: arm, Andy Gross, David Brown, Rob Herring, Mark Rutland,
Vincent Guittot, ionela.voinescu, Daniel Lezcano, chris.redpath,
linux-arm-msm, open list:ARM/QUALCOMM SUPPORT,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS, LKML
On Fri, May 25, 2018 at 4:02 PM, Viresh Kumar <viresh.kumar@linaro.org> wrote:
> The OPP properties, like "operating-points", should either be present
> for all the CPUs of a cluster or none. If these are present only for a
> subset of CPUs of a cluster then things will start falling apart as soon
> as the CPUs are brought online in a different order. For example, this
> will happen because the operating system looks for such properties in
> the CPU node it is trying to bring up, so that it can create an OPP
> table.
>
> Add such missing properties.
>
> Fix other missing property (clock latency) as well to make it all
> work.
>
> Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
FWIW,
Reviewed-by: Amit Kucheria <amit.kucheria@linaro.org>
> ---
> arch/arm/boot/dts/qcom-ipq4019.dtsi | 24 ++++++++++++++++++++++++
> 1 file changed, 24 insertions(+)
>
> diff --git a/arch/arm/boot/dts/qcom-ipq4019.dtsi b/arch/arm/boot/dts/qcom-ipq4019.dtsi
> index b25daf368012..8c202b359270 100644
> --- a/arch/arm/boot/dts/qcom-ipq4019.dtsi
> +++ b/arch/arm/boot/dts/qcom-ipq4019.dtsi
> @@ -75,6 +75,14 @@
> reg = <0x1>;
> clocks = <&gcc GCC_APPS_CLK_SRC>;
> clock-frequency = <0>;
> + operating-points = <
> + /* kHz uV (fixed) */
> + 48000 1100000
> + 200000 1100000
> + 500000 1100000
> + 666000 1100000
> + >;
> + clock-latency = <256000>;
> };
>
> cpu@2 {
> @@ -86,6 +94,14 @@
> reg = <0x2>;
> clocks = <&gcc GCC_APPS_CLK_SRC>;
> clock-frequency = <0>;
> + operating-points = <
> + /* kHz uV (fixed) */
> + 48000 1100000
> + 200000 1100000
> + 500000 1100000
> + 666000 1100000
> + >;
> + clock-latency = <256000>;
> };
>
> cpu@3 {
> @@ -97,6 +113,14 @@
> reg = <0x3>;
> clocks = <&gcc GCC_APPS_CLK_SRC>;
> clock-frequency = <0>;
> + operating-points = <
> + /* kHz uV (fixed) */
> + 48000 1100000
> + 200000 1100000
> + 500000 1100000
> + 666000 1100000
> + >;
> + clock-latency = <256000>;
> };
> };
>
> --
> 2.15.0.194.g9af6a3dea062
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH 14/15] arm: dts: qcom: Add missing OPP properties for CPUs
2018-07-18 10:22 ` Amit Kucheria
@ 2018-07-21 18:56 ` Andy Gross
0 siblings, 0 replies; 5+ messages in thread
From: Andy Gross @ 2018-07-21 18:56 UTC (permalink / raw)
To: Amit Kucheria
Cc: Viresh Kumar, arm, David Brown, Rob Herring, Mark Rutland,
Vincent Guittot, ionela.voinescu, Daniel Lezcano, chris.redpath,
linux-arm-msm, open list:ARM/QUALCOMM SUPPORT,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS, LKML
On Wed, Jul 18, 2018 at 03:52:26PM +0530, Amit Kucheria wrote:
> On Fri, May 25, 2018 at 4:02 PM, Viresh Kumar <viresh.kumar@linaro.org> wrote:
> > The OPP properties, like "operating-points", should either be present
> > for all the CPUs of a cluster or none. If these are present only for a
> > subset of CPUs of a cluster then things will start falling apart as soon
> > as the CPUs are brought online in a different order. For example, this
> > will happen because the operating system looks for such properties in
> > the CPU node it is trying to bring up, so that it can create an OPP
> > table.
> >
> > Add such missing properties.
> >
> > Fix other missing property (clock latency) as well to make it all
> > work.
> >
> > Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
>
> FWIW,
> Reviewed-by: Amit Kucheria <amit.kucheria@linaro.org>
Picking this up for 4.19. thanks.
Andy
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2018-07-21 18:56 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-05-25 10:31 [PATCH 00/15] arm: dts: Fix OPP and cooling device properties Viresh Kumar
2018-05-25 10:32 ` [PATCH 14/15] arm: dts: qcom: Add missing OPP properties for CPUs Viresh Kumar
2018-07-18 6:08 ` Viresh Kumar
2018-07-18 10:22 ` Amit Kucheria
2018-07-21 18:56 ` Andy Gross
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).