From: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
To: andersson@kernel.org, Michael.Srba@seznam.cz,
konradybcio@kernel.org, jeffrey.l.hugo@gmail.com
Cc: linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org,
Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Subject: [PATCH 0/2] bus: qcom-ssc-block-bus: Fix some error handling paths
Date: Sun, 2 Mar 2025 17:21:33 +0100 [thread overview]
Message-ID: <cover.1740932040.git.christophe.jaillet@wanadoo.fr> (raw)
Patch 1 should be straight forward. It removes some ioumap() from
resources allocated with devm_ioremap_resource().
Patch 2 is more speculative. It releases some resources in the error
handling path of the probe, as done in the .remove() function.
Finally, the .remove() function also has some
pm_runtime_disable(&pdev->dev);
pm_clk_destroy(&pdev->dev);
calls.
Usually pm_runtime_disable() is paired with pm_runtime_enable() and I
would expect some pm_clk_add(() calls related to pm_clk_destroy().
Neither exists.
So I wonder if these 2 calls are correct in the .remove() function.
Thought?
Christophe JAILLET (2):
bus: qcom-ssc-block-bus: Remove some duplicated iounmap() calls
bus: qcom-ssc-block-bus: Fix the error handling path of
qcom_ssc_block_bus_probe()
drivers/bus/qcom-ssc-block-bus.c | 34 ++++++++++++++++++--------------
1 file changed, 19 insertions(+), 15 deletions(-)
--
2.48.1
next reply other threads:[~2025-03-02 16:23 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-02 16:21 Christophe JAILLET [this message]
2025-03-02 16:21 ` [PATCH 1/2] bus: qcom-ssc-block-bus: Remove some duplicated iounmap() calls Christophe JAILLET
2025-03-02 18:43 ` Dmitry Baryshkov
2025-03-02 16:21 ` [PATCH 2/2] bus: qcom-ssc-block-bus: Fix the error handling path of qcom_ssc_block_bus_probe() Christophe JAILLET
2025-03-02 17:46 ` Michael Srba
2025-03-14 20:00 ` [PATCH 0/2] bus: qcom-ssc-block-bus: Fix some error handling paths Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1740932040.git.christophe.jaillet@wanadoo.fr \
--to=christophe.jaillet@wanadoo.fr \
--cc=Michael.Srba@seznam.cz \
--cc=andersson@kernel.org \
--cc=jeffrey.l.hugo@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=konradybcio@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox