From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7770DC0032E for ; Wed, 25 Oct 2023 09:18:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229537AbjJYJS2 (ORCPT ); Wed, 25 Oct 2023 05:18:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42534 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232291AbjJYJS1 (ORCPT ); Wed, 25 Oct 2023 05:18:27 -0400 Received: from mail-lf1-x12e.google.com (mail-lf1-x12e.google.com [IPv6:2a00:1450:4864:20::12e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9C14A12D for ; Wed, 25 Oct 2023 02:18:24 -0700 (PDT) Received: by mail-lf1-x12e.google.com with SMTP id 2adb3069b0e04-507cee17b00so7976838e87.2 for ; Wed, 25 Oct 2023 02:18:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1698225503; x=1698830303; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=BAHJikpep9ynpiLuY3eXxwOgPXKE7wTHSFE/9ZFm21A=; b=bRT28XsLgswaqZEF4ilV0xXxuzoFkSdowsODyRo4sNDxCUM4JRJzFZU/NBT0wLzk3s 3IIcn5mnJ9KIf1AzV8/jWonC6sK059gxMWlAuC1G6XKbGNkHJof74IWhxOJX4HtEM36y dtlRNQFQ51ppRbqomBh32eDWmOhlODtdiqMAtwo3gKi3KOZu03afBdeuHs5b1MAXxegQ RuMlu6b5G8d2EJ4IbU0vBsXPlUv5QrwTCpQDmXuZArHzZk0c19ZZPte6pGONndVwxxfo 0e4hk8cKGqh/xtXDaQdloq2BkQyqBvoR9j+VGU7haqiRwMMflu/R+05FihxlAFfpxPsj aETw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1698225503; x=1698830303; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=BAHJikpep9ynpiLuY3eXxwOgPXKE7wTHSFE/9ZFm21A=; b=JTD9WSA8EU0pl2qlnqD70/cCBygxLSbRM8tuua/sbDZWy7gsEhnkPJV21nijfxp5Oi tI266J7Fzl55LNbLe7BSBa1a86J72/Icidb8Ya9laAJi+CVNzU0Ehuv3l3nT8FRxzScB uP3u3lCVmsoevPkNEtPFqLkmEcHCKBQg3c/OnSpJ3EgZZgXb1lEEZlhsK1mIXgiAKAXg 08vruz7nUP/bG+1Hk9B1Wa/plY+bxIM7nqlMbqw4ID3Smx2h2+tpUPSiaINWZQDLA6ua wsyDZI8zYsM0XbLTJZWJWG5zKKUud6yF6BghmyjdilIGIXH1m8yA4cCcePBiPqSAK1Ds tWFw== X-Gm-Message-State: AOJu0YwLVXE1UYMAoLXaGtktVcQbx1vbFRMhDeFl8giPNaOLJqP2KwJq KxjV3qfWIuABnVb8e700+OBi4Q== X-Google-Smtp-Source: AGHT+IGm96vi+l1CKUKEFUw2b075VE/cmmy09HWIJtcYPHTWh4c621SNC0JpC+WCWMSyx9UpnDQJaA== X-Received: by 2002:a05:6512:3085:b0:4fb:8939:d95c with SMTP id z5-20020a056512308500b004fb8939d95cmr12502304lfd.30.1698225502780; Wed, 25 Oct 2023 02:18:22 -0700 (PDT) Received: from [172.30.204.57] (UNUSED.212-182-62-129.lubman.net.pl. [212.182.62.129]) by smtp.gmail.com with ESMTPSA id w4-20020a05651234c400b005057a5587f0sm2471866lfr.52.2023.10.25.02.18.21 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 25 Oct 2023 02:18:22 -0700 (PDT) Message-ID: Date: Wed, 25 Oct 2023 11:18:20 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/4] media: qcom: camss: Use common VFE pm_domain_on/pm_domain_off where applicable Content-Language: en-US To: Bryan O'Donoghue , hverkuil-cisco@xs4all.nl, laurent.pinchart@ideasonboard.com, rfoss@kernel.org, todor.too@gmail.com, agross@kernel.org, andersson@kernel.org, mchehab@kernel.org Cc: linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org References: <20231024224255.754779-1-bryan.odonoghue@linaro.org> <20231024224255.754779-3-bryan.odonoghue@linaro.org> From: Konrad Dybcio In-Reply-To: <20231024224255.754779-3-bryan.odonoghue@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On 10/25/23 00:42, Bryan O'Donoghue wrote: > For the various versions of VFE we have a boiler-plate > pm_domain_on/pm_domain_off callback pair of the general form. > > - Error check. > Not always done but applicable to all. > > - device_link_add (DL_FLAG_STATELESS | DL_FLAG_PM_RUNTIME | > DL_FLAG_RPM_ACTIVE); > > - Error check returning -EINVAL on error. > > - Return 0 > > Reduce the pattern down to a common callback. VFE 4.1 is a special case > which to me also indicates that it is worthwhile maintaining an indirection > for the vfe_pm_domain_{on|off} for now. Are there issues when powering it off like all the others? > > Otherwise lets chuck out a bunch of needlessly replicated code. > > Signed-off-by: Bryan O'Donoghue > --- Reviewed-by: Konrad Dybcio Konrad