Re: [PATCH 1/2] thermal/drivers/qcom/temp-alarm: register thermal zones as hwmon sensors

[Bhupesh Sharma <bhupesh.sharma@linaro.org>]

On 7/19/22 11:19 AM, Dmitry Baryshkov wrote:
> Register thermal zones as hwmon sensors to let userspace read
> temperatures using standard hwmon interface.
>
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> ---
>   drivers/thermal/qcom/qcom-spmi-temp-alarm.c | 5 +++++
>   1 file changed, 5 insertions(+)
>
> diff --git a/drivers/thermal/qcom/qcom-spmi-temp-alarm.c b/drivers/thermal/qcom/qcom-spmi-temp-alarm.c
> index 7419e196dbb0..770f82cc9bca 100644
> --- a/drivers/thermal/qcom/qcom-spmi-temp-alarm.c
> +++ b/drivers/thermal/qcom/qcom-spmi-temp-alarm.c
> @@ -16,6 +16,7 @@
>   #include <linux/thermal.h>
>   
>   #include "../thermal_core.h"
> +#include "../thermal_hwmon.h"
>   
>   #define QPNP_TM_REG_DIG_MAJOR		0x01
>   #define QPNP_TM_REG_TYPE		0x04
> @@ -458,6 +459,10 @@ static int qpnp_tm_probe(struct platform_device *pdev)
>   		return ret;
>   	}
>   
> +	if (devm_thermal_add_hwmon_sysfs(chip->tz_dev))
> +		dev_warn(&pdev->dev,
> +			 "Failed to add hwmon sysfs attributes\n");
> +
>   	ret = devm_request_threaded_irq(&pdev->dev, irq, NULL, qpnp_tm_isr,
>   					IRQF_ONESHOT, node->name, chip);
>   	if (ret < 0)

LGTM, so:

Reviewed-by: Bhupesh Sharma <bhupesh.sharma@linaro.org>