Re: [PATCH v3 05/12] soc: qcom: geni-se: Introduce helper API for attaching power domains

[Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>]

On 1/12/26 11:47 AM, Praveen Talari wrote:
> The GENI Serial Engine drivers (I2C, SPI, and SERIAL) currently handle
> the attachment of power domains. This often leads to duplicated code
> logic across different driver probe functions.
> 
> Introduce a new helper API, geni_se_domain_attach(), to centralize
> the logic for attaching "power" and "perf" domains to the GENI SE
> device.
> 
> Signed-off-by: Praveen Talari <praveen.talari@oss.qualcomm.com>
> ---

[...]

> +/**
> + * geni_se_domain_attach() - Attach power domains to a GENI SE device.
> + * @se: Pointer to the geni_se structure representing the GENI SE device.
> + *
> + * This function attaches the necessary power domains ("power" and "perf")
> + * to the GENI Serial Engine device. It initializes `se->pd_list` with the
> + * attached domains.

Please sprinkle somewhere into this kerneldoc that this is specifically
for the SCMI-auto-VM setup, otherwise "the necessary power domains"
is at best confusing to an external reader

Konrad