From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f51.google.com (mail-wm1-f51.google.com [209.85.128.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EA0221891D6 for ; Mon, 15 Jul 2024 13:02:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1721048522; cv=none; b=Y6De5stSQqzWej3CTvZXZOGNE1FLioONsf+ij9fajYN4QBQcQjqxoVUXK45gHOY1SL6dqrYHjB4RFKZ2SbWLppC4KrxQYQXKCrZZV+ecuEoitKrsbiLHkcZXu5iRHPpqDKadDHb2liXU9bzZ7HJvt3YG9c2IgMSYmdzN6aLeY3M= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1721048522; c=relaxed/simple; bh=vuEK/YXbfD7q80x82cWalZ5+kfSToUf5IA4mSEXYqEw=; h=Message-ID:Date:MIME-Version:From:Subject:To:Cc:References: In-Reply-To:Content-Type; b=h6taLHtRS5w/L+nHeT9pFg8AAQP8jLV8W72XkI9NRLVdKBdoc3hwwUs0+UIl5cX85Nh8Op4HIbvHlYez9xKQDH5Ms7m8/MqFuvdmzM2Xjqc9ogfWAY1WpvmTPEjUoi9WCVPPnbOW2ALscViQtbES7mpyYysdK0ViqwP8aH2Fcuo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=JBjUMt6K; arc=none smtp.client-ip=209.85.128.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="JBjUMt6K" Received: by mail-wm1-f51.google.com with SMTP id 5b1f17b1804b1-4267345e746so28572055e9.0 for ; Mon, 15 Jul 2024 06:02:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1721048519; x=1721653319; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:subject:reply-to:from:user-agent :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to; bh=h0LlF0jvPcioawKxnI/v8jmryUdPpTWQ5f+aNVMOx1M=; b=JBjUMt6KNW8UehZlr5BomtOOCg4trxHhz+uFfxyBGnkUEzvnK0WrulgNINLqejxF5z 3wkSIss60xN30SnWgvR+it8ILkg4W831utZrEHtlOmGv3YiooEjlE5RcFOBJwnQ37/pO JYTfwzxhXT4e7qzIr8ZsdvWuPN1nJ0FyZSDYBvvW35weUD/RC+/jo94Nvz6bJ0quC0hA 6MOVz195TSvFQIBnrzd56Er/DbyS2fPQ24fpIL0ZY/5+d4uMfgDk4VbMUWf63RNADSOf v7QzzLy/hi0jdj1VYRIvSSz5EPr3LtYhxb4TrLoIyd2RlK7rL7UZrzqwU4cqzfwOsx2H mUZg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1721048519; x=1721653319; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:subject:reply-to:from:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=h0LlF0jvPcioawKxnI/v8jmryUdPpTWQ5f+aNVMOx1M=; b=UZC0pNlVVjGgc/2QYWAEyfXNijIf8yZss0foUaurUv41ZQOviQqz81gdsNjdtdeVKz oTZm1GhNyph1DxQc/YfhaFPJnACdGtC6shlRFXr+S7fR2e3Ya4/ULuyd5HHuldUALg8A LBA/HXnPK/WtnAeKbyU+439qxY8lNyW1/o0T2hJduZcieaj5lJrPrsLOqtoBTGRSzfJC fprEU/WYv5yIONKvEOC6/4X9bfrQBU7Pdidk7PmkImGvY/cwch8J0joGEYjuoz17hxeh hyPdGaFTHvidRuoxzS9+z9Guv3DIYiGHlpx7LnMPoco7d+0OYSHy/jU8veZohbQekKuC 5Vgw== X-Forwarded-Encrypted: i=1; AJvYcCUHjnpIxPzBMuQ4gYz6TVANHUyO/fCAmOMnzs9sNwbjX9fOemk0gY4Z28/A7V+ZOQ21Y8d/RAEugwQd4zIQERMeEzUGFiW1UUC3dFk0vA== X-Gm-Message-State: AOJu0Yya/jjy09J4evbRoBpH2tAdD4vhPOE5QZ0PE3pO39FkBEyRx3/e TOpOofTzOz2jG/ZB7jDZ0RltBT8lKE6iUpcw5BFfPCT3hm2rzi9P176N5YIixgw= X-Google-Smtp-Source: AGHT+IEDCShUNSMDpb8ubvYx9FNbleT++Anmmj4DRHcb11LRI9IkeO1lUMjxu9JiIw8MJ5eeP5Xkrw== X-Received: by 2002:a5d:64a6:0:b0:367:8a68:e746 with SMTP id ffacd0b85a97d-367cea466aemr17051400f8f.6.1721048518903; Mon, 15 Jul 2024 06:01:58 -0700 (PDT) Received: from ?IPV6:2a01:e0a:982:cbb0:79bb:5f59:8e51:52d4? ([2a01:e0a:982:cbb0:79bb:5f59:8e51:52d4]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3680dab3c2dsm6438123f8f.1.2024.07.15.06.01.58 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 15 Jul 2024 06:01:58 -0700 (PDT) Message-ID: Date: Mon, 15 Jul 2024 15:01:57 +0200 Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: Neil Armstrong Reply-To: neil.armstrong@linaro.org Subject: Re: [PATCH v2 2/4] Revert "drm/panel-edp: Add SDC ATNA45AF01" To: Stephan Gerhold Cc: Bjorn Andersson , Konrad Dybcio , Jessica Zhang , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Douglas Anderson , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, Abel Vesa , Johan Hovold References: <20240715-x1e80100-crd-backlight-v2-0-31b7f2f658a3@linaro.org> <20240715-x1e80100-crd-backlight-v2-2-31b7f2f658a3@linaro.org> <7daa3c0d-cecf-4f50-be32-ae116b920db0@linaro.org> Content-Language: en-US, fr Autocrypt: addr=neil.armstrong@linaro.org; keydata= xsBNBE1ZBs8BCAD78xVLsXPwV/2qQx2FaO/7mhWL0Qodw8UcQJnkrWmgTFRobtTWxuRx8WWP GTjuhvbleoQ5Cxjr+v+1ARGCH46MxFP5DwauzPekwJUD5QKZlaw/bURTLmS2id5wWi3lqVH4 BVF2WzvGyyeV1o4RTCYDnZ9VLLylJ9bneEaIs/7cjCEbipGGFlfIML3sfqnIvMAxIMZrvcl9 qPV2k+KQ7q+aXavU5W+yLNn7QtXUB530Zlk/d2ETgzQ5FLYYnUDAaRl+8JUTjc0CNOTpCeik 80TZcE6f8M76Xa6yU8VcNko94Ck7iB4vj70q76P/J7kt98hklrr85/3NU3oti3nrIHmHABEB AAHNKk5laWwgQXJtc3Ryb25nIDxuZWlsLmFybXN0cm9uZ0BsaW5hcm8ub3JnPsLAkQQTAQoA OwIbIwULCQgHAwUVCgkICwUWAgMBAAIeAQIXgBYhBInsPQWERiF0UPIoSBaat7Gkz/iuBQJk Q5wSAhkBAAoJEBaat7Gkz/iuyhMIANiD94qDtUTJRfEW6GwXmtKWwl/mvqQtaTtZID2dos04 YqBbshiJbejgVJjy+HODcNUIKBB3PSLaln4ltdsV73SBcwUNdzebfKspAQunCM22Mn6FBIxQ GizsMLcP/0FX4en9NaKGfK6ZdKK6kN1GR9YffMJd2P08EO8mHowmSRe/ExAODhAs9W7XXExw UNCY4pVJyRPpEhv373vvff60bHxc1k/FF9WaPscMt7hlkbFLUs85kHtQAmr8pV5Hy9ezsSRa GzJmiVclkPc2BY592IGBXRDQ38urXeM4nfhhvqA50b/nAEXc6FzqgXqDkEIwR66/Gbp0t3+r yQzpKRyQif3OwE0ETVkGzwEIALyKDN/OGURaHBVzwjgYq+ZtifvekdrSNl8TIDH8g1xicBYp QTbPn6bbSZbdvfeQPNCcD4/EhXZuhQXMcoJsQQQnO4vwVULmPGgtGf8PVc7dxKOeta+qUh6+ SRh3vIcAUFHDT3f/Zdspz+e2E0hPV2hiSvICLk11qO6cyJE13zeNFoeY3ggrKY+IzbFomIZY 4yG6xI99NIPEVE9lNBXBKIlewIyVlkOaYvJWSV+p5gdJXOvScNN1epm5YHmf9aE2ZjnqZGoM Mtsyw18YoX9BqMFInxqYQQ3j/HpVgTSvmo5ea5qQDDUaCsaTf8UeDcwYOtgI8iL4oHcsGtUX oUk33HEAEQEAAcLAXwQYAQIACQUCTVkGzwIbDAAKCRAWmrexpM/4rrXiB/sGbkQ6itMrAIfn M7IbRuiSZS1unlySUVYu3SD6YBYnNi3G5EpbwfBNuT3H8//rVvtOFK4OD8cRYkxXRQmTvqa3 3eDIHu/zr1HMKErm+2SD6PO9umRef8V82o2oaCLvf4WeIssFjwB0b6a12opuRP7yo3E3gTCS KmbUuLv1CtxKQF+fUV1cVaTPMyT25Od+RC1K+iOR0F54oUJvJeq7fUzbn/KdlhA8XPGzwGRy 4zcsPWvwnXgfe5tk680fEKZVwOZKIEuJC3v+/yZpQzDvGYJvbyix0lHnrCzq43WefRHI5XTT QbM0WUIBIcGmq38+OgUsMYu4NzLu7uZFAcmp6h8g Organization: Linaro In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 15/07/2024 14:54, Stephan Gerhold wrote: > On Mon, Jul 15, 2024 at 02:42:12PM +0200, Neil Armstrong wrote: >> On 15/07/2024 14:15, Stephan Gerhold wrote: >>> This reverts commit 8ebb1fc2e69ab8b89a425e402c7bd85e053b7b01. >>> >>> The panel should be handled through the samsung-atna33xc20 driver for >>> correct power up timings. Otherwise the backlight does not work correctly. >>> >>> We have existing users of this panel through the generic "edp-panel" >>> compatible (e.g. the Qualcomm X1E80100 CRD), but the screen works only >>> partially in that configuration: It works after boot but once the screen >>> gets disabled it does not turn on again until after reboot. It behaves the >>> same way with the default "conservative" timings, so we might as well drop >>> the configuration from the panel-edp driver. That way, users with old DTBs >>> will get a warning and can move to the new driver. >>> >>> Reviewed-by: Douglas Anderson >>> Signed-off-by: Stephan Gerhold >>> --- >>> drivers/gpu/drm/panel/panel-edp.c | 2 -- >>> 1 file changed, 2 deletions(-) >>> >>> diff --git a/drivers/gpu/drm/panel/panel-edp.c b/drivers/gpu/drm/panel/panel-edp.c >>> index 3a574a9b46e7..d2d682385e89 100644 >>> --- a/drivers/gpu/drm/panel/panel-edp.c >>> +++ b/drivers/gpu/drm/panel/panel-edp.c >>> @@ -1960,8 +1960,6 @@ static const struct edp_panel_entry edp_panels[] = { >>> EDP_PANEL_ENTRY('L', 'G', 'D', 0x05af, &delay_200_500_e200_d200, "Unknown"), >>> EDP_PANEL_ENTRY('L', 'G', 'D', 0x05f1, &delay_200_500_e200_d200, "Unknown"), >>> - EDP_PANEL_ENTRY('S', 'D', 'C', 0x416d, &delay_100_500_e200, "ATNA45AF01"), >>> - >>> EDP_PANEL_ENTRY('S', 'H', 'P', 0x1511, &delay_200_500_e50, "LQ140M1JW48"), >>> EDP_PANEL_ENTRY('S', 'H', 'P', 0x1523, &delay_80_500_e50, "LQ140M1JW46"), >>> EDP_PANEL_ENTRY('S', 'H', 'P', 0x153a, &delay_200_500_e50, "LQ140T1JH01"), >>> >> >> How will we handle current/old crd DT with new kernels ? >> > > I think this is answered in the commit message: > >>> We have existing users of this panel through the generic "edp-panel" >>> compatible (e.g. the Qualcomm X1E80100 CRD), but the screen works only >>> partially in that configuration: It works after boot but once the screen >>> gets disabled it does not turn on again until after reboot. It behaves the >>> same way with the default "conservative" timings, so we might as well drop >>> the configuration from the panel-edp driver. That way, users with old DTBs >>> will get a warning and can move to the new driver. > > Basically with the entry removed, the panel-edp driver will fallback to > default "conservative" timings when using old DTBs. There will be a > warning in dmesg, but otherwise the panel will somewhat work just as > before. I think this is a good way to remind users to upgrade. I consider this as a regression > >> Same question for patch 3, thie serie introduces a bindings that won't be valid >> if we backport patch 3. I don't think patch should be backported, and this patch >> should be dropped. > > There would be a dtbs_check warning, yeah. Functionally, it would work > just fine. Is that reason enough to keep display partially broken for > 6.11? We could also apply the minor binding change for 6.11 if needed. I don't know how to answer this, I'll let the DT maintainer comment this. The problem is I do not think we can pass the whole patchset as fixes for v6.11, patches 2 & 3 could, patches 1 & 4 definitely can't. Neil > > I'm also fine if this just goes into 6.12 though. > > Thanks, > Stephan