From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 38A29C6FD1D for ; Thu, 23 Mar 2023 14:45:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231741AbjCWOpw (ORCPT ); Thu, 23 Mar 2023 10:45:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44372 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231834AbjCWOpp (ORCPT ); Thu, 23 Mar 2023 10:45:45 -0400 Received: from mail-wr1-x431.google.com (mail-wr1-x431.google.com [IPv6:2a00:1450:4864:20::431]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 72471252B9 for ; Thu, 23 Mar 2023 07:45:23 -0700 (PDT) Received: by mail-wr1-x431.google.com with SMTP id e18so9254971wra.9 for ; Thu, 23 Mar 2023 07:45:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1679582722; h=content-transfer-encoding:in-reply-to:organization:references:cc:to :content-language:subject:reply-to:from:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=W4MzrlpTb4Yhk+gf2dIUjuh7tsdX9/TNDTntW+YKJvQ=; b=VNwqpfZrV6vnFmwiRhLKz9jY1Ib2cmBxdbakZRZrHeSHzA9AKpPVstW5bUCEJCE5Dq Rprv/C1AYM3gKWrk0hpsmQZpmZMTCBD5Mhd9nkaP6QHffhntf1hkEhmDTI6s/SXZSxho 6jRUFnSso3D7ypelnHOflwy+xoxZSJo9rcG8mUvDwqMVtb16X1CfTci70fPpd0d5ZMYg dv8C2R78hJroZ7ldiETHkKLa9e9Nxxtq0/XEz3SwiugYytzGgyfvtKgcBNCc6kWgnOiD KFOtM5WsAYQPvBIsypLEo1OkcmcV1YT/tc0KBwnXhEv9vzn1JPdiWBxzk9AgQTm/NQcg pncw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679582722; h=content-transfer-encoding:in-reply-to:organization:references:cc:to :content-language:subject:reply-to:from:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=W4MzrlpTb4Yhk+gf2dIUjuh7tsdX9/TNDTntW+YKJvQ=; b=qS0+qfxwgrbObcwkyF+P9RcBChAAKN4HA3WoGRNMgJzo8NvvOVtz5cI/U6k0ODNjx2 Kd9t1jWkNKLKHZYVH//TarpUbwCPpfjQs0PtzKYLAIZivaHOnkG51Z+FajzhIn97L3nU rDVBFq6FZc1GU424J7vlFE080bRMif5muqP2e+NRYV3Hh04EQpbtg3GyOU0gYPmxGyke Miq/uEKw/DEQIvZHwe1m201XC4vYxleEFGPXf09xmlpU1qPfFeNCDz8Z8itmjih21/as DFrhRw8YjW4JZqbqG0A7704NeAWjEo9KgrlUrueq9sqQmNTU7QLF6AzjCs7XfDIohFC3 94JQ== X-Gm-Message-State: AAQBX9drbkez89+gWBcNlzAu/lTqfIMvMQ0EIC+SlCNx0J3uspU0zhMt FKx3Ic1n6cyr68iR/RUE7zeEFA== X-Google-Smtp-Source: AKy350YwaJwmjXC3UxTKUTSA0ajmbVXL4atAUE52yKdngL+u+dc4euwmiy4LP0GSK7l3dnIU6r4mCw== X-Received: by 2002:a5d:4d82:0:b0:2db:11f3:f7ee with SMTP id b2-20020a5d4d82000000b002db11f3f7eemr2473114wru.63.1679582721738; Thu, 23 Mar 2023 07:45:21 -0700 (PDT) Received: from ?IPV6:2a01:e0a:982:cbb0:e25a:65de:379a:3899? ([2a01:e0a:982:cbb0:e25a:65de:379a:3899]) by smtp.gmail.com with ESMTPSA id p7-20020a1c5447000000b003dd1bd0b915sm2121364wmi.22.2023.03.23.07.45.20 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 23 Mar 2023 07:45:21 -0700 (PDT) Message-ID: Date: Thu, 23 Mar 2023 15:45:19 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 From: Neil Armstrong Reply-To: neil.armstrong@linaro.org Subject: Re: [PATCH 3/8] dt-bindings: ufs: qcom: document the fact the UFS controller can have an ICE core Content-Language: en-US To: Rob Herring Cc: Stephen Boyd , linux-arm-msm@vger.kernel.org, Manivannan Sadhasivam , devicetree@vger.kernel.org, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, Konrad Dybcio , Bjorn Andersson , Avri Altman , Sean Paul , dri-devel@lists.freedesktop.org, Abhinav Kumar , Krzysztof Kozlowski , Bart Van Assche , Lee Jones , Rob Clark , Rob Herring , Daniel Vetter , Krzysztof Kozlowski , Andy Gross , David Airlie , Dmitry Baryshkov , Alim Akhtar , freedreno@lists.freedesktop.org References: <20230323-topic-sm8450-upstream-dt-bindings-fixes-v1-0-3ead1e418fe4@linaro.org> <20230323-topic-sm8450-upstream-dt-bindings-fixes-v1-3-3ead1e418fe4@linaro.org> <167957963115.3095299.4593054829506617284.robh@kernel.org> Organization: Linaro Developer Services In-Reply-To: <167957963115.3095299.4593054829506617284.robh@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On 23/03/2023 14:58, Rob Herring wrote: > > On Thu, 23 Mar 2023 11:25:18 +0100, Neil Armstrong wrote: >> Move the qcom,sm8450-ufshc to the right allOf:if allowing the ICE clocks >> and registers to be specified. >> >> Fixes: 462c5c0aa798 ("dt-bindings: ufs: qcom,ufs: convert to dtschema") >> Signed-off-by: Neil Armstrong >> --- >> Documentation/devicetree/bindings/ufs/qcom,ufs.yaml | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> > > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' > on your patch (DT_CHECKER_FLAGS is new in v5.13): > > yamllint warnings/errors: > > dtschema/dtc warnings/errors: > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/ufs/qcom,ufs.example.dtb: ufs@1d84000: clocks: [[4294967295, 151], [4294967295, 10], [4294967295, 150], [4294967295, 166], [4294967295, 0], [4294967295, 164], [4294967295, 160], [4294967295, 162]] is too short > From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/ufs/qcom,ufs.example.dtb: ufs@1d84000: clock-names: ['core_clk', 'bus_aggr_clk', 'iface_clk', 'core_clk_unipro', 'ref_clk', 'tx_lane0_sync_clk', 'rx_lane0_sync_clk', 'rx_lane1_sync_clk'] is too short > From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/ufs/qcom,ufs.example.dtb: ufs@1d84000: reg: [[0, 30949376, 0, 12288]] is too short > From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml Same as patch 1, I forgot to fix the example... Neil > > doc reference errors (make refcheckdocs): > > See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20230323-topic-sm8450-upstream-dt-bindings-fixes-v1-3-3ead1e418fe4@linaro.org > > The base for the series is generally the latest rc1. A different dependency > should be noted in *this* patch. > > If you already ran 'make dt_binding_check' and didn't see the above > error(s), then make sure 'yamllint' is installed and dt-schema is up to > date: > > pip3 install dtschema --upgrade > > Please check and re-submit after running the above command yourself. Note > that DT_SCHEMA_FILES can be set to your schema file to speed up checking > your schema. However, it must be unset to test all examples with your schema. >