From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f46.google.com (mail-wm1-f46.google.com [209.85.128.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D85387C082 for ; Mon, 4 Mar 2024 22:53:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709592787; cv=none; b=jhZbRFH3hSA1d2RirXF6rYWN2CLdHg8piZz1+nFIU1/GW8ttXIKkCZ4QjnI14npnoJ0huVkeq8xoNUwo0qL+YsSNAiGTVc4xEHWqKVRgsE+hyrcqUrgX2FvR9HzA1RNJ+vC/GZx5Zt/J97/qDMjlDzO5xBTB2b6EkuMHI4pO5E0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709592787; c=relaxed/simple; bh=uOmNJyftoQiWMBwtZjjEk5oazk42oiXZB0+69cEngE4=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=MyQ9pBmVyJ+99BqIh7B7Gn7sZ0yE98+/f4K91z3viboQHmg7ek0ccyDK5NAI4FhWQp1/NZk2bhumxWNErpnKbP7jI3+NtgHFNEJeAl+vkq8acNO3gKT4CZurunpCX3JlACSNU5UA2vUpQs+KoNuG40O/zWAYdyf1T/iodvPFIeA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=fSDidsuR; arc=none smtp.client-ip=209.85.128.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="fSDidsuR" Received: by mail-wm1-f46.google.com with SMTP id 5b1f17b1804b1-412ecd24e84so190795e9.0 for ; Mon, 04 Mar 2024 14:53:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1709592783; x=1710197583; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=btWynTf3xFFc3JW3PLqmWTjuLdoAa7Aj4yAc6WIdAsM=; b=fSDidsuRb/fJIChlTqzSZiqzRASaUAjwx66r8Wtd3lt6Xr4vrhfMtYjzE1XLiQRm5I Juk8U65YTFVeJTmrJ3CIbsUVwJXp75fxp5BSG9cRGHWT4QXoVpWlgUJcCPwk0fdTodnd PyzniKmtxh5ezNjpOU5TmOmM/fTukigihkDz+Oz7WiWXwCzon02CgjLgdm9E+cQ+o+hB v0Gto+5ag/YH7U2vGP8C3T1gkGeBCPwe1XNpDo8unGPXLZJmryfYd8MhOVHPl+S906cC TDJCWZIW5fGWxpCg+3c709bvw+ShpGzrBhL22ALht/DCoVcssYPqz+fjdMVUf3wiiDBk UaYg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709592783; x=1710197583; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=btWynTf3xFFc3JW3PLqmWTjuLdoAa7Aj4yAc6WIdAsM=; b=kOQ10mLuh0MJWZmw9ykFVUFZ/G2tij5V/0mVwsOz+9lcoPJhEVI9qJDEszCTvLp0lF 1M7CcLl26+5mQMqUQlOosXdtGbJrfJwrBFMxHOmmW9IXmM6er6yxIM58NIhM0hwLifce EkPvknFOkrn77Mi4uxwZy45u3LxlS1hrcTwKFkjh9LgrQrPX2+Kvp35uboIHl5xFSvPP LgEdPVYSj2pLWsPJCvvqlUt7YctisyNrzPwoe8rKj9ccMxR5NVmxW6Eqm5qkgJ7vsj6F AyxS6n2c5l3kx6OrWeVLrb+e/7B997/iAjbEKhvbPD1tlOM6unrKH0OAOwW5rqWjlZX7 Sc0w== X-Forwarded-Encrypted: i=1; AJvYcCW6ysS+22Yb8NfjyfP9Pm+B7wVpV3R9ufIsFn+5c+clsrByBr5gTowoqc2kHc+h9Qxd58xDuX00WhR0CdZThQH11U02he8Yqa6rg/n3jw== X-Gm-Message-State: AOJu0YynB0xqnBR/KJOPNlsKlZDd+nclL+gcbGVLqAknKKOUy1Sxxtob 5SqWgdQ0+ae58wkGvL5cEVcjiApbfoTkXk58jsthyjBSnBhmJKq+kHB+qJlrnO8= X-Google-Smtp-Source: AGHT+IFuHz8KuYiUldcamRZfnck6yCpPU0D3qbH8MnGNSebMlrRChLNBuPmNutjEvsdtyjLBHd+6Xw== X-Received: by 2002:a05:600c:4e8e:b0:412:de1f:dd23 with SMTP id f14-20020a05600c4e8e00b00412de1fdd23mr3813219wmq.7.1709592783279; Mon, 04 Mar 2024 14:53:03 -0800 (PST) Received: from [10.66.66.2] (9.ip-51-91-159.eu. [51.91.159.9]) by smtp.gmail.com with ESMTPSA id bi7-20020a05600c3d8700b00412e5f876adsm3186236wmb.3.2024.03.04.14.53.00 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 04 Mar 2024 14:53:02 -0800 (PST) Message-ID: Date: Mon, 4 Mar 2024 23:52:58 +0100 Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 14/20] media: venus: pm_helpers: Remove pm_ops->core_put To: Dikshita Agarwal , Stanimir Varbanov , Vikash Garodia , Bryan O'Donoghue , Andy Gross , Bjorn Andersson , Mauro Carvalho Chehab , Philipp Zabel Cc: Marijn Suijten , Stanimir Varbanov , Mauro Carvalho Chehab , linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Dmitry Baryshkov References: <20230911-topic-mars-v2-0-3dac84b88c4b@linaro.org> <20230911-topic-mars-v2-14-3dac84b88c4b@linaro.org> Content-Language: en-US From: Konrad Dybcio In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 3/4/24 07:57, Dikshita Agarwal wrote: > > > On 2/10/2024 2:39 AM, Konrad Dybcio wrote: >> Without an OPP table and with vcodec_pmdomains_num (so, v1, v3 and >> sdm845_legacy targets), core_put_v4 is a NOP, jut like core_put_v1. >> Unify them! >> >> Signed-off-by: Konrad Dybcio >> --- [...] >> -static void vcodec_domains_put(struct venus_core *core) >> +void vcodec_domains_put(struct venus_core *core) >> { >> dev_pm_domain_detach_list(core->pmdomains); >> > what is the base of this change? > I don't see dev_pm_domain_detach_list in mainline code. > Am I missing anything here? The base is specified in the cover letter. The code in question is indeed here since January, perhaps you're looking at something older than -next. Konrad