From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
To: Udit Tiwari <quic_utiwari@quicinc.com>,
herbert@gondor.apana.org.au, thara.gopinath@gmail.com,
davem@davemloft.net
Cc: linux-crypto@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-kernel@vger.kernel.org, quic_neersoni@quicinc.com,
quic_kuldsing@quicinc.com
Subject: Re: [PATCH v6] crypto: qce - Add runtime PM and interconnect bandwidth scaling support
Date: Wed, 18 Feb 2026 12:12:50 +0100 [thread overview]
Message-ID: <d1adf3a9-3786-4fea-933f-e3df125a408b@oss.qualcomm.com> (raw)
In-Reply-To: <f4e1b449-9fb8-400c-ace9-bfb6b967bb13@quicinc.com>
On 2/18/26 7:02 AM, Udit Tiwari wrote:
> Hi Konrad,
>
> Thanks for pointing this out.
>
> I agree with your points regarding the usage of the ACQUIRE guard in probe to simplify the error paths, as well as the redundancy of icc_enable in the resume path. I will address both in the next version.
>
> While preparing the fix, I performed a self-review and noticed a potential issue. Since I am providing my own custom functions for runtime suspend/resume (to handle the ICC path), the standard clock helpers are no longer called automatically by the PM framework.
>
> I believe I need to manually call pm_clk_resume(dev) and pm_clk_suspend(dev) inside my custom functions to ensure the clocks are actually gated and ungated.
>
> Does this look correct to you? If you agree, I will include this fix in v7.
I tried to find an answer, but it seems like one of these situations where
it's easier to add some debug prints than to analyze the code ;)
Konrad
prev parent reply other threads:[~2026-02-18 11:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-10 6:14 [PATCH v6] crypto: qce - Add runtime PM and interconnect bandwidth scaling support quic_utiwari
2026-02-17 10:42 ` Konrad Dybcio
2026-02-18 6:02 ` Udit Tiwari
2026-02-18 11:12 ` Konrad Dybcio [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d1adf3a9-3786-4fea-933f-e3df125a408b@oss.qualcomm.com \
--to=konrad.dybcio@oss.qualcomm.com \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=quic_kuldsing@quicinc.com \
--cc=quic_neersoni@quicinc.com \
--cc=quic_utiwari@quicinc.com \
--cc=thara.gopinath@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox