[PATCH 0/2] dt-bindings: thermal: qcom-spmi-adc-tm5/hc: fix up examples

[PATCH 0/2] dt-bindings: thermal: qcom-spmi-adc-tm5/hc: fix up examples

[Johan Hovold]

When reviewing the various SPMI PMIC bindings, I noticed that several
examples were incorrect and misleading and could also use some cleanup.

This series addresses the thermal ones.

Johan


Johan Hovold (2):
  dt-bindings: thermal: qcom-spmi-adc-tm5/hc: fix example node names
  dt-bindings: thermal: qcom-spmi-adc-tm5/hc: clean up examples

 .../bindings/thermal/qcom-spmi-adc-tm-hc.yaml    |  8 +++++---
 .../bindings/thermal/qcom-spmi-adc-tm5.yaml      | 16 ++++++++++------
 2 files changed, 15 insertions(+), 9 deletions(-)

-- 
2.41.0

[PATCH 1/2] dt-bindings: thermal: qcom-spmi-adc-tm5/hc: fix example node names

[Johan Hovold]

The ADC Thermal Monitor is part of an SPMI PMIC, which in turn sits on
an SPMI bus.

Fixes: db03874b8543 ("dt-bindings: thermal: qcom: add HC variant of adc-thermal monitor bindings")
Fixes: e8ffd6c0756b ("dt-bindings: thermal: qcom: add adc-thermal monitor bindings")
Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
---
 .../devicetree/bindings/thermal/qcom-spmi-adc-tm-hc.yaml    | 3 ++-
 .../devicetree/bindings/thermal/qcom-spmi-adc-tm5.yaml      | 6 ++++--
 2 files changed, 6 insertions(+), 3 deletions(-)

diff --git a/Documentation/devicetree/bindings/thermal/qcom-spmi-adc-tm-hc.yaml b/Documentation/devicetree/bindings/thermal/qcom-spmi-adc-tm-hc.yaml
index 01253d58bf9f..82f8f25885c0 100644
--- a/Documentation/devicetree/bindings/thermal/qcom-spmi-adc-tm-hc.yaml
+++ b/Documentation/devicetree/bindings/thermal/qcom-spmi-adc-tm-hc.yaml
@@ -114,7 +114,8 @@ examples:
   - |
     #include <dt-bindings/iio/qcom,spmi-vadc.h>
     #include <dt-bindings/interrupt-controller/irq.h>
-    spmi_bus {
+
+    pmic {
         #address-cells = <1>;
         #size-cells = <0>;
         pm8998_adc: adc@3100 {
diff --git a/Documentation/devicetree/bindings/thermal/qcom-spmi-adc-tm5.yaml b/Documentation/devicetree/bindings/thermal/qcom-spmi-adc-tm5.yaml
index 3c81def03c84..02347cee6c6f 100644
--- a/Documentation/devicetree/bindings/thermal/qcom-spmi-adc-tm5.yaml
+++ b/Documentation/devicetree/bindings/thermal/qcom-spmi-adc-tm5.yaml
@@ -167,7 +167,8 @@ examples:
   - |
     #include <dt-bindings/iio/qcom,spmi-vadc.h>
     #include <dt-bindings/interrupt-controller/irq.h>
-    spmi_bus {
+
+    pmic {
         #address-cells = <1>;
         #size-cells = <0>;
         pm8150b_adc: adc@3100 {
@@ -207,7 +208,8 @@ examples:
     #include <dt-bindings/iio/qcom,spmi-adc7-pmk8350.h>
     #include <dt-bindings/iio/qcom,spmi-adc7-pm8350.h>
     #include <dt-bindings/interrupt-controller/irq.h>
-    spmi_bus {
+
+    pmic {
         #address-cells = <1>;
         #size-cells = <0>;
         pmk8350_vadc: adc@3100 {
-- 
2.41.0

[PATCH 2/2] dt-bindings: thermal: qcom-spmi-adc-tm5/hc: clean up examples

[Johan Hovold]

Clean up the examples by adding newline separators, moving 'reg'
properties after 'compatible' and dropping unused labels.

Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
---
 .../bindings/thermal/qcom-spmi-adc-tm-hc.yaml          |  5 +++--
 .../devicetree/bindings/thermal/qcom-spmi-adc-tm5.yaml | 10 ++++++----
 2 files changed, 9 insertions(+), 6 deletions(-)

diff --git a/Documentation/devicetree/bindings/thermal/qcom-spmi-adc-tm-hc.yaml b/Documentation/devicetree/bindings/thermal/qcom-spmi-adc-tm-hc.yaml
index 82f8f25885c0..7541e27704ca 100644
--- a/Documentation/devicetree/bindings/thermal/qcom-spmi-adc-tm-hc.yaml
+++ b/Documentation/devicetree/bindings/thermal/qcom-spmi-adc-tm-hc.yaml
@@ -118,9 +118,10 @@ examples:
     pmic {
         #address-cells = <1>;
         #size-cells = <0>;
+
         pm8998_adc: adc@3100 {
-            reg = <0x3100>;
             compatible = "qcom,spmi-adc-rev2";
+            reg = <0x3100>;
             #address-cells = <1>;
             #size-cells = <0>;
             #io-channel-cells = <1>;
@@ -131,7 +132,7 @@ examples:
             };
         };
 
-        pm8998_adc_tm: adc-tm@3400 {
+        adc-tm@3400 {
             compatible = "qcom,spmi-adc-tm-hc";
             reg = <0x3400>;
             interrupts = <0x2 0x34 0x0 IRQ_TYPE_EDGE_RISING>;
diff --git a/Documentation/devicetree/bindings/thermal/qcom-spmi-adc-tm5.yaml b/Documentation/devicetree/bindings/thermal/qcom-spmi-adc-tm5.yaml
index 02347cee6c6f..d9d2657287cb 100644
--- a/Documentation/devicetree/bindings/thermal/qcom-spmi-adc-tm5.yaml
+++ b/Documentation/devicetree/bindings/thermal/qcom-spmi-adc-tm5.yaml
@@ -171,9 +171,10 @@ examples:
     pmic {
         #address-cells = <1>;
         #size-cells = <0>;
+
         pm8150b_adc: adc@3100 {
-            reg = <0x3100>;
             compatible = "qcom,spmi-adc5";
+            reg = <0x3100>;
             #address-cells = <1>;
             #size-cells = <0>;
             #io-channel-cells = <1>;
@@ -187,7 +188,7 @@ examples:
             };
         };
 
-        pm8150b_adc_tm: adc-tm@3500 {
+        adc-tm@3500 {
             compatible = "qcom,spmi-adc-tm5";
             reg = <0x3500>;
             interrupts = <0x2 0x35 0x0 IRQ_TYPE_EDGE_RISING>;
@@ -212,9 +213,10 @@ examples:
     pmic {
         #address-cells = <1>;
         #size-cells = <0>;
+
         pmk8350_vadc: adc@3100 {
-            reg = <0x3100>;
             compatible = "qcom,spmi-adc7";
+            reg = <0x3100>;
             #address-cells = <1>;
             #size-cells = <0>;
             #io-channel-cells = <1>;
@@ -235,7 +237,7 @@ examples:
             };
         };
 
-        pmk8350_adc_tm: adc-tm@3400 {
+        adc-tm@3400 {
             compatible = "qcom,spmi-adc-tm5-gen2";
             reg = <0x3400>;
             interrupts = <0x0 0x34 0x0 IRQ_TYPE_EDGE_RISING>;
-- 
2.41.0

Re: [PATCH 1/2] dt-bindings: thermal: qcom-spmi-adc-tm5/hc: fix example node names

[Krzysztof Kozlowski]

On 30/11/2023 18:41, Johan Hovold wrote:
> The ADC Thermal Monitor is part of an SPMI PMIC, which in turn sits on
> an SPMI bus.
> 
> Fixes: db03874b8543 ("dt-bindings: thermal: qcom: add HC variant of adc-thermal monitor bindings")
> Fixes: e8ffd6c0756b ("dt-bindings: thermal: qcom: add adc-thermal monitor bindings")

This is just an example, not a binding. There is no real bug to be fixed.


Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof

Re: [PATCH 2/2] dt-bindings: thermal: qcom-spmi-adc-tm5/hc: clean up examples

[Krzysztof Kozlowski]

On 30/11/2023 18:41, Johan Hovold wrote:
> Clean up the examples by adding newline separators, moving 'reg'
> properties after 'compatible' and dropping unused labels.
> 
> Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
> ---
>  .../bindings/thermal/qcom-spmi-adc-tm-hc.yaml          |  5 +++--
>  .../devicetree/bindings/thermal/qcom-spmi-adc-tm5.yaml | 10 ++++++----
>  2 files changed, 9 insertions(+), 6 deletions(-)

This and previous patch are both trivial cleanups, so probably should be
squashed together. Anyway:

Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof

Re: [PATCH 2/2] dt-bindings: thermal: qcom-spmi-adc-tm5/hc: clean up examples

[Johan Hovold]

On Fri, Dec 01, 2023 at 09:28:48AM +0100, Krzysztof Kozlowski wrote:
> On 30/11/2023 18:41, Johan Hovold wrote:
> > Clean up the examples by adding newline separators, moving 'reg'
> > properties after 'compatible' and dropping unused labels.
> > 
> > Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
> > ---
> >  .../bindings/thermal/qcom-spmi-adc-tm-hc.yaml          |  5 +++--
> >  .../devicetree/bindings/thermal/qcom-spmi-adc-tm5.yaml | 10 ++++++----
> >  2 files changed, 9 insertions(+), 6 deletions(-)
> 
> This and previous patch are both trivial cleanups, so probably should be
> squashed together. Anyway:

I didn't want to mix too many things in one patch, and as I just
mentioned in another reply, I consider the "spmi" parent node name to be
more than just a naming cleanup as calling the node "spmi" indicates
that these "devices" are SPMI devices themselves, rather than part of an
SPMI PMIC.

> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Thanks again.

Johan

Re: [PATCH 0/2] dt-bindings: thermal: qcom-spmi-adc-tm5/hc: fix up examples

[Johan Hovold]

Hi Daniel and Rafael,

On Thu, Nov 30, 2023 at 06:41:12PM +0100, Johan Hovold wrote:
> When reviewing the various SPMI PMIC bindings, I noticed that several
> examples were incorrect and misleading and could also use some cleanup.
> 
> This series addresses the thermal ones.

> Johan Hovold (2):
>   dt-bindings: thermal: qcom-spmi-adc-tm5/hc: fix example node names
>   dt-bindings: thermal: qcom-spmi-adc-tm5/hc: clean up examples

Can we get these merged for 6.8?

Johan

Re: [PATCH 0/2] dt-bindings: thermal: qcom-spmi-adc-tm5/hc: fix up examples

[Daniel Lezcano]

On 19/12/2023 16:59, Johan Hovold wrote:
> Hi Daniel and Rafael,
> 
> On Thu, Nov 30, 2023 at 06:41:12PM +0100, Johan Hovold wrote:
>> When reviewing the various SPMI PMIC bindings, I noticed that several
>> examples were incorrect and misleading and could also use some cleanup.
>>
>> This series addresses the thermal ones.
> 
>> Johan Hovold (2):
>>    dt-bindings: thermal: qcom-spmi-adc-tm5/hc: fix example node names
>>    dt-bindings: thermal: qcom-spmi-adc-tm5/hc: clean up examples
> 
> Can we get these merged for 6.8?

Applied, thanks

-- 
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog