linux-arm-msm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jeykumar Sankaran <jsanka@codeaurora.org>
To: Stanimir Varbanov <stanimir.varbanov@linaro.org>
Cc: ryadav@codeaurora.org, airlied@linux.ie,
	linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org,
	abhinavk@codeaurora.org, robh+dt@kernel.org,
	skolluku@codeaurora.org, hoegsberg@chromium.org,
	dovizu@chromium.org, freedreno@lists.freedesktop.org,
	chandanu@codeaurora.org
Subject: Re: [PATCH v3 03/19] drm: add msm compressed format modifiers
Date: Wed, 25 Jul 2018 16:09:03 -0700	[thread overview]
Message-ID: <d224e3ff142d687c07233f70864206af@codeaurora.org> (raw)
In-Reply-To: <97591f82-2895-fa04-ddd2-b7cd09dece8b@linaro.org>

On 2018-07-25 07:09, Stanimir Varbanov wrote:
> Hi,
> 
> On 07/20/2018 11:42 PM, Sean Paul wrote:
>> From: Jeykumar Sankaran <jsanka@codeaurora.org>
>> 
>> Qualcomm Snapdragon chipsets uses compressed format
>> to optimize BW across multiple IP's. This change adds
>> needed modifier support in drm for a simple 4x4 tile
>> based compressed variants of base formats.
>> 
>> Changes in v3:
>> - Removed duplicate entry for DRM_FORMAT_MOD_QCOM_COMPRESSED (Rob 
>> Clark)
>> 
>> Signed-off-by: Jeykumar Sankaran <jsanka@codeaurora.org>
>> Signed-off-by: Sean Paul <seanpaul@chromium.org>
>> ---
>>  include/uapi/drm/drm_fourcc.h | 37 
>> +++++++++++++++++++++++++++++++++++
>>  1 file changed, 37 insertions(+)
>> 
>> diff --git a/include/uapi/drm/drm_fourcc.h 
>> b/include/uapi/drm/drm_fourcc.h
>> index e04613d30a13..1c9a6bf8c81e 100644
>> --- a/include/uapi/drm/drm_fourcc.h
>> +++ b/include/uapi/drm/drm_fourcc.h
>> @@ -298,6 +298,43 @@ extern "C" {
>>   */
>>  #define DRM_FORMAT_MOD_SAMSUNG_64_32_TILE	fourcc_mod_code(SAMSUNG, 1)
>> 
>> +/*
>> + * Qualcomm Compressed Format
>> + *
>> + * Refers to a compressed variant of the base format that is 
>> compressed.
>> + * Implementation may be platform and base-format specific.
>> + *
>> + * Each macrotile consists of m x n (mostly 4 x 4) tiles.
>> + * Pixel data pitch/stride is aligned with macrotile width.
>> + * Pixel data height is aligned with macrotile height.
>> + * Entire pixel data buffer is aligned with 4k(bytes).
>> + */
>> +#define DRM_FORMAT_MOD_QCOM_COMPRESSED	fourcc_mod_code(QCOM, 1)
>> +
>> +/*
>> + * QTI DX Format
>> + *
>> + * Refers to a DX variant of the base format.
>> + * Implementation may be platform and base-format specific.
>> + */
>> +#define DRM_FORMAT_MOD_QCOM_DX	fourcc_mod_code(QCOM, 0x2)
> 
> What DX stands for?

_DX is QCOM modifier for identifying 10bit version of NV12 format since 
there is no fourcc_code for the same.

-- 
Jeykumar S
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

  reply	other threads:[~2018-07-25 23:09 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-20 20:42 [PATCH v3 00/19] drm/msm: Add support for SDM845 Display Processing Unit (DPU) Sean Paul
2018-07-20 20:42 ` [PATCH v3 03/19] drm: add msm compressed format modifiers Sean Paul
     [not found]   ` <20180720204315.19054-4-seanpaul-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
2018-07-25 14:09     ` Stanimir Varbanov
2018-07-25 23:09       ` Jeykumar Sankaran [this message]
2018-07-26  9:37         ` Stanimir Varbanov
     [not found]         ` <d224e3ff142d687c07233f70864206af-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2018-07-26 11:45           ` Rob Clark
     [not found]             ` <CAF6AEGvrpmNVtYJxMR2Ka5S3_oeGm8C_SbeOPZR_TAONhS0_KA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2018-07-26 14:43               ` [PATCH v4 " Sean Paul
2018-07-20 20:42 ` [PATCH v3 04/19] drm/msm/dsi: adjust dsi timing for dual dsi mode Sean Paul
2018-07-20 20:42 ` [PATCH v3 06/19] drm/msm/dsi: initialize postdiv_lock before use for 10nm pll Sean Paul
2018-07-20 20:43 ` [PATCH v3 09/19] drm/msm/mdp5: subclass msm_mdss for mdp5 Sean Paul
     [not found] ` <20180720204315.19054-1-seanpaul-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
2018-07-20 20:42   ` [PATCH v3 01/19] dt-bindings: msm/dsi: Add mdp transfer time to msm dsi binding Sean Paul
2018-07-20 20:42   ` [PATCH v3 02/19] drm: Add support for pps and compression mode command packet Sean Paul
2018-07-20 20:42   ` [PATCH v3 05/19] drm/msm/dsi: Use one connector for dual DSI mode Sean Paul
2018-07-20 20:42   ` [PATCH v3 07/19] drm/msm/dsi: set encoder mode for DRM bridge explicitly Sean Paul
2018-07-20 20:42   ` [PATCH v3 08/19] drm/msm: Move wait_for_vblanks into mdp complete_commit() hooks Sean Paul
2018-07-20 20:43   ` [PATCH v3 10/19] drm/msm: enable zpos normalization Sean Paul
2018-07-20 20:43   ` [PATCH v3 11/19] drm/msm: higher values of pclk can exceed 32 bits when multiplied by a factor Sean Paul
2018-07-20 20:43   ` [PATCH v3 13/19] drm/msm: #define MDP version numbers Sean Paul
2018-07-20 20:43   ` [PATCH v3 14/19] drm/msm: Use labels for unwinding in the error path Sean Paul
2018-07-20 20:43   ` [PATCH v3 15/19] drm/msm: #define MAX_<OBJECT> in msm_drv.h Sean Paul
2018-07-20 20:43   ` [PATCH v3 16/19] drm/msm: Add .commit() callback to msm_kms functions Sean Paul
2018-07-20 20:43   ` [PATCH v3 17/19] drm/msm: Add pm_suspend/resume callbacks to msm_kms Sean Paul
2018-07-20 20:43   ` [PATCH v3 18/19] dt-bindings: msm/disp: Add bindings for Snapdragon 845 DPU Sean Paul
2018-07-24 23:31     ` Rob Herring
2018-07-20 20:43   ` [PATCH v3 19/19] drm/msm: Add SDM845 DPU support Sean Paul
2018-07-20 20:43 ` [PATCH v3 12/19] drm/msm: Clean up dangling atomic_wq Sean Paul

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d224e3ff142d687c07233f70864206af@codeaurora.org \
    --to=jsanka@codeaurora.org \
    --cc=abhinavk@codeaurora.org \
    --cc=airlied@linux.ie \
    --cc=chandanu@codeaurora.org \
    --cc=dovizu@chromium.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=freedreno@lists.freedesktop.org \
    --cc=hoegsberg@chromium.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    --cc=ryadav@codeaurora.org \
    --cc=skolluku@codeaurora.org \
    --cc=stanimir.varbanov@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).