From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Dolev Raviv" Subject: Re: [PATCH V5 11/17] scsi: ufs: add UFS power management support Date: Thu, 25 Sep 2014 10:35:09 -0000 Message-ID: References: <1411571653-22729-1-git-send-email-draviv@codeaurora.org> <1411571653-22729-12-git-send-email-draviv@codeaurora.org> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7BIT Return-path: Received: from smtp.codeaurora.org ([198.145.11.231]:47023 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751110AbaIYKfL (ORCPT ); Thu, 25 Sep 2014 06:35:11 -0400 In-Reply-To: Sender: linux-arm-msm-owner@vger.kernel.org List-Id: linux-arm-msm@vger.kernel.org To: Akinobu Mita Cc: Dolev Raviv , Jej B , Christoph Hellwig , "linux-scsi@vger.kernel.org" , linux-scsi-owner@vger.kernel.org, linux-arm-msm@vger.kernel.org, Santosh Y , Subhash Jadavani , Sujit Reddy Thumma Thanks Mita, You are right these are careless mistakes. I will fix all of them and upload a new version shortly. > __ufshcd_send_uic_cmd() is called with host_lock held here, but > host_lock is acquired again in __ufshcd_send_uic_cmd(). So it causes > recursive deadlock. Correct I forgot to complete the fix. > > ufshcd_wait_for_uic_cmd() is already called in the previous > __ufshcd_send_uic_cmd() call. > > These two issues don't exist in v3. Same fix I forgot to complete from earlier comment. > > I was still seeing null pointer derefence with v4 which I was reported > (http://marc.info/?l=linux-scsi&m=141087506802548) and nothing > changed in v5. Could you check if the fix is needed? > Sure, my mistake. I'll defiantly add a null pointer check in ufshcd_config_vreg_hpm & ufshcd_config_vreg_lpm, to reduce overhead when vregs are not initialized. Thanks, Dolev -- QUALCOMM ISRAEL, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation