From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3EB3E19B3E2; Thu, 5 Sep 2024 12:13:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725538409; cv=none; b=uKut0nHkYDtqnGKhQg95q442Li0cDksGMw3WfZmGrTQuExe/xEyxn7+Dvnwn7SaGSsLuW/PPuyul0BmfRbsprDvBKp4WZFlpHoo4Um1jLAbbt/8cFwHDcGKwPe8Jed90hmflm5wEQoyT3QHvr6eVGWMmlMQTA2quQIlYyUyNzSs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725538409; c=relaxed/simple; bh=xmP/wJyeYT7M4VQxSWmO3MapekYf8Jd7YMh+Yp8oi9Q=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=uStXeU1d1XX2lb1wJV54S9GOpNX522Th+CAQEQPvdCTLwgOBIDL2NERW4gvgMpV8Pvnm+muFP65omAat99eZi8sfSImolc4/+TWdQ8xddOAWBuFHD5fS1wX5hmIxOq98OHORBFrc1XaUX4LabaxihgO66dvh46EnuCNaKdqpND4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=HGU1lkB8; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="HGU1lkB8" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 250B5C4CEC3; Thu, 5 Sep 2024 12:13:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1725538408; bh=xmP/wJyeYT7M4VQxSWmO3MapekYf8Jd7YMh+Yp8oi9Q=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=HGU1lkB8L/fBqhoxiNHHuN2Yw6FzeKDCo3zUwJynw7j8LRqn+FIjU+TO0L+SgjBcX +Xk0vPjb3EEQ9WP33thlPq1DNEu99bdIcBzSe44WE6arNQBvRHX1LyUX9QoZ9yBYs6 23Ce7qXQlPiIo0xmf7ls2lVZ8cVYK1GLmLtc0O0wey9GBVgfJmsdwWmjoYAYc01YIC nStZLcM1N1jaQnXLcMsllBtyJcqyKV1VO8v5CaarS9Vihf2Ccz2rYKI9VDtYj4+24Z lAxQ+ZLUfa9eYmsSvvVlSt/iXH9A3Q6l7qrpxL4MrZT4qLGrepYwjJPjOd+XtRNkKb VAoaSytYBwqqw== Message-ID: Date: Thu, 5 Sep 2024 14:13:20 +0200 Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 03/10] media: qcom: camss: Fix potential crash if domain attach fails To: Vikram Sharma , Robert Foss , Todor Tomov , Bryan O'Donoghue , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Kapatrala Syed , Hariram Purushothaman , Bjorn Andersson , Konrad Dybcio , Hans Verkuil , cros-qcom-dts-watchers@chromium.org, Catalin Marinas , Will Deacon Cc: linux-arm-msm@vger.kernel.org, linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, stable@vger.kernel.org References: <20240904-camss_on_sc7280_rb3gen2_vision_v2_patches-v1-0-b18ddcd7d9df@quicinc.com> <20240904-camss_on_sc7280_rb3gen2_vision_v2_patches-v1-3-b18ddcd7d9df@quicinc.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20240904-camss_on_sc7280_rb3gen2_vision_v2_patches-v1-3-b18ddcd7d9df@quicinc.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 4.09.2024 1:10 PM, Vikram Sharma wrote: > Fix a potential crash in camss by ensuring detach is skipped if attach > is unsuccessful. > > Fixes: d89751c61279 ("media: qcom: camss: Add support for named power-domains") > CC: stable@vger.kernel.org > Signed-off-by: Vikram Sharma > --- > drivers/media/platform/qcom/camss/camss.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/drivers/media/platform/qcom/camss/camss.c b/drivers/media/platform/qcom/camss/camss.c > index d64985ca6e88..447b89d07e8a 100644 > --- a/drivers/media/platform/qcom/camss/camss.c > +++ b/drivers/media/platform/qcom/camss/camss.c > @@ -2132,7 +2132,7 @@ static int camss_configure_pd(struct camss *camss) > camss->res->pd_name); > if (IS_ERR(camss->genpd)) { > ret = PTR_ERR(camss->genpd); > - goto fail_pm; > + goto fail_pm_attach; > } > } > > @@ -2149,7 +2149,7 @@ static int camss_configure_pd(struct camss *camss) > ret = -ENODEV; > else > ret = PTR_ERR(camss->genpd); > - goto fail_pm; > + goto fail_pm_attach; > } > camss->genpd_link = device_link_add(camss->dev, camss->genpd, > DL_FLAG_STATELESS | DL_FLAG_PM_RUNTIME | > @@ -2164,6 +2164,7 @@ static int camss_configure_pd(struct camss *camss) > fail_pm: > dev_pm_domain_detach(camss->genpd, true); > > +fail_pm_attach: > return ret; What's the point, just call return directly where you added the goto Konrad