Re: [PATCH 1/3] dt-bindings: leds: rt8515: Support single-GPIO flash ICs with unlock gate

Rudraksha Gupta
2026-03-18T18:36:58Z

On 3/8/26 16:20, Linus Walleij wrote:
> Hi Rudraksha,
>
> thanks for your patch!
>
> On Sat, Mar 7, 2026 at 1:58 AM Rudraksha Gupta via B4 Relay
> <devnull+guptarud.gmail.com@kernel.org> wrote:
>
>> ent-gpios:
>> maxItems: 1
>> description: A connection to the 'ENT' (enable torch) pin.
>> + Optional for single-GPIO flash ICs where enf-gpios is used for
>> + both flash and torch modes.
> Fair enough, that can be done.
>
>> + unlock-gpios:
>> + maxItems: 1
>> + description: Optional GPIO to unlock the flash LED circuit. Some
>> + boards use a PMIC MPP pin that must be driven high before the
>> + flash IC will respond to the enable GPIOs.
> But this IC has no pin named "unlock". This is something else.
>
> Given the way it works it looks like a regulator enable signal.
>
> If you don't have any better idea about what this is, I would
> suggest adding
>
> vin-supply
>
> to the RT8615 bindings instead and then use a GPIO regulator
> in your device tree to provide the voltage to it from that GPIO.

Hello Linus,

Thanks for your comments (both in this email and others)! I have
addressed these in v2.

Rudraksha

>
> Yours,
> Linus Walleij