From: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
To: Marijn Suijten <marijn.suijten@somainline.org>,
Rob Clark <robdclark@gmail.com>,
Abhinav Kumar <quic_abhinavk@quicinc.com>,
Sean Paul <sean@poorly.run>, David Airlie <airlied@gmail.com>,
Daniel Vetter <daniel@ffwll.ch>,
Adam Skladowski <a39.skl@gmail.com>,
Loic Poulain <loic.poulain@linaro.org>,
Bjorn Andersson <andersson@kernel.org>,
Kuogee Hsieh <quic_khsieh@quicinc.com>,
Robert Foss <rfoss@kernel.org>, Vinod Koul <vkoul@kernel.org>,
Neil Armstrong <neil.armstrong@linaro.org>
Cc: ~postmarketos/upstreaming@lists.sr.ht,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@somainline.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Martin Botka <martin.botka@somainline.org>,
Jami Kettunen <jami.kettunen@somainline.org>,
linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org,
freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org,
Jordan Crouse <jordan@cosmicpenguin.net>,
Jessica Zhang <quic_jesszhan@quicinc.com>
Subject: Re: [PATCH v3 10/21] drm/msm/dpu: Take INTF index as parameter in interrupt register defines
Date: Wed, 26 Apr 2023 03:03:16 +0300 [thread overview]
Message-ID: <d24ecc5f-1322-40d7-dec5-e4dc2f09ff84@linaro.org> (raw)
In-Reply-To: <20230411-dpu-intf-te-v3-10-693b17fe6500@somainline.org>
On 26/04/2023 02:06, Marijn Suijten wrote:
> Instead of hardcoding many register defines for every INTF and AD4 index
> with a fixed stride, turn the defines into singular chunks of math that
> compute the address using the base and this fixed stride multiplied by
> the index given as argument to the definitions.
>
> MDP_SSPP_TOP0_OFF is dropped as that constant is zero anyway, and all
> register offsets related to it live in dpu_hwio.h.
>
> Suggested-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> Signed-off-by: Marijn Suijten <marijn.suijten@somainline.org>
> ---
> drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.c | 156 ++++++++++------------
> 1 file changed, 72 insertions(+), 84 deletions(-)
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
--
With best wishes
Dmitry
next prev parent reply other threads:[~2023-04-26 0:03 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-25 23:05 [PATCH v3 00/21] drm/msm/dpu: Implement tearcheck support on INTF block Marijn Suijten
2023-04-25 23:05 ` [PATCH v3 01/21] drm/msm/dpu: Remove unused INTF0 interrupt mask from SM6115/QCM2290 Marijn Suijten
2023-04-25 23:05 ` [PATCH v3 02/21] drm/msm/dpu: Remove TE2 block and feature from DPU >= 7.0.0 hardware Marijn Suijten
2023-04-26 0:32 ` Abhinav Kumar
2023-04-25 23:05 ` [PATCH v3 03/21] drm/msm/dpu: Move non-MDP_TOP INTF_INTR offsets out of hwio header Marijn Suijten
2023-04-25 23:05 ` [PATCH v3 04/21] drm/msm/dpu: Reindent REV_7xxx interrupt masks with tabs Marijn Suijten
2023-04-26 0:01 ` Dmitry Baryshkov
2023-04-26 0:33 ` Abhinav Kumar
2023-04-25 23:05 ` [PATCH v3 05/21] drm/msm/dpu: Fix PP_BLK_DIPHER -> DITHER typo Marijn Suijten
2023-04-25 23:05 ` [PATCH v3 06/21] drm/msm/dpu: Use V2 DITHER PINGPONG sub-block in SM8[34]50/SC8280XP Marijn Suijten
2023-04-26 16:24 ` Abhinav Kumar
2023-04-26 19:08 ` Marijn Suijten
2023-04-26 19:11 ` Abhinav Kumar
2023-04-26 20:35 ` Marijn Suijten
2023-04-25 23:05 ` [PATCH v3 07/21] drm/msm/dpu: Remove duplicate register defines from INTF Marijn Suijten
2023-04-25 23:05 ` [PATCH v3 08/21] drm/msm/dpu: Remove extraneous register define indentation Marijn Suijten
2023-04-25 23:06 ` [PATCH v3 09/21] drm/msm/dpu: Sort INTF registers numerically Marijn Suijten
2023-04-25 23:06 ` [PATCH v3 10/21] drm/msm/dpu: Take INTF index as parameter in interrupt register defines Marijn Suijten
2023-04-26 0:03 ` Dmitry Baryshkov [this message]
2023-04-25 23:06 ` [PATCH v3 11/21] drm/msm/dpu: Drop unused poll_timeout_wr_ptr PINGPONG callback Marijn Suijten
2023-04-25 23:06 ` [PATCH v3 12/21] drm/msm/dpu: Move autorefresh disable from CMD encoder to pingpong Marijn Suijten
2023-04-25 23:06 ` [PATCH v3 13/21] drm/msm/dpu: Disable pingpong TE on DPU 5.0.0 and above Marijn Suijten
2023-04-25 23:06 ` [PATCH v3 14/21] drm/msm/dpu: Disable MDP vsync source selection " Marijn Suijten
2023-04-25 23:06 ` [PATCH v3 15/21] drm/msm/dpu: Move dpu_hw_{tear_check,pp_vsync_info} to dpu_hw_mdss.h Marijn Suijten
2023-04-25 23:06 ` [PATCH v3 16/21] drm/msm/dpu: Factor out shared interrupt register in INTF_BLK macro Marijn Suijten
2023-04-25 23:06 ` [PATCH v3 17/21] drm/msm/dpu: Describe TEAR interrupt registers for DSI interfaces Marijn Suijten
2023-04-26 0:05 ` Dmitry Baryshkov
2023-04-26 7:16 ` Marijn Suijten
2023-04-26 7:17 ` Dmitry Baryshkov
2023-04-25 23:06 ` [PATCH v3 18/21] drm/msm/dpu: Add TEAR-READ-pointer interrupt to INTF block Marijn Suijten
2023-04-26 0:06 ` Dmitry Baryshkov
2023-04-26 0:08 ` Dmitry Baryshkov
2023-04-25 23:06 ` [PATCH v3 19/21] drm/msm/dpu: Merge setup_- and enable_tearcheck pingpong callbacks Marijn Suijten
2023-04-25 23:06 ` [PATCH v3 20/21] drm/msm/dpu: Implement tearcheck support on INTF block Marijn Suijten
2023-04-25 23:06 ` [PATCH v3 21/21] drm/msm/dpu: Remove intr_rdptr from DPU >= 5.0.0 pingpong config Marijn Suijten
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d24ecc5f-1322-40d7-dec5-e4dc2f09ff84@linaro.org \
--to=dmitry.baryshkov@linaro.org \
--cc=a39.skl@gmail.com \
--cc=airlied@gmail.com \
--cc=andersson@kernel.org \
--cc=angelogioacchino.delregno@somainline.org \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=freedreno@lists.freedesktop.org \
--cc=jami.kettunen@somainline.org \
--cc=jordan@cosmicpenguin.net \
--cc=konrad.dybcio@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=loic.poulain@linaro.org \
--cc=marijn.suijten@somainline.org \
--cc=martin.botka@somainline.org \
--cc=neil.armstrong@linaro.org \
--cc=quic_abhinavk@quicinc.com \
--cc=quic_jesszhan@quicinc.com \
--cc=quic_khsieh@quicinc.com \
--cc=rfoss@kernel.org \
--cc=robdclark@gmail.com \
--cc=sean@poorly.run \
--cc=vkoul@kernel.org \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox