Re: [PATCH 4/7] arm64: dts: qcom: add device tree for Xiaomi Redmi Note 6 Pro (tulip)

[Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>]

On 1/20/26 7:00 PM, Gianluca Boiano wrote:
> Add initial device tree support for the Xiaomi Redmi Note 6 Pro
> (codename: tulip), a smartphone based on Qualcomm SDM636 SoC with
> 4GB RAM and a 6.26" 1080x2280 display.
> 
> This enables:
> - Booting to a framebuffer console
> - USB support
> - Hall effect sensor
> - Battery monitoring
> - Charging (pm660_charger)
> - Status LED (pm660l_lpg)
> 
> Signed-off-by: Gianluca Boiano <morf3089@gmail.com>
> ---

[...]

> +	reserved-memory {
> +		ramoops@a0000000 {
> +			compatible = "ramoops";
> +			reg = <0x0 0xa0000000 0x0 0x400000>;

This is almost the same as all others, excluding platina

If you think it's beneficial for your "ecosystem" (with e.g. a recovery
or major custom ROM kernel), you can unify these definitions since it's
all configurable anyway


> +			console-size = <0x20000>;
> +			record-size = <0x20000>;
> +			ftrace-size = <0x0>;
> +			pmsg-size = <0x20000>;
> +		};
> +	};
> +};
> +
> +&framebuffer0 {
> +	width = <1080>;
> +	height = <2280>;
> +	stride = <(1080 * 4)>;
> +
> +	status = "okay";
> +};
> +
> +&gpio_hall_sensor {
> +	status = "okay";
> +};

Seems like all of the devices except A2 use this definition, maybe flip
it around

> +
> +&pm660_charger {
> +	monitored-battery = <&battery>;
> +
> +	status = "okay";
> +};

This is present on all of them

[...]


> +&pm660l_wled {
> +	status = "okay";
> +};

This seems to as well


> +
> +&rpm_requests {
> +	regulators-0 {
> +		compatible = "qcom,rpm-pm660l-regulators";
> +
> +		vdd_s1-supply = <&vph_pwr>;
> +		vdd_s2-supply = <&vph_pwr>;
> +		vdd_s3_s4-supply = <&vph_pwr>;
> +		vdd_s5-supply = <&vph_pwr>;
> +		vdd_s6-supply = <&vph_pwr>;
> +
> +		vdd_l1_l9_l10-supply = <&vreg_s2b_1p05>;
> +		vdd_l2-supply = <&vreg_bob>;
> +		vdd_l3_l5_l7_l8-supply = <&vreg_bob>;
> +		vdd_l4_l6-supply = <&vreg_bob>;
> +		vdd_bob-supply = <&vph_pwr>;
> +
> +		vreg_s1b_1p125: s1 {

Please diff the regulator settings, they're likely mostly common

[...]

> +&sdhc_2 {
> +	status = "okay";
> +};
> +
> +&tlmm {
> +	gpio-reserved-ranges = <8 4>; /* Fingerprint SPI */
> +};

This setting is common to all of them too

Konrad