From: Krzysztof Kozlowski <krzk@kernel.org>
To: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>,
Rob Clark <robin.clark@oss.qualcomm.com>,
Dmitry Baryshkov <lumag@kernel.org>,
Abhinav Kumar <abhinav.kumar@linux.dev>,
Jessica Zhang <jessica.zhang@oss.qualcomm.com>,
Sean Paul <sean@poorly.run>,
Marijn Suijten <marijn.suijten@somainline.org>,
David Airlie <airlied@gmail.com>, Simona Vetter <simona@ffwll.ch>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Maxime Ripard <mripard@kernel.org>,
Thomas Zimmermann <tzimmermann@suse.de>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Kuogee Hsieh <quic_khsieh@quicinc.com>,
Abel Vesa <abel.vesa@linaro.org>,
Mahadevan <quic_mahap@quicinc.com>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>
Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org,
freedreno@lists.freedesktop.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
Abhinav Kumar <quic_abhinavk@quicinc.com>
Subject: Re: [PATCH v6 5/6] dt-bindings: display/msm: add stream pixel clock bindings for MST
Date: Thu, 28 Aug 2025 16:32:35 +0200 [thread overview]
Message-ID: <d2c3b394-f211-4798-add2-d162c719dd83@kernel.org> (raw)
In-Reply-To: <20250815-dp_mst_bindings-v6-5-e715bbbb5386@oss.qualcomm.com>
On 15/08/2025 16:30, Dmitry Baryshkov wrote:
> + - if:
> + properties:
> + compatible:
> + contains:
> + enum:
> + - qcom,sc7180-dp
> + - qcom,sc7280-dp
> + - qcom,sc7280-edp
> + - qcom,sc8180x-edp
> + - qcom,sc8280xp-edp
> + - qcom,sm6350-dp
> + then:
> + properties:
> + clocks:
> + minItems: 5
> + maxItems: 5
> + else:
> + if:
As discussed on IRC:
Please un-nest these entries. YAML indentation does not make it easier
to follow such nesting. I also think there is no actual benefit here in
this case - all your "if:" are exclusive, so nesting brings no positive
difference.
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-08-28 14:32 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-15 14:30 [PATCH v6 0/6] dt-bindings: msm/dp: Add support for 4 pixel streams Dmitry Baryshkov
2025-08-15 14:30 ` [PATCH v6 1/6] dt-bindings: display/msm: dp-controller: allow eDP for SA8775P Dmitry Baryshkov
2025-08-15 14:30 ` [PATCH v6 2/6] dt-bindings: display/msm: qcom,x1e80100-mdss: correct DP addresses Dmitry Baryshkov
2025-08-15 14:30 ` [PATCH v6 3/6] dt-bindings: display/msm: dp-controller: add X1E80100 Dmitry Baryshkov
2025-08-15 14:30 ` [PATCH v6 4/6] dt-bindings: display/msm: drop assigned-clock-parents for dp controller Dmitry Baryshkov
2025-08-15 14:30 ` [PATCH v6 5/6] dt-bindings: display/msm: add stream pixel clock bindings for MST Dmitry Baryshkov
2025-08-20 21:08 ` Rob Herring (Arm)
2025-08-28 14:32 ` Krzysztof Kozlowski [this message]
2025-08-15 14:30 ` [PATCH v6 6/6] arm64: dts: qcom: Add MST pixel streams for displayport Dmitry Baryshkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d2c3b394-f211-4798-add2-d162c719dd83@kernel.org \
--to=krzk@kernel.org \
--cc=abel.vesa@linaro.org \
--cc=abhinav.kumar@linux.dev \
--cc=airlied@gmail.com \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@oss.qualcomm.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=freedreno@lists.freedesktop.org \
--cc=jessica.zhang@oss.qualcomm.com \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lumag@kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=marijn.suijten@somainline.org \
--cc=mripard@kernel.org \
--cc=quic_abhinavk@quicinc.com \
--cc=quic_khsieh@quicinc.com \
--cc=quic_mahap@quicinc.com \
--cc=robh@kernel.org \
--cc=robin.clark@oss.qualcomm.com \
--cc=sean@poorly.run \
--cc=simona@ffwll.ch \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).