From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Abel Vesa <abel.vesa@linaro.org>, Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Linus Walleij <linus.walleij@linaro.org>,
Rob Herring <robh@kernel.org>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org,
"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>
Subject: Re: [PATCH 1/4] dt-bindings: pinctrl: qcom: Add SM8550 pinctrl bindings
Date: Fri, 18 Nov 2022 17:24:47 +0100 [thread overview]
Message-ID: <d2fac789-4064-2c8a-5527-0da5b348a29d@linaro.org> (raw)
In-Reply-To: <e825bfbb-dc77-016a-3f56-9474aef06085@linaro.org>
On 18/11/2022 17:10, Krzysztof Kozlowski wrote:
>>> +
>>> + "^.+-hog(-[0-9]+)?$":
>>> + type: object
>>> + properties:
>>> + gpio-hog: true
>>> + gpios: true
>>> + input: true
>>> + output-high: true
>>> + output-low: true
>>> + line-name: true
>>
>> Keep properties sorted by name (just like gpio-hog.yaml).
>>
>> I wonder if we could add this to the common TLMM schema. It will appear
>> in multiple places.
>
> Answering to myself - this would require moving the 'state'
> patternProperties part to the common schema, so maybe later... Looks
> fine with changes about ordering.
If Rob likes my solution here:
https://lore.kernel.org/linux-arm-msm/20221118162101.145267-1-krzysztof.kozlowski@linaro.org/T/#u
then please go with similar way. It allows to skip listing the properties.
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-11-18 16:24 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-16 10:57 [PATCH 0/4] pinctrl: qcom: Add support for SM8550 Abel Vesa
2022-11-16 10:57 ` [PATCH 1/4] dt-bindings: pinctrl: qcom: Add SM8550 pinctrl bindings Abel Vesa
2022-11-16 11:10 ` Krzysztof Kozlowski
2022-11-18 16:10 ` Krzysztof Kozlowski
2022-11-18 16:24 ` Krzysztof Kozlowski [this message]
2022-11-16 10:57 ` [PATCH 2/4] dt-bindings: pinctrl: qcom,tlmm-common: document i2c pull property Abel Vesa
2022-11-16 11:11 ` Krzysztof Kozlowski
2022-11-16 10:57 ` [PATCH 3/4] pinctrl: qcom: add support for i2c specific pull feature Abel Vesa
2022-11-16 11:11 ` Krzysztof Kozlowski
2022-11-16 10:57 ` [PATCH 4/4] pinctrl: qcom: Add SM8550 pinctrl driver Abel Vesa
2022-11-16 11:34 ` Konrad Dybcio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d2fac789-4064-2c8a-5527-0da5b348a29d@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=abel.vesa@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox