From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.0 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 33502C433E0 for ; Thu, 14 May 2020 16:12:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0AF55206A5 for ; Thu, 14 May 2020 16:12:28 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mg.codeaurora.org header.i=@mg.codeaurora.org header.b="HYHSe+dr" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726239AbgENQM1 (ORCPT ); Thu, 14 May 2020 12:12:27 -0400 Received: from mail26.static.mailgun.info ([104.130.122.26]:57315 "EHLO mail26.static.mailgun.info" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727772AbgENQMY (ORCPT ); Thu, 14 May 2020 12:12:24 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1589472743; h=Content-Transfer-Encoding: Content-Type: In-Reply-To: MIME-Version: Date: Message-ID: From: References: Cc: To: Subject: Sender; bh=9xdp9FEZWYqs/Uq972oFma2+9rV0qjU40H3MxXCHi+A=; b=HYHSe+druKKBkVtaa6palmJujWoBm+GnXUkp3gNjxHv2qExxBoNVffmVBKNphvwylKSvRmoN Zd/RPSF8/u3w9n+NjQzi7bBJmxDxAqwdTD6gCxMQo50TXtKMzxowipAzeLBNVmvGypIBZFBu Kq9h2JHmBtthqUVMbZxTF9gKj0A= X-Mailgun-Sending-Ip: 104.130.122.26 X-Mailgun-Sid: WyI1MzIzYiIsICJsaW51eC1hcm0tbXNtQHZnZXIua2VybmVsLm9yZyIsICJiZTllNGEiXQ== Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n02.prod.us-east-1.postgun.com with SMTP id 5ebd6dd6aefa5a01cc1b8272 (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Thu, 14 May 2020 16:12:06 GMT Received: by smtp.codeaurora.org (Postfix, from userid 1001) id C210BC44791; Thu, 14 May 2020 16:12:05 +0000 (UTC) Received: from [10.226.58.28] (i-global254.qualcomm.com [199.106.103.254]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: jhugo) by smtp.codeaurora.org (Postfix) with ESMTPSA id 89494C44792; Thu, 14 May 2020 16:12:04 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 89494C44792 Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=none smtp.mailfrom=jhugo@codeaurora.org Subject: Re: [RFC PATCH 5/8] qaic: Implement data path To: Greg KH Cc: arnd@arndb.de, manivannan.sadhasivam@linaro.org, bjorn.andersson@linaro.org, wufan@codeaurora.org, pratanan@codeaurora.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org References: <1589465266-20056-1-git-send-email-jhugo@codeaurora.org> <1589465266-20056-6-git-send-email-jhugo@codeaurora.org> <20200514141403.GB2643665@kroah.com> <2e569e9e-2e5f-a99e-384c-1aaf34d9999e@codeaurora.org> <20200514155645.GB2963499@kroah.com> From: Jeffrey Hugo Message-ID: Date: Thu, 14 May 2020 10:12:03 -0600 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: <20200514155645.GB2963499@kroah.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On 5/14/2020 9:56 AM, Greg KH wrote: > On Thu, May 14, 2020 at 09:06:53AM -0600, Jeffrey Hugo wrote: >> On 5/14/2020 8:14 AM, Greg KH wrote: >>> On Thu, May 14, 2020 at 08:07:43AM -0600, Jeffrey Hugo wrote: >>>> +struct qaic_execute { >>>> + __u16 ver; /* struct version, must be 1 */ >>> >>> No need for structures to be versioned. If you change something, then >>> add a new ioctl if you really needed it. >> >> Huh. We had thought the botching ioctls document advised having a version, >> but as I double check that document, it infact does not. >> >> Will remove. > > Thanks, you can also remove the "reserved" variables as well as those > will not be needed either. Are you sure? Documentation/process/botching-up-ioctls.rst Starting at Line 38: "Pad the entire struct to a multiple of 64-bits if the structure contains 64-bit types - the structure size will otherwise differ on 32-bit versus 64-bit. Having a different structure size hurts when passing arrays of structures to the kernel, or if the kernel checks the structure size, which e.g. the drm core does." The "reserved" variables seem to be in line with that. -- Jeffrey Hugo Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.