Linux ARM-MSM sub-architecture
 help / color / mirror / Atom feed
From: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
To: Konrad Dybcio <konrad.dybcio@linaro.org>,
	linux-arm-msm@vger.kernel.org, andersson@kernel.org,
	agross@kernel.org, krzysztof.kozlowski@linaro.org
Cc: marijn.suijten@somainline.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/7] soc: qcom: rpmpd: Hook up VDDMX as parent of SM6375 VDDGX
Date: Wed, 25 Jan 2023 11:07:18 +0200	[thread overview]
Message-ID: <d3c362ce-48bd-696f-d7a0-45890695facd@linaro.org> (raw)
In-Reply-To: <20230125032728.611640-4-konrad.dybcio@linaro.org>

On 25/01/2023 05:27, Konrad Dybcio wrote:
> The GPU core clock requires that both VDDGX and VDDMX domains are scaled
> at the same rate at the same time (well, MX just before GX but you get
> the idea). Set MX as parent of GX to take care of that.
> 
> Suggested-by: Bjorn Andersson <andersson@kernel.org>
> Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
> ---
>   drivers/soc/qcom/rpmpd.c | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/soc/qcom/rpmpd.c b/drivers/soc/qcom/rpmpd.c
> index 9a7da7cead9e..a69182618b76 100644
> --- a/drivers/soc/qcom/rpmpd.c
> +++ b/drivers/soc/qcom/rpmpd.c
> @@ -1027,6 +1027,7 @@ static struct rpmpd sm6375_vddgx_ao;
>   static struct rpmpd sm6375_vddgx = {
>   	.pd = {	.name = "vddgx", },
>   	.peer = &sm6375_vddgx_ao,
> +	.parent = &sm6125_vddmx.pd,
>   	.res_type = RPMPD_RWGX,
>   	.res_id = 0,
>   	.key = KEY_LEVEL,
> @@ -1035,6 +1036,7 @@ static struct rpmpd sm6375_vddgx = {
>   static struct rpmpd sm6375_vddgx_ao = {
>   	.pd = {	.name = "vddgx_ao", },
>   	.peer = &sm6375_vddgx,
> +	.parent = &sm6125_vddmx_ao.pd,
>   	.active_only = true,
>   	.res_type = RPMPD_RWGX,
>   	.res_id = 0,

Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>

-- 
With best wishes
Dmitry


  reply	other threads:[~2023-01-25  9:07 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-25  3:27 [PATCH 0/7] RPMPD cleanup + parent PD Konrad Dybcio
2023-01-25  3:27 ` [PATCH 1/7] soc: qcom: rpmpd: Add parent PD support Konrad Dybcio
2023-01-25  3:27 ` [PATCH 2/7] soc: qcom: rpmpd: Expand #defines into structs Konrad Dybcio
2023-01-25  9:08   ` Dmitry Baryshkov
2023-01-25  3:27 ` [PATCH 3/7] soc: qcom: rpmpd: Hook up VDDMX as parent of SM6375 VDDGX Konrad Dybcio
2023-01-25  9:07   ` Dmitry Baryshkov [this message]
2023-01-25  3:27 ` [PATCH 4/7] soc: qcom: rpmpd: Remove SoC names from RPMPD names Konrad Dybcio
2023-01-25  9:02   ` Dmitry Baryshkov
2023-01-25  3:27 ` [PATCH 5/7] soc: qcom: rpmpd: Remove useless comments Konrad Dybcio
2023-01-25  3:27 ` [PATCH 6/7] soc: qcom: rpmpd: Move all RPMPD definitions up and sort them by name Konrad Dybcio
2023-01-25  3:27 ` [PATCH 7/7] soc: qcom: rpmpd: Make bindings assignments consistent Konrad Dybcio
2023-01-25  8:57 ` [PATCH 0/7] RPMPD cleanup + parent PD Dmitry Baryshkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d3c362ce-48bd-696f-d7a0-45890695facd@linaro.org \
    --to=dmitry.baryshkov@linaro.org \
    --cc=agross@kernel.org \
    --cc=andersson@kernel.org \
    --cc=konrad.dybcio@linaro.org \
    --cc=krzysztof.kozlowski@linaro.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marijn.suijten@somainline.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox