From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2258D19CC3E; Tue, 10 Dec 2024 11:50:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733831458; cv=none; b=iMWn02Ik5/Z8dr4gdJneWf1+60TrEk0mQlrp5eebySl1CTDYfHOilzdfVaSUnGwrzPgY9W8P7DQDWNea5+ZOH5mDu0Xa21gO8l2NFQa5JmpEHl2g4c43lbh0pn0M6WH8Ai0YvFPljYNPIed9uohB5Lyd3C163aXwfi3EcCcaKq4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733831458; c=relaxed/simple; bh=UftqhzXvgN2MMWDpkardkQ1oOP2GYVoU2rwluZ1ObVA=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=jf9ngdFMIz8vPF+Q30HNejAPxBJ/xcPCMPcWOEhsTSf1k0WVKA+j5NmwixIlUdOk9OiOg28yrcQOmBU9X/omGl/1gKQsjkalIvsiGmNVpK2P5MlCLaZKFKOXrbXSJL+wGj0oY2vmuwaIie0h9AD/BFKBVX8M6H3ZPV9rT+SKS2U= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=ZcFQ21cF; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="ZcFQ21cF" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 58824C4CED6; Tue, 10 Dec 2024 11:50:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1733831457; bh=UftqhzXvgN2MMWDpkardkQ1oOP2GYVoU2rwluZ1ObVA=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=ZcFQ21cFhuPSI51r9BX6E7Oz8n9QgxBhjVjwdr3zSp0AK01GXuUVx+oMHUg9tzgtK YJQ6SApdP7PgPhwqTGEDMDxixT0AvZ0ZGMAIKEfwyKNzMgINTtcWmyq5DttSFKAFQ2 LzAYsmTPgY2EmV3U6RDjbYQzxlnOJMgZB84tmJxH66f9BaHpP9alEA+yPRsce4qqOr 4czyJMeCjidvWmWCScLfTvX6/qr4QwriHNchrmGA/QPS+rVeGt7bYjGggA7Q4JAm6F SvVESMYuQ8xl41vZjAoh7zryEexG+cfG7xMvzuzzWeBriLDtzTj78iyclPMXryVMXz aaeRKVtQF3nGw== Message-ID: Date: Tue, 10 Dec 2024 12:50:51 +0100 Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 5/5] arm64: dts: qcom: Add support for QCS9075 Ride & Ride-r3 To: Wasim Nazir Cc: Dmitry Baryshkov , Konrad Dybcio , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, kernel@quicinc.com References: <20241119174954.1219002-1-quic_wasimn@quicinc.com> <20241119174954.1219002-6-quic_wasimn@quicinc.com> <9e351979-be01-4d38-9b94-cc23efac4c3f@kernel.org> <8cf9edc0-a0cb-4fd0-b10e-2138784dfba3@kernel.org> <5782d7c6-1a75-4f15-8942-387742e0ae09@kernel.org> From: Krzysztof Kozlowski Content-Language: en-US Autocrypt: addr=krzk@kernel.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzSVLcnp5c3p0b2Yg S296bG93c2tpIDxrcnprQGtlcm5lbC5vcmc+wsGVBBMBCgA/AhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgBYhBJvQfg4MUfjVlne3VBuTQ307QWKbBQJgPO8PBQkUX63hAAoJEBuTQ307 QWKbBn8P+QFxwl7pDsAKR1InemMAmuykCHl+XgC0LDqrsWhAH5TYeTVXGSyDsuZjHvj+FRP+ gZaEIYSw2Yf0e91U9HXo3RYhEwSmxUQ4Fjhc9qAwGKVPQf6YuQ5yy6pzI8brcKmHHOGrB3tP /MODPt81M1zpograAC2WTDzkICfHKj8LpXp45PylD99J9q0Y+gb04CG5/wXs+1hJy/dz0tYy iua4nCuSRbxnSHKBS5vvjosWWjWQXsRKd+zzXp6kfRHHpzJkhRwF6ArXi4XnQ+REnoTfM5Fk VmVmSQ3yFKKePEzoIriT1b2sXO0g5QXOAvFqB65LZjXG9jGJoVG6ZJrUV1MVK8vamKoVbUEe 0NlLl/tX96HLowHHoKhxEsbFzGzKiFLh7hyboTpy2whdonkDxpnv/H8wE9M3VW/fPgnL2nPe xaBLqyHxy9hA9JrZvxg3IQ61x7rtBWBUQPmEaK0azW+l3ysiNpBhISkZrsW3ZUdknWu87nh6 eTB7mR7xBcVxnomxWwJI4B0wuMwCPdgbV6YDUKCuSgRMUEiVry10xd9KLypR9Vfyn1AhROrq AubRPVeJBf9zR5UW1trJNfwVt3XmbHX50HCcHdEdCKiT9O+FiEcahIaWh9lihvO0ci0TtVGZ MCEtaCE80Q3Ma9RdHYB3uVF930jwquplFLNF+IBCn5JRzsFNBFVDXDQBEADNkrQYSREUL4D3 Gws46JEoZ9HEQOKtkrwjrzlw/tCmqVzERRPvz2Xg8n7+HRCrgqnodIYoUh5WsU84N03KlLue MNsWLJBvBaubYN4JuJIdRr4dS4oyF1/fQAQPHh8Thpiz0SAZFx6iWKB7Qrz3OrGCjTPcW6ei OMheesVS5hxietSmlin+SilmIAPZHx7n242u6kdHOh+/SyLImKn/dh9RzatVpUKbv34eP1wA GldWsRxbf3WP9pFNObSzI/Bo3kA89Xx2rO2roC+Gq4LeHvo7ptzcLcrqaHUAcZ3CgFG88CnA 6z6lBZn0WyewEcPOPdcUB2Q7D/NiUY+HDiV99rAYPJztjeTrBSTnHeSBPb+qn5ZZGQwIdUW9 YegxWKvXXHTwB5eMzo/RB6vffwqcnHDoe0q7VgzRRZJwpi6aMIXLfeWZ5Wrwaw2zldFuO4Dt 91pFzBSOIpeMtfgb/Pfe/a1WJ/GgaIRIBE+NUqckM+3zJHGmVPqJP/h2Iwv6nw8U+7Yyl6gU BLHFTg2hYnLFJI4Xjg+AX1hHFVKmvl3VBHIsBv0oDcsQWXqY+NaFahT0lRPjYtrTa1v3tem/ JoFzZ4B0p27K+qQCF2R96hVvuEyjzBmdq2esyE6zIqftdo4MOJho8uctOiWbwNNq2U9pPWmu 4vXVFBYIGmpyNPYzRm0QPwARAQABwsF8BBgBCgAmAhsMFiEEm9B+DgxR+NWWd7dUG5NDfTtB YpsFAmA872oFCRRflLYACgkQG5NDfTtBYpvScw/9GrqBrVLuJoJ52qBBKUBDo4E+5fU1bjt0 Gv0nh/hNJuecuRY6aemU6HOPNc2t8QHMSvwbSF+Vp9ZkOvrM36yUOufctoqON+wXrliEY0J4 ksR89ZILRRAold9Mh0YDqEJc1HmuxYLJ7lnbLYH1oui8bLbMBM8S2Uo9RKqV2GROLi44enVt vdrDvo+CxKj2K+d4cleCNiz5qbTxPUW/cgkwG0lJc4I4sso7l4XMDKn95c7JtNsuzqKvhEVS oic5by3fbUnuI0cemeizF4QdtX2uQxrP7RwHFBd+YUia7zCcz0//rv6FZmAxWZGy5arNl6Vm lQqNo7/Poh8WWfRS+xegBxc6hBXahpyUKphAKYkah+m+I0QToCfnGKnPqyYIMDEHCS/RfqA5 t8F+O56+oyLBAeWX7XcmyM6TGeVfb+OZVMJnZzK0s2VYAuI0Rl87FBFYgULdgqKV7R7WHzwD uZwJCLykjad45hsWcOGk3OcaAGQS6NDlfhM6O9aYNwGL6tGt/6BkRikNOs7VDEa4/HlbaSJo 7FgndGw1kWmkeL6oQh7wBvYll2buKod4qYntmNKEicoHGU+x91Gcan8mCoqhJkbqrL7+nXG2 5Q/GS5M9RFWS+nYyJh+c3OcfKqVcZQNANItt7+ULzdNJuhvTRRdC3g9hmCEuNSr+CLMdnRBY fv0= In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 10/12/2024 10:24, Wasim Nazir wrote: > On Tue, Dec 10, 2024 at 08:25:34AM +0100, Krzysztof Kozlowski wrote: >> On 10/12/2024 00:25, Dmitry Baryshkov wrote: >>>>>>>> 9100 & 9075 are different from “safe” perspective. They differ in >>>>>>>> changes related to thermal which will be added later in devicetree. >>>>>>> >>>>>>> Since this can't be inferred from just looking at the changes, please >>>>>>> make sure to add that to the commit message >>>>>> >>>>>> Any include of other DTS is clear sign something is odd here. Including >>>>>> multiple times without any added nodes is showing these are not real >>>>>> products/boards . >>>>> >>>>> We're adding DTS to reuse the common board changes, with plans to >>>>> include the differences in upcoming patches. To provide more clarity, I >>>>> will include patches in this series to highlight the differences between >>>>> the 9100 and 9075 boards. >>>> >>>> Sure, still do not include DTS. Just like C files don't include C files. >>> >>> So, is the solution simple, rename .dts to .dtsi and include it from >>> both .dts files? >> >> For example. This leads to more questions - what is common here? We do >> not create shared DTSI files just because someone wants, but to really >> note shared components or shared designs. >> > > We can reuse the common dtsi for ride boards, i.e., sa8775p-ride.dtsi, > and then add board-specific changes in the corresponding files. So you will create shared DTSI because "someone wants"? Did you read the question above and valid reasons/answers to it? > > If this approach is acceptable, I can proceed with sending the > next patch series. I hope this will help clarify things further. Best regards, Krzysztof