From: Satya Priya Kakitapalli <quic_skakitap@quicinc.com>
To: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>,
Krzysztof Kozlowski <krzk@kernel.org>
Cc: Bjorn Andersson <andersson@kernel.org>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
Ajit Pandey <quic_ajipan@quicinc.com>,
Imran Shaik <quic_imrashai@quicinc.com>,
"Taniya Das" <quic_tdas@quicinc.com>,
Jagadeesh Kona <quic_jkona@quicinc.com>,
<linux-arm-msm@vger.kernel.org>, <linux-clk@vger.kernel.org>,
<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<stable@vger.kernel.org>
Subject: Re: [PATCH v2 1/4] dt-bindings: clock: qcom: Add missing bindings on gcc-sc8180x
Date: Wed, 7 May 2025 09:41:45 +0530 [thread overview]
Message-ID: <d41d1c72-6f43-497a-8021-8a9af59f5877@quicinc.com> (raw)
In-Reply-To: <1cd1d97f-a6f1-43e6-8451-b9433db93c16@oss.qualcomm.com>
On 5/5/2025 6:52 PM, Konrad Dybcio wrote:
> On 5/5/25 11:46 AM, Krzysztof Kozlowski wrote:
>> On 05/05/2025 11:43, Satya Priya Kakitapalli wrote:
>>> On 5/2/2025 12:15 PM, Krzysztof Kozlowski wrote:
>>>> On Wed, Apr 30, 2025 at 04:08:55PM GMT, Satya Priya Kakitapalli wrote:
>>>>> Add all the missing clock bindings for gcc-sc8180x.
>>>>>
>>>>> Fixes: 0fadcdfdcf57 ("dt-bindings: clock: Add SC8180x GCC binding")
>>>>> Cc: stable@vger.kernel.org
>>>> What sort of bug is being fixed here? This needs to be clearly expressed
>>>> in commit msg - bug or observable issue.
>>>
>>> The multi-media AHB clocks are needed to create HW dependency in the
>>> multimedia CC dt blocks and avoid any issues. They were not defined in
>>> the initial bindings.
>>>
>>> Sure, I'll add the details in the commit text.
>> I don't understand what is the bug here. You just described missing feature.
> i.e. this patch is fine, but the fixes tag doesn't apply, as it doesn't
> really fix anything on its own
Okay, I'll drop the fixes tag.
> Konrad
next prev parent reply other threads:[~2025-05-07 4:11 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-30 10:38 [PATCH v2 0/4] clk: qcom: Add camera clock controller support for sc8180x Satya Priya Kakitapalli
2025-04-30 10:38 ` [PATCH v2 1/4] dt-bindings: clock: qcom: Add missing bindings on gcc-sc8180x Satya Priya Kakitapalli
2025-05-02 6:45 ` Krzysztof Kozlowski
2025-05-05 9:43 ` Satya Priya Kakitapalli
2025-05-05 9:46 ` Krzysztof Kozlowski
2025-05-05 13:22 ` Konrad Dybcio
2025-05-07 4:11 ` Satya Priya Kakitapalli [this message]
2025-04-30 10:38 ` [PATCH v2 2/4] dt-bindings: clock: Add Qualcomm SC8180X Camera clock controller Satya Priya Kakitapalli
2025-05-02 6:49 ` Krzysztof Kozlowski
2025-05-05 9:43 ` Satya Priya Kakitapalli
2025-04-30 10:38 ` [PATCH v2 3/4] clk: qcom: camcc-sc8180x: Add SC8180X camera clock controller driver Satya Priya Kakitapalli
2025-05-02 22:35 ` Dmitry Baryshkov
2025-05-05 9:44 ` Satya Priya Kakitapalli
2025-04-30 10:38 ` [PATCH v2 4/4] arm64: dts: qcom: Add camera clock controller for sc8180x Satya Priya Kakitapalli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d41d1c72-6f43-497a-8021-8a9af59f5877@quicinc.com \
--to=quic_skakitap@quicinc.com \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@oss.qualcomm.com \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=quic_ajipan@quicinc.com \
--cc=quic_imrashai@quicinc.com \
--cc=quic_jkona@quicinc.com \
--cc=quic_tdas@quicinc.com \
--cc=robh@kernel.org \
--cc=sboyd@kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox