From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f45.google.com (mail-wm1-f45.google.com [209.85.128.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8AA5035A38C for ; Fri, 27 Feb 2026 22:04:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772229899; cv=none; b=etRRwQc9HMuDLaVi7m1OBwTBuaKq8/a694UvpAJpf4X2wSQs73d53IvfV4XZjhL59Kok4loTr5RaEGl9vp5n/XVfP9agLhcvFDZAJAGDM2UcKtsSXJ80kJIfQbwU2qFnOk/WGxWZsECPkLuDLPa5firI7UZueA8hSBVBQ2+qUIo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772229899; c=relaxed/simple; bh=WdTiESiUJi/ZikpLnYLLZMIv85uQ1DUOgxKPLUY9MdQ=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=gNtWZNT6XfUQiRgbIMaPrik4vWwQ8xTvaEw+KwAn/sYIkQ/A+D4YwEl3u9jgQH1P8Pzh1Dx3zl1L2zL6D+7pCKc0C10KVcabwqDtIiE6ctjHT1an+TP9iyBu/w+o3FQ1MbWp5lQqvMUOCLGsqbEcSaFT57WBcKUbJ/T/fvVXRqo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=AJcKJuZI; arc=none smtp.client-ip=209.85.128.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="AJcKJuZI" Received: by mail-wm1-f45.google.com with SMTP id 5b1f17b1804b1-4806cc07ce7so27213875e9.1 for ; Fri, 27 Feb 2026 14:04:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1772229897; x=1772834697; darn=vger.kernel.org; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=Sf0cyeh31BT7bMM/+RaM1JIokednPwrHLYxxTyQtLrI=; b=AJcKJuZIEQ3muyZdHiC9tl4ufGPOxdzCB5oQkiGFfVnNMD8rIhl8c3/+PiMJZsTHYC uz43+Sep2GLdN9vVDlVtpLoQq1smyD0SS667mvw7+hoLjTB5BgMkq1Fq8c3jTYVxX2zx x+E47SSyzlUDL8djcNVebgkx8itVVJjKHLeJsylXd6/eCkYsgLnpOXaI9zH5tTMxiPd6 9DR89RGbpVA1MGol4SlbDWGT5qKc5gEI4hTSU/+iACDLbygW+4jeNf1I1S7I79tKbJsn sjIajdn2IKZ/ZrMWX/8g7Z0hYq081EwYGP655GPWgnjyPB0A3DO/z9VAaN1D5MvU4QGS sMvw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772229897; x=1772834697; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Sf0cyeh31BT7bMM/+RaM1JIokednPwrHLYxxTyQtLrI=; b=dhJTdiRj+0gn5dAFxyKX2J9JLfj4hpez9PkyVOh6hX9DiDUBqmoBZzg/QywYhWI8Nn 2IHZ97gXAvTg3ftTE0dSE6HeZukQY8KVJIe4PtI6E1I3fvomr0osmQ5STg/LO28lcNgd aZU630FIzS6VrJFKXXQrkQzY2kOYMqw355N7d8GDQXcVYG2Zqm6K/HfngaXOdgjK/+1f J3JttU7JCFX2kdrvNVaSAOF33xrb2/VJPfbbc1/yZop3ap2m0uOmtzJaO/PgZoIvsX0x orIbZQx6uVPLRCqQ0MGAnZYIIWVskZKotjSXfeBN4ks9qv3nf+5XO32RNahPd3CwhkCy vIdg== X-Gm-Message-State: AOJu0YyP5l2AzTiq3biletGljZhPVLYy4qW/t4f7f0eaieLmzP1klXgR BMVJDyj3ABh8rVd3LyegqdeZ4h5pBh1F3cutunOQiUyijUgioIftqCGOThp3Yub6/q4= X-Gm-Gg: ATEYQzwv4MsKGH0pCHI4hxGUMbe9UjsT4vZ4QKvHlTtX/mFiIbbLbbbSL51ZNZxAv6N jxXEWGTh2y1+1jBFB5XXQcjku/wFjeKpiVHA9aUhl6baXsJwwXkHOStijdGU6BlH6KdBEsXaOgL b6J5PrALfwnHdWOmR4gASiDjNUhm+ds24mHBqSC8mCpKFIO6kxgrgbOcSyajwb0OSVBbptzHExJ pEyhUrhc8nedQvUV42EP9HcciUd3NeuqlDqt7tuOdFdLzfZ41jJ6qrXQ8Otyie3gWL0p0PbkwnT oGAumU1tXzGApjn7sB8JYqfKiLnYbKzyExgHMgHI7alIc7cg5ZJxn2+jJkcofPiZ51LA3um5lVu uf/LI+tRtiu+7/zfSZUIz1LQkoBpeayPr512M23fPODa6EeS+YiMT2kbTbOLSxqOoktEykvVivZ 4QTuIkHuB3Fx1uUQZxp9vvWAxP+Au2XD66MZoywojj3lYOteZSMnfPfkSa31mA0Vgx7XV91WEsh rODJ/VojfkxMw4p0a2MXKDv6wcyi8yybpc= X-Received: by 2002:a05:600c:314a:b0:477:58:7cf4 with SMTP id 5b1f17b1804b1-483c9ba7e58mr65379815e9.4.1772229896953; Fri, 27 Feb 2026 14:04:56 -0800 (PST) Received: from [192.168.16.154] (host86-188-11-239.range86-188.btcentralplus.com. [86.188.11.239]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-483bfb9d9c6sm67853935e9.14.2026.02.27.14.04.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 27 Feb 2026 14:04:56 -0800 (PST) Message-ID: Subject: Re: [PATCH v8 10/18] arm64: dts: qcom: x1e80100: Add MIPI CSI PHY nodes From: Christopher Obbard To: Bryan O'Donoghue , Bjorn Andersson , Michael Turquette , Stephen Boyd , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Robert Foss , Todor Tomov , Mauro Carvalho Chehab , Konrad Dybcio , Vladimir Zapolskiy , Bryan O'Donoghue Cc: linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, Krzysztof Kozlowski Date: Fri, 27 Feb 2026 22:04:55 +0000 In-Reply-To: <20260225-b4-linux-next-25-03-13-dtsi-x1e80100-camss-v8-10-95517393bcb2@linaro.org> References: <20260225-b4-linux-next-25-03-13-dtsi-x1e80100-camss-v8-0-95517393bcb2@linaro.org> <20260225-b4-linux-next-25-03-13-dtsi-x1e80100-camss-v8-10-95517393bcb2@linaro.org> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.56.2-8 Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Hi Bryan, On Wed, 2026-02-25 at 15:11 +0000, Bryan O'Donoghue wrote: > Add csiphy nodes for >=20 > - csiphy0 > - csiphy1 > - csiphy2 > - csiphy4 >=20 > The irregular naming of the PHYs comes directly from the hardware which f= or > whatever reason skipped csiphy3. >=20 > Separating the nodes from CAMSS as we have done with the sensor I2C bus a= ka > the CCI interface is justified since the CSIPHYs have their own pinouts a= nd > voltage rails. >=20 > Signed-off-by: Bryan O'Donoghue > --- Reviewed-by: Christopher Obbard Tested-by: Christopher Obbard > arch/arm64/boot/dts/qcom/hamoa.dtsi | 115 ++++++++++++++++++++++++++++++= ++++++ > 1 file changed, 115 insertions(+) >=20 > diff --git a/arch/arm64/boot/dts/qcom/hamoa.dtsi b/arch/arm64/boot/dts/qc= om/hamoa.dtsi > index 38f9da6ad9ca5..9c5ebe1b48ecd 100644 > --- a/arch/arm64/boot/dts/qcom/hamoa.dtsi > +++ b/arch/arm64/boot/dts/qcom/hamoa.dtsi > @@ -707,6 +707,25 @@ smem_mem: smem@ffe00000 { > }; > }; > =20 > + csiphy_opp_table: opp-table-csiphy { > + compatible =3D "operating-points-v2"; > + > + opp-300000000 { > + opp-hz =3D /bits/ 64 <300000000>; > + required-opps =3D <&rpmhpd_opp_low_svs_d1>; > + }; > + > + opp-400000000 { > + opp-hz =3D /bits/ 64 <400000000>; > + required-opps =3D <&rpmhpd_opp_low_svs>; > + }; > + > + opp-480000000 { > + opp-hz =3D /bits/ 64 <480000000>; > + required-opps =3D <&rpmhpd_opp_low_svs>; > + }; > + }; > + > qup_opp_table_100mhz: opp-table-qup100mhz { > compatible =3D "operating-points-v2"; > =20 > @@ -5543,6 +5562,102 @@ cci1_i2c1: i2c-bus@1 { > }; > }; > =20 > + csiphy0: csiphy@ace4000 { > + compatible =3D "qcom,x1e80100-csi2-phy"; > + reg =3D <0 0x0ace4000 0 0x2000>; > + > + clocks =3D <&camcc CAM_CC_CSIPHY0_CLK>, > + <&camcc CAM_CC_CSI0PHYTIMER_CLK>, > + <&camcc CAM_CC_CAMNOC_AXI_RT_CLK>, > + <&camcc CAM_CC_CPAS_AHB_CLK>; > + clock-names =3D "csiphy", > + "csiphy_timer", > + "camnoc_axi", > + "cpas_ahb"; > + > + operating-points-v2 =3D <&csiphy_opp_table>; > + > + interrupts =3D ; > + > + power-domains =3D <&camcc CAM_CC_TITAN_TOP_GDSC>; > + > + #phy-cells =3D <1>; > + > + status =3D "disabled"; > + }; > + > + csiphy1: csiphy@ace6000 { > + compatible =3D "qcom,x1e80100-csi2-phy"; > + reg =3D <0 0x0ace6000 0 0x2000>; > + > + clocks =3D <&camcc CAM_CC_CSIPHY1_CLK>, > + <&camcc CAM_CC_CSI1PHYTIMER_CLK>, > + <&camcc CAM_CC_CAMNOC_AXI_RT_CLK>, > + <&camcc CAM_CC_CPAS_AHB_CLK>; > + clock-names =3D "csiphy", > + "csiphy_timer", > + "camnoc_axi", > + "cpas_ahb"; > + > + operating-points-v2 =3D <&csiphy_opp_table>; > + > + interrupts =3D ; > + > + power-domains =3D <&camcc CAM_CC_TITAN_TOP_GDSC>; > + > + #phy-cells =3D <1>; > + > + status =3D "disabled"; > + }; > + > + csiphy2: csiphy@ace8000 { > + compatible =3D "qcom,x1e80100-csi2-phy"; > + reg =3D <0 0x0ace8000 0 0x2000>; > + > + clocks =3D <&camcc CAM_CC_CSIPHY2_CLK>, > + <&camcc CAM_CC_CSI2PHYTIMER_CLK>, > + <&camcc CAM_CC_CAMNOC_AXI_RT_CLK>, > + <&camcc CAM_CC_CPAS_AHB_CLK>; > + clock-names =3D "csiphy", > + "csiphy_timer", > + "camnoc_axi", > + "cpas_ahb"; > + > + operating-points-v2 =3D <&csiphy_opp_table>; > + > + interrupts =3D ; > + > + power-domains =3D <&camcc CAM_CC_TITAN_TOP_GDSC>; > + > + #phy-cells =3D <1>; > + > + status =3D "disabled"; > + }; > + > + csiphy4: csiphy@acec000 { > + compatible =3D "qcom,x1e80100-csi2-phy"; > + reg =3D <0 0x0acec000 0 0x2000>; > + > + clocks =3D <&camcc CAM_CC_CSIPHY4_CLK>, > + <&camcc CAM_CC_CSI4PHYTIMER_CLK>, > + <&camcc CAM_CC_CAMNOC_AXI_RT_CLK>, > + <&camcc CAM_CC_CPAS_AHB_CLK>; > + clock-names =3D "csiphy", > + "csiphy_timer", > + "camnoc_axi", > + "cpas_ahb"; > + > + operating-points-v2 =3D <&csiphy_opp_table>; > + > + interrupts =3D ; > + > + power-domains =3D <&camcc CAM_CC_TITAN_TOP_GDSC>; > + > + #phy-cells =3D <1>; > + > + status =3D "disabled"; > + }; > + > camcc: clock-controller@ade0000 { > compatible =3D "qcom,x1e80100-camcc"; > reg =3D <0 0x0ade0000 0 0x20000>;