From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Andy Gross <agross@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Mathieu Poirier <mathieu.poirier@linaro.org>,
linux-arm-msm@vger.kernel.org, linux-remoteproc@vger.kernel.org,
linux-kernel@vger.kernel.org
Cc: Stephen Boyd <sboyd@kernel.org>
Subject: Re: [PATCH v2 1/3] rpmsg: qcom: glink: replace strncpy() with strscpy_pad()
Date: Mon, 20 Jun 2022 20:37:47 +0200 [thread overview]
Message-ID: <d4972a70-8ddf-a394-3e8f-08fb778622d8@linaro.org> (raw)
In-Reply-To: <640d2a3d-4c38-b921-45c1-048c255b5a9d@linaro.org>
On 09/06/2022 10:56, Krzysztof Kozlowski wrote:
> On 19/05/2022 09:33, Krzysztof Kozlowski wrote:
>> The use of strncpy() is considered deprecated for NUL-terminated
>> strings[1]. Replace strncpy() with strscpy_pad(), to keep existing
>> pad-behavior of strncpy, similarly to commit 08de420a8014 ("rpmsg:
>> glink: Replace strncpy() with strscpy_pad()"). This fixes W=1 warning:
>>
>> In function ‘qcom_glink_rx_close’,
>> inlined from ‘qcom_glink_work’ at ../drivers/rpmsg/qcom_glink_native.c:1638:4:
>> drivers/rpmsg/qcom_glink_native.c:1549:17: warning: ‘strncpy’ specified bound 32 equals destination size [-Wstringop-truncation]
>> 1549 | strncpy(chinfo.name, channel->name, sizeof(chinfo.name));
>>
>> [1] https://www.kernel.org/doc/html/latest/process/deprecated.html#strncpy-on-nul-terminated-strings
>>
>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>>
>> ---
>>
>> Changes since v1:
>> 1. Split series per subsystem.
>
> Any comments on these?
I sent first iteration in May, then on 19th of May. There is review from
Stephen.
On 9th of June I pinged but the patchset is still waiting. Anyone minds
me taking these?
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-06-20 18:37 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-19 7:33 [PATCH v2 1/3] rpmsg: qcom: glink: replace strncpy() with strscpy_pad() Krzysztof Kozlowski
2022-05-19 7:33 ` [PATCH v2 2/3] rpmsg: qcom: glink: remove unused name Krzysztof Kozlowski
2022-05-19 7:33 ` [PATCH v2 3/3] rpmsg: qcom: correct kerneldoc Krzysztof Kozlowski
2022-05-19 22:13 ` [PATCH v2 1/3] rpmsg: qcom: glink: replace strncpy() with strscpy_pad() Stephen Boyd
2022-06-09 8:56 ` Krzysztof Kozlowski
2022-06-20 18:37 ` Krzysztof Kozlowski [this message]
2022-07-05 12:14 ` Krzysztof Kozlowski
2022-07-05 15:06 ` Mathieu Poirier
2022-07-18 22:59 ` Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d4972a70-8ddf-a394-3e8f-08fb778622d8@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=mathieu.poirier@linaro.org \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).