From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BF7DBCCA479 for ; Mon, 20 Jun 2022 18:37:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S245179AbiFTShx (ORCPT ); Mon, 20 Jun 2022 14:37:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47020 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S244320AbiFTShv (ORCPT ); Mon, 20 Jun 2022 14:37:51 -0400 Received: from mail-ej1-x62d.google.com (mail-ej1-x62d.google.com [IPv6:2a00:1450:4864:20::62d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2B9122B0 for ; Mon, 20 Jun 2022 11:37:50 -0700 (PDT) Received: by mail-ej1-x62d.google.com with SMTP id h23so22755697ejj.12 for ; Mon, 20 Jun 2022 11:37:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language :from:to:cc:references:in-reply-to:content-transfer-encoding; bh=of2w0PHhR5hD/6CAppicreTgy2ChYJ3890K0i0D/L90=; b=AhKoMV70z3NzCSB1+F+SsObu+BcbBWWKtmuTyIYxFE3p2wqTmMwVm1PdTtMWLMePSm qyiuPrTrI0lPHoLKgy/TvLJVYlsyyRgPF3z/A60LatObwrYxbIwPuXrF/ft9ZPfBn6Cm UOeqtDb0X3wvWnRNJOReetdztIlG89v6Rj9aFKNP+A+57Yo3OGQ8kCWCubYxpP6g3e+i uZp+itWyzV7D2hnpLqPIHRHGL7ozAC/Wso3Drpep8bd0Zkg7q249yU4kJIpiIbYl6A+k ZiuYKRhes8yhITTgIxvBU0sp4VlBz7aQV9Fqc6fvfWXOeIlmbugBm21gLhdVnub6gyMD BovA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:from:to:cc:references:in-reply-to :content-transfer-encoding; bh=of2w0PHhR5hD/6CAppicreTgy2ChYJ3890K0i0D/L90=; b=IeNriaTJuI5Vu8Gxhf3T4uDyEIbff6vOq3Pd4Yfl+j1oWpxiPqsXbv8q8G0SOBvqft lqB0ld8Dt4IQGsrXOgHyr+IEhnCw+QmkzWejZhrZ5gpilJQdkKLseQiip0g9vgqm/6s2 kNtjIEO85M6QjISNSu71sR0ho/bv5QFZMFHxpYOuihhLs/gdUJwcWRC/MH/babYII5IC bYYJUepKbggbHF7aK5WV63IXXmauzo1tT1tXLd9NrmzT2IVbOrZ9ZATpvrkREbm7UO16 clFZucF+z907kVDl39JkGIPK71Qmp2TyQy5llssDORYWavqde5YhRX3+tLrJvK2JcVuz fAag== X-Gm-Message-State: AJIora/6QLmtGjDVzbJOukx8s+jN95E5XyRrsGj29cLc1BdHr79vzufs dBezpGJpT38DCWif9poJxDNMCw== X-Google-Smtp-Source: AGRyM1ste2L5o/LjiFIQg7XGmQjRlV4SGaTh4U3FxhvhZ1Su0LsDHiOTFfl5ZybDm8CA3kqep/fvWw== X-Received: by 2002:a17:907:1686:b0:710:6ff6:1b97 with SMTP id hc6-20020a170907168600b007106ff61b97mr22503989ejc.378.1655750268774; Mon, 20 Jun 2022 11:37:48 -0700 (PDT) Received: from [192.168.0.211] (xdsl-188-155-176-92.adslplus.ch. [188.155.176.92]) by smtp.gmail.com with ESMTPSA id g13-20020aa7c84d000000b004357b717a96sm4369577edt.85.2022.06.20.11.37.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 20 Jun 2022 11:37:48 -0700 (PDT) Message-ID: Date: Mon, 20 Jun 2022 20:37:47 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: [PATCH v2 1/3] rpmsg: qcom: glink: replace strncpy() with strscpy_pad() Content-Language: en-US From: Krzysztof Kozlowski To: Andy Gross , Bjorn Andersson , Mathieu Poirier , linux-arm-msm@vger.kernel.org, linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Stephen Boyd References: <20220519073330.7187-1-krzysztof.kozlowski@linaro.org> <640d2a3d-4c38-b921-45c1-048c255b5a9d@linaro.org> In-Reply-To: <640d2a3d-4c38-b921-45c1-048c255b5a9d@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On 09/06/2022 10:56, Krzysztof Kozlowski wrote: > On 19/05/2022 09:33, Krzysztof Kozlowski wrote: >> The use of strncpy() is considered deprecated for NUL-terminated >> strings[1]. Replace strncpy() with strscpy_pad(), to keep existing >> pad-behavior of strncpy, similarly to commit 08de420a8014 ("rpmsg: >> glink: Replace strncpy() with strscpy_pad()"). This fixes W=1 warning: >> >> In function ‘qcom_glink_rx_close’, >> inlined from ‘qcom_glink_work’ at ../drivers/rpmsg/qcom_glink_native.c:1638:4: >> drivers/rpmsg/qcom_glink_native.c:1549:17: warning: ‘strncpy’ specified bound 32 equals destination size [-Wstringop-truncation] >> 1549 | strncpy(chinfo.name, channel->name, sizeof(chinfo.name)); >> >> [1] https://www.kernel.org/doc/html/latest/process/deprecated.html#strncpy-on-nul-terminated-strings >> >> Signed-off-by: Krzysztof Kozlowski >> >> --- >> >> Changes since v1: >> 1. Split series per subsystem. > > Any comments on these? I sent first iteration in May, then on 19th of May. There is review from Stephen. On 9th of June I pinged but the patchset is still waiting. Anyone minds me taking these? Best regards, Krzysztof