From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jeykumar Sankaran Subject: Re: [PATCH v2 2/7] drm/msm: dpu: Move atomic_check_plane_state() call to atomic_check Date: Thu, 13 Sep 2018 15:24:17 -0700 Message-ID: References: <20180912135459.216217-1-sean@poorly.run> <20180912135459.216217-2-sean@poorly.run> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20180912135459.216217-2-sean-p7yTbzM4H96eqtR555YLDQ@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: freedreno-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Sender: "Freedreno" To: Sean Paul Cc: bzwang-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org, linux-arm-msm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, freedreno-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org, Sean Paul , abhinavk-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org List-Id: linux-arm-msm@vger.kernel.org T24gMjAxOC0wOS0xMiAwNjo1NCwgU2VhbiBQYXVsIHdyb3RlOgo+IEZyb206IFNlYW4gUGF1bCA8 c2VhbnBhdWxAY2hyb21pdW0ub3JnPgo+IAo+IHNyYy9kc3QgcmVjdHMgYXJlIGNoZWNrZWQgaW4g Ym90aCBhdG9taWNfY2hlY2sgYW5kIGF0b21pY191cGRhdGUsIHdpdGgKPiB0aGUgbW9yZSBjb21w cmVoZW5zaXZlIGNoZWNrIG9jY3VycmluZyBpbiBhdG9taWNfdXBkYXRlLCB3aGljaCBpcwo+IGJh Y2t3YXJkcy4gU28gY29uc29sb2RhdGUgdGhlIGNoZWNrcyBpbiBhdG9taWNfY2hlY2suCj4gCj4g Q2hhbmdlcyBpbiB2MjoKPiAtIFVzZSB0aGUgY29ycmVjdCBjcnRjIHN0YXRlIChKZXlrdW1hcikK PiAKPiBDYzogSmV5a3VtYXIgU2Fua2FyYW4gPGpzYW5rYUBjb2RlYXVyb3JhLm9yZz4KPiBTaWdu ZWQtb2ZmLWJ5OiBTZWFuIFBhdWwgPHNlYW5wYXVsQGNocm9taXVtLm9yZz4KPiAtLS0KClJldmll d2VkLWJ5OiBKZXlrdW1hciBTYW5rYXJhbiA8anNhbmthQGNvZGVhdXJvcmEub3JnPgoKPiAgZHJp dmVycy9ncHUvZHJtL21zbS9kaXNwL2RwdTEvZHB1X3BsYW5lLmMgfCA1NyArKysrKysrLS0tLS0t LS0tLS0tLS0tLQo+ICAxIGZpbGUgY2hhbmdlZCwgMTcgaW5zZXJ0aW9ucygrKSwgNDAgZGVsZXRp b25zKC0pCj4gCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9tc20vZGlzcC9kcHUxL2Rw dV9wbGFuZS5jCj4gYi9kcml2ZXJzL2dwdS9kcm0vbXNtL2Rpc3AvZHB1MS9kcHVfcGxhbmUuYwo+ IGluZGV4IDBmNDI4ZjY2Yjk1MS4uOTZlMDQyYjY2Y2Q3IDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMv Z3B1L2RybS9tc20vZGlzcC9kcHUxL2RwdV9wbGFuZS5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJt L21zbS9kaXNwL2RwdTEvZHB1X3BsYW5lLmMKPiBAQCAtMTA3OSwxMyArMTA3OSwyNyBAQCBzdGF0 aWMgYm9vbCBkcHVfcGxhbmVfdmFsaWRhdGVfc3JjKHN0cnVjdCAKPiBkcm1fcmVjdAo+ICpzcmMs Cj4gIHN0YXRpYyBpbnQgZHB1X3BsYW5lX3NzcHBfYXRvbWljX2NoZWNrKHN0cnVjdCBkcm1fcGxh bmUgKnBsYW5lLAo+ICAJCXN0cnVjdCBkcm1fcGxhbmVfc3RhdGUgKnN0YXRlKQo+ICB7Cj4gLQlp bnQgcmV0ID0gMDsKPiArCWludCByZXQgPSAwLCBtaW5fc2NhbGU7Cj4gIAlzdHJ1Y3QgZHB1X3Bs YW5lICpwZHB1ID0gdG9fZHB1X3BsYW5lKHBsYW5lKTsKPiArCWNvbnN0IHN0cnVjdCBkcm1fY3J0 Y19zdGF0ZSAqY3J0Y19zdGF0ZSA9IE5VTEw7Cj4gIAljb25zdCBzdHJ1Y3QgZHB1X2Zvcm1hdCAq Zm10Owo+ICAJc3RydWN0IGRybV9yZWN0IHNyYywgZHN0LCBmYl9yZWN0ID0geyAwIH07Cj4gLQl1 aW50MzJfdCBtYXhfdXBzY2FsZSA9IDEsIG1heF9kb3duc2NhbGUgPSAxOwo+ICAJdWludDMyX3Qg bWluX3NyY19zaXplLCBtYXhfbGluZXdpZHRoOwo+IC0JaW50IGhzY2FsZSA9IDEsIHZzY2FsZSA9 IDE7Cj4gKwo+ICsJaWYgKHN0YXRlLT5jcnRjKQo+ICsJCWNydGNfc3RhdGUgPSBkcm1fYXRvbWlj X2dldF9uZXdfY3J0Y19zdGF0ZShzdGF0ZS0+c3RhdGUsCj4gKwkJCQkJCQkgICBzdGF0ZS0+Y3J0 Yyk7Cj4gKwo+ICsJbWluX3NjYWxlID0gRlJBQ18xNl8xNigxLCBwZHB1LT5waXBlX3NibGstPm1h eGR3bnNjYWxlKTsKPiArCXJldCA9IGRybV9hdG9taWNfaGVscGVyX2NoZWNrX3BsYW5lX3N0YXRl KHN0YXRlLCBjcnRjX3N0YXRlLAo+IG1pbl9zY2FsZSwKPiArCQkJCQkgIHBkcHUtPnBpcGVfc2Js ay0+bWF4dXBzY2FsZSA8PAo+IDE2LAo+ICsJCQkJCSAgdHJ1ZSwgdHJ1ZSk7Cj4gKwlpZiAocmV0 KSB7Cj4gKwkJRFBVX0VSUk9SX1BMQU5FKHBkcHUsICJDaGVjayBwbGFuZSBzdGF0ZSBmYWlsZWQg KCVkKVxuIiwKPiByZXQpOwo+ICsJCXJldHVybiByZXQ7Cj4gKwl9Cj4gKwlpZiAoIXN0YXRlLT52 aXNpYmxlKQo+ICsJCXJldHVybiAwOwo+IAo+ICAJc3JjLngxID0gc3RhdGUtPnNyY194ID4+IDE2 Owo+ICAJc3JjLnkxID0gc3RhdGUtPnNyY195ID4+IDE2Owo+IEBAIC0xMDk5LDI1ICsxMTEzLDYg QEAgc3RhdGljIGludCBkcHVfcGxhbmVfc3NwcF9hdG9taWNfY2hlY2soc3RydWN0Cj4gZHJtX3Bs YW5lICpwbGFuZSwKPiAKPiAgCW1heF9saW5ld2lkdGggPSBwZHB1LT5waXBlX3NibGstPmNvbW1v bi0+bWF4bGluZXdpZHRoOwo+IAo+IC0JaWYgKHBkcHUtPmZlYXR1cmVzICYgRFBVX1NTUFBfU0NB TEVSKSB7Cj4gLQkJbWF4X2Rvd25zY2FsZSA9IHBkcHUtPnBpcGVfc2Jsay0+bWF4ZHduc2NhbGU7 Cj4gLQkJbWF4X3Vwc2NhbGUgPSBwZHB1LT5waXBlX3NibGstPm1heHVwc2NhbGU7Cj4gLQl9Cj4g LQlpZiAoZHJtX3JlY3Rfd2lkdGgoJnNyYykgPCBkcm1fcmVjdF93aWR0aCgmZHN0KSkKPiAtCQlo c2NhbGUgPSBkcm1fcmVjdF9jYWxjX2hzY2FsZSgmc3JjLCAmZHN0LCAxLCBtYXhfdXBzY2FsZSk7 Cj4gLQllbHNlCj4gLQkJaHNjYWxlID0gZHJtX3JlY3RfY2FsY19oc2NhbGUoJmRzdCwgJnNyYywg MSwKPiBtYXhfZG93bnNjYWxlKTsKPiAtCWlmIChkcm1fcmVjdF9oZWlnaHQoJnNyYykgPCBkcm1f cmVjdF9oZWlnaHQoJmRzdCkpCj4gLQkJdnNjYWxlID0gZHJtX3JlY3RfY2FsY192c2NhbGUoJnNy YywgJmRzdCwgMSwgbWF4X3Vwc2NhbGUpOwo+IC0JZWxzZQo+IC0JCXZzY2FsZSA9IGRybV9yZWN0 X2NhbGNfdnNjYWxlKCZkc3QsICZzcmMsIDEsCj4gbWF4X2Rvd25zY2FsZSk7Cj4gLQo+IC0JRFBV X0RFQlVHX1BMQU5FKHBkcHUsICJjaGVjayAlZCAtPiAlZFxuIiwKPiAtCQlkcHVfcGxhbmVfZW5h YmxlZChwbGFuZS0+c3RhdGUpLAo+IGRwdV9wbGFuZV9lbmFibGVkKHN0YXRlKSk7Cj4gLQo+IC0J aWYgKCFkcHVfcGxhbmVfZW5hYmxlZChzdGF0ZSkpCj4gLQkJZ290byBleGl0Owo+IC0KPiAgCWZt dCA9IHRvX2RwdV9mb3JtYXQobXNtX2ZyYW1lYnVmZmVyX2Zvcm1hdChzdGF0ZS0+ZmIpKTsKPiAK PiAgCW1pbl9zcmNfc2l6ZSA9IERQVV9GT1JNQVRfSVNfWVVWKGZtdCkgPyAyIDogMTsKPiBAQCAt MTE1NiwxNiArMTE1MSw4IEBAIHN0YXRpYyBpbnQgZHB1X3BsYW5lX3NzcHBfYXRvbWljX2NoZWNr KHN0cnVjdAo+IGRybV9wbGFuZSAqcGxhbmUsCj4gIAkJRFBVX0VSUk9SX1BMQU5FKHBkcHUsICJp bnZhbGlkIHNyYyAiIERSTV9SRUNUX0ZNVCAiCj4gbGluZToldVxuIiwKPiAgCQkJCURSTV9SRUNU X0FSRygmc3JjKSwgbWF4X2xpbmV3aWR0aCk7Cj4gIAkJcmV0ID0gLUUyQklHOwo+IC0KPiAtCS8q IGNoZWNrIHNjYWxlciBjYXBhYmlsaXR5ICovCj4gLQl9IGVsc2UgaWYgKGhzY2FsZSA8IDAgfHwg dnNjYWxlIDwgMCkgewo+IC0JCURQVV9FUlJPUl9QTEFORShwZHB1LCAiaW52YWxpZCBzY2FsaW5n IHJlcXVlc3RlZCBzcmM9Igo+IC0JCQkJRFJNX1JFQ1RfRk1UICIgZHN0PSIgRFJNX1JFQ1RfRk1U ICJcbiIsCj4gLQkJCQlEUk1fUkVDVF9BUkcoJnNyYyksIERSTV9SRUNUX0FSRygmZHN0KSk7Cj4g LQkJcmV0ID0gLUUyQklHOwo+ICAJfQo+IAo+IC1leGl0Ogo+ICAJcmV0dXJuIHJldDsKPiAgfQo+ IAo+IEBAIC0xMjM3LDcgKzEyMjQsNiBAQCBzdGF0aWMgaW50IGRwdV9wbGFuZV9zc3BwX2F0b21p Y191cGRhdGUoc3RydWN0Cj4gZHJtX3BsYW5lICpwbGFuZSwKPiAgCWNvbnN0IHN0cnVjdCBkcHVf Zm9ybWF0ICpmbXQ7Cj4gIAlzdHJ1Y3QgZHJtX2NydGMgKmNydGM7Cj4gIAlzdHJ1Y3QgZHJtX2Zy YW1lYnVmZmVyICpmYjsKPiAtCWludCByZXQsIG1pbl9zY2FsZTsKPiAKPiAgCWlmICghcGxhbmUp IHsKPiAgCQlEUFVfRVJST1IoImludmFsaWQgcGxhbmVcbiIpOwo+IEBAIC0xMjc2LDE1ICsxMjYy LDYgQEAgc3RhdGljIGludCBkcHVfcGxhbmVfc3NwcF9hdG9taWNfdXBkYXRlKHN0cnVjdAo+IGRy bV9wbGFuZSAqcGxhbmUsCj4gIAlwZHB1LT5pc19ydF9waXBlID0gKGRwdV9jcnRjX2dldF9jbGll bnRfdHlwZShjcnRjKSAhPSBOUlRfQ0xJRU5UKTsKPiAgCV9kcHVfcGxhbmVfc2V0X3Fvc19jdHJs KHBsYW5lLCBmYWxzZSwgRFBVX1BMQU5FX1FPU19QQU5JQ19DVFJMKTsKPiAKPiAtCW1pbl9zY2Fs ZSA9IEZSQUNfMTZfMTYoMSwgcGRwdS0+cGlwZV9zYmxrLT5tYXhkd25zY2FsZSk7Cj4gLQlyZXQg PSBkcm1fYXRvbWljX2hlbHBlcl9jaGVja19wbGFuZV9zdGF0ZShzdGF0ZSwgY3J0Yy0+c3RhdGUs Cj4gbWluX3NjYWxlLAo+IC0JCQkJCSAgcGRwdS0+cGlwZV9zYmxrLT5tYXh1cHNjYWxlIDw8Cj4g MTYsCj4gLQkJCQkJICB0cnVlLCBmYWxzZSk7Cj4gLQlpZiAocmV0KSB7Cj4gLQkJRFBVX0VSUk9S X1BMQU5FKHBkcHUsICJDaGVjayBwbGFuZSBzdGF0ZSBmYWlsZWQgKCVkKVxuIiwKPiByZXQpOwo+ IC0JCXJldHVybiByZXQ7Cj4gLQl9Cj4gLQo+ICAJRFBVX0RFQlVHX1BMQU5FKHBkcHUsICJGQlsl dV0gIiBEUk1fUkVDVF9GUF9GTVQgIi0+Y3J0YyV1ICIKPiBEUk1fUkVDVF9GTVQKPiAgCQkJIiwg JTQuNHMgdWJ3YyAlZFxuIiwgZmItPmJhc2UuaWQsCj4gRFJNX1JFQ1RfRlBfQVJHKCZzdGF0ZS0+ c3JjKSwKPiAgCQkJY3J0Yy0+YmFzZS5pZCwgRFJNX1JFQ1RfQVJHKCZzdGF0ZS0+ZHN0KSwKCi0t IApKZXlrdW1hciBTCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fCkZyZWVkcmVubyBtYWlsaW5nIGxpc3QKRnJlZWRyZW5vQGxpc3RzLmZyZWVkZXNrdG9wLm9y ZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ZyZWVkcmVu bwo=