From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8B9D1C761A6 for ; Mon, 3 Apr 2023 09:21:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231921AbjDCJVQ (ORCPT ); Mon, 3 Apr 2023 05:21:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46836 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232011AbjDCJU5 (ORCPT ); Mon, 3 Apr 2023 05:20:57 -0400 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4316110FA; Mon, 3 Apr 2023 02:20:46 -0700 (PDT) Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 3338Lc6E001931; Mon, 3 Apr 2023 09:20:38 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h=message-id : date : mime-version : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding; s=qcppdkim1; bh=W128USzMqbugLvfVmHEw0F4lZUvRXlAcT7kaMbYWwNE=; b=Oh0J79fY5v0McoDPaYKfqFWjs5WjGzA8xCdITgDAzgkJIuixEWornDzfQBifmSaSKr8U T3bPlDEytzXWXT9MKsvpZs3sP1Lrw7NEKJUJsWw75zbB4NXMc7XzvRkhufxh02CpmPPP iqa3s4ulwLjbi4qQUeLDC2QZLrRovcmdJyz9UilmzhlphadTF/9hQ44/oY7e+STst8Rz /BLdvpJVxwIbWHwuk/ItEo3LttWu2o8vhfu+73UOoiXuoQuv5dWKo9VhviR1MmaDQ07m wOw/oFPr7YlfOaODFtgglVlL4wtLXnFljyYXnDphSJWFHLmQ+gtqu5ejYCkERd81j9Od og== Received: from nasanppmta02.qualcomm.com (i-global254.qualcomm.com [199.106.103.254]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3pqu7f03hn-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 03 Apr 2023 09:20:37 +0000 Received: from nasanex01a.na.qualcomm.com (nasanex01a.na.qualcomm.com [10.52.223.231]) by NASANPPMTA02.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 3339Kalq031843 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 3 Apr 2023 09:20:36 GMT Received: from [10.251.45.41] (10.80.80.8) by nasanex01a.na.qualcomm.com (10.52.223.231) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.42; Mon, 3 Apr 2023 02:20:33 -0700 Message-ID: Date: Mon, 3 Apr 2023 12:20:31 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [PATCH v7 0/4] media: camss: sm8250: Virtual channels support for SM8250 Content-Language: en-US To: Bryan O'Donoghue , "Azam Sadiq Pasha Kapatrala Syed" , "linux-media@vger.kernel.org" , "linux-arm-msm@vger.kernel.org" , Jigarkumar Zala , "todor.too@gmail.com" , "nicolas.dechesne@linaro.org" CC: "agross@kernel.org" , "konrad.dybcio@somainline.org" , "mchehab@kernel.org" , Chandan Gera , Guru Chinnabhandar , Alireza Yasan , "laurent.pinchart@ideasonboard.com" References: <20221209094037.1148-1-quic_mmitkov@quicinc.com> <662d68f7-6160-263d-6e4d-e3687d5cf8eb@quicinc.com> <7565d38c-d8f4-39e0-8547-fbb511f6d649@quicinc.com> <894e3ce6-0f2b-608b-ec4e-09083704f429@linaro.org> <8243cc42-236c-20e3-74dc-1f130ab1dcf6@quicinc.com> <7b3cb8a6-8306-f001-5701-af3b482421e9@quicinc.com> From: "Milen Mitkov (Consultant)" In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01a.na.qualcomm.com (10.52.223.231) To nasanex01a.na.qualcomm.com (10.52.223.231) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-GUID: bXLo7mBw4vE1zFrsGuEJ1JzoYR9JlIJw X-Proofpoint-ORIG-GUID: bXLo7mBw4vE1zFrsGuEJ1JzoYR9JlIJw X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.942,Hydra:6.0.573,FMLib:17.11.170.22 definitions=2023-04-03_06,2023-03-31_01,2023-02-09_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxscore=0 impostorscore=0 malwarescore=0 phishscore=0 mlxlogscore=999 spamscore=0 bulkscore=0 adultscore=0 clxscore=1015 priorityscore=1501 suspectscore=0 lowpriorityscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2303200000 definitions=main-2304030071 Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On 03/04/2023 12:16, Bryan O'Donoghue wrote: > On 03/04/2023 09:38, Milen Mitkov (Consultant) wrote: >> On 31/03/2023 11:07, Bryan O'Donoghue wrote: >>> On 31/03/2023 07:20, Azam Sadiq Pasha Kapatrala Syed wrote: >>>> + Nico (Linaro) >>>> Hi Team >>>> >>>> Would like to know if anything is pending form our end as we want >>>> to get the patches mainlined? >>>> >>>> Thanks, >>>> Azam >>> >>> I'd like to get a clearer picture on this >>> >>> [   90.535909] qcom-camss ac6a000.camss: VFE HW Version = 2.0.1 >>> [   90.545756] qcom-camss ac6a000.camss: CSIPHY 3PH HW Version = >>> 0x40010000 >>> [   90.546358] qcom-camss ac6a000.camss: CSID HW Version = 2.0.1 >>> [   90.546365] qcom-camss ac6a000.camss: csid_link_setup: Enabled >>> CSID virtual channels mask 0x1 >>> [   90.547675] qcom-camss ac6a000.camss: csid_link_setup: Enabled >>> CSID virtual channels mask 0x0 >>> >>> Using the IMX577 sensor on the RB5 we get his pretty odd virtual >>> channels mask. >>> >>> If userspace is sending this in, the question I have is why. Surely >>> with a sensor that doesn't have a VC there should be no impact on >>> user-space. >>> >>> --- >>> bod >> >> Hey Bryan, >> >> what media-ctl commands are you using? I can't recreate this on my >> side. I am using this set of commands to test (with the default >> imx577 driver without any multiple virtual channels outputs) and am >> getting only the first message (virtual channels mask 0x1): >> >> media-ctl --reset >> media-ctl -v -d /dev/media0 -V '"imx577 >> '22-001a'":0[fmt:SRGGB10/4056x3040 field:none]' >> media-ctl -V '"msm_csiphy2":0[fmt:SRGGB10/4056x3040]' >> media-ctl -V '"msm_csid0":0[fmt:SRGGB10/4056x3040]' >> media-ctl -V '"msm_vfe0_rdi0":0[fmt:SRGGB10/4056x3040]' >> media-ctl -l '"msm_csiphy2":1->"msm_csid0":0[1]' >> media-ctl -l '"msm_csid0":1->"msm_vfe0_rdi0":0[1]' >> >> yavta -B capture-mplane -c -I -n 5 -f SRGGB10P -s 4056x3040 -F >> /dev/video0 >> >> >> Thanks, >> >> Milen > > Its a dev_dbg() so "#define DEBUG 1" in > drivers/media/platform/qcom/camss/camss-csid.c > > --- > bod > Yes, I enabled the dev_dbg(). I just see only one message with regards to the channels mask. Just this one: [   90.546365] qcom-camss ac6a000.camss: csid_link_setup: Enabled CSID virtual channels mask 0x1 so I wonder if you're testing with a different set of media-ctl/yavta commands. Regards, Milen